Adjust logbook stream consumer to handle new metadata#12755
Merged
balloob merged 1 commit intohome-assistant:devfrom May 24, 2022
Merged
Adjust logbook stream consumer to handle new metadata#12755balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
22 tasks
bdraco
commented
May 24, 2022
| this._logbookEntries = newEntries; | ||
| return; | ||
| } | ||
| if (!newEntries.length) { |
Member
Author
There was a problem hiding this comment.
This will fix the Cannot read properties of undefined (reading 'when') error logbook data is empty for the live period.
I noticed it when I put the prerelease from an hour ago on my RPi3 (not powerful enough to run the dev setup for frontend so I have to wait for releases to test)
Member
Author
There was a problem hiding this comment.
Besides that, logbook is quite responsive on my RPi3 test machine with the lowest quality micro sd card I have that I could get to boot for testing.
balloob
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for home-assistant/core#72394
Proposed change
Adjust logbook stream consumer to handle new metadata
The response format has changed to allow for metadata:
eventsnow contains the event streamstart_timeis the start time of the query against the historical data (only present for historical data)end_timeis the end time of the query against the historical data (only present for historical data)partialif present indicates more historical data is coming in a future message.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: