Merged
Conversation
bramkragten
reviewed
May 16, 2022
| margin-left: var(--mdc-list-item-graphic-margin, 16px) !important; | ||
| margin-right: 0px !important; | ||
| span.material-icons:first-of-type { | ||
| margin-inline-start: 0px !important; |
Contributor
Author
There was a problem hiding this comment.
Yes because otherwise margin-right overwrites it with 16 from
:host([graphic=avatar]) .mdc-deprecated-list-item__graphic, :host([graphic=medium]) .mdc-deprecated-list-item__graphic, :host([graphic=large]) .mdc-deprecated-list-item__graphic, :host([graphic=control]) .mdc-deprecated-list-item__graphic {
margin-left: 0;
margin-right: var(--mdc-list-item-graphic-margin, 16px);
}
Member
There was a problem hiding this comment.
You should try to use the exact same selector used as you want to override, then you dont need important.
bramkragten
reviewed
May 16, 2022
| color: inherit; | ||
| } | ||
| .header_title { | ||
| margin-right: 40px; |
bramkragten
reviewed
May 16, 2022
Comment on lines
+187
to
+188
| inset-inline-start: 16px !important; | ||
| inset-inline-end: initial !important; |
Contributor
Author
There was a problem hiding this comment.
Yes otherwise overruled by:
.mdc-text-field--with-leading-icon.mdc-text-field--filled .mdc-floating-label {
max-width: calc(100% - 48px);
left: 48px;
right: initial;
Member
|
I think all of this could work without |
Contributor
Author
|
Many get overruled by MWC |
bramkragten
approved these changes
May 16, 2022
balloob
reviewed
May 17, 2022
| } | ||
| .card-menu { | ||
| float: right; | ||
| float: var(--float-end, right); |
balloob
reviewed
May 17, 2022
| } | ||
| .card-menu { | ||
| float: right; | ||
| float: var(--float-end, right); |
balloob
reviewed
May 17, 2022
| } | ||
| .card-menu { | ||
| float: right; | ||
| float: var(--float-end, right); |
balloob
reviewed
May 17, 2022
| this.style.direction = direction; | ||
| document.dir = direction; | ||
| this.style.setProperty("--direction", direction); | ||
| this.style.setProperty("--float-end", "left"); |
Member
|
float-end fix in #12707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Removal of host-context to handle RTL so that we support Firefox and Safari properly
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: