Skip to content

Support requesting translations for multiple integrations in a single request#71979

Merged
bdraco merged 4 commits intohome-assistant:devfrom
bdraco:request_multiple_translations
May 17, 2022
Merged

Support requesting translations for multiple integrations in a single request#71979
bdraco merged 4 commits intohome-assistant:devfrom
bdraco:request_multiple_translations

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented May 17, 2022

Frontend: home-assistant/frontend#12704

Proposed change

I finally got around to figuring out why the integrations page loaded slowly on many of my instances.

The goal is to reduce the number of requests when loading the integrations page when there are a number of discoveries. As I have pages of these:
Screen Shot 2022-05-16 at 19 26 33

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants