Use new localized context state and source in logbook#12742
Use new localized context state and source in logbook#12742zsarnett merged 11 commits intohome-assistant:devfrom
Conversation
- Refactor to remove more static english strings that come from the backend
c73d5c2 to
e9f9da8
Compare
|
I moved |
|
I've really tried to understand the PR and I'm not sure if it fully fixes #12698 ... It looks much much better (eg. Something like this can be traslated more easier: |
|
We can merge today most likely. Ill review this soon. Just need to fix the conflicts with your other PR |
Unfortunately, while it is easier to translate, splitting makes it look inconstant which means it would need a UX redesign which is outside the scope of this PR. Since this is an improvement over the last iteration, and it will make it easier to refactor into a multi-line setup later. I suggest we merge this now and iterate on the UX design in the future. |
I totally agree 👍 It is already an improvement 👍 I just hope that the UX redesign will not be forgotten :) |
Does not need to wait for home-assistant/core#72333 since we can't rewrite history. (the
sourcewas only exposed on the original message and missing from the context message).Proposed change
Refactor to remove more static english strings that come from the backend
Everything should be localized except for external events (https://github.com/home-assistant/frontend/pull/12742/files#diff-fe0260e1d2f2eea8dcb455d644828da865c94f2522881f2abd0a24012f808cc0R413)
Fixes #12698 (except for the backend messages that come from integrations since we don't control thoose)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: