Skip to content

Guard calling input select row with bad option#12181

Merged
zsarnett merged 1 commit intodevfrom
guard-bad-options
Apr 1, 2022
Merged

Guard calling input select row with bad option#12181
zsarnett merged 1 commit intodevfrom
guard-bad-options

Conversation

@balloob
Copy link
Member

@balloob balloob commented Mar 31, 2022

Breaking change

Proposed change

Fixes #11991

Guess it can happen sometimes we get a value changed without the option attached.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added this to the 2022.4.0 milestone Mar 31, 2022
@zsarnett zsarnett merged commit 419d659 into dev Apr 1, 2022
@zsarnett zsarnett deleted the guard-bad-options branch April 1, 2022 01:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sporadic warnings in log referencing invalid input_selection options.

3 participants