Skip to content

Move Logbook and make device page better#12763

Merged
bramkragten merged 8 commits intodevfrom
Move-Logbook+Device-Page-change
May 25, 2022
Merged

Move Logbook and make device page better#12763
bramkragten merged 8 commits intodevfrom
Move-Logbook+Device-Page-change

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented May 24, 2022

Breaking change

Proposed change

Move Logbook to right on Device page
Fixes height on Logbook in Area Page

Updates device actions to be in overflow
Places ZHA and Zwave Device information in expansion panel

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

</div>
`
: ""}
<ha-expansion-panel .header=${"Zigbee info"}>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ha-expansion-panel .header=${"Zigbee info"}>
<ha-expansion-panel header="Zigbee info">

@bramkragten
Copy link
Copy Markdown
Member

We should prevent having an action bar with just an overflow, especially if that overflow only has 1 option.

bramkragten
bramkragten previously approved these changes May 25, 2022
@bramkragten bramkragten enabled auto-merge (squash) May 25, 2022 12:42
@bramkragten bramkragten merged commit e61aa26 into dev May 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the Move-Logbook+Device-Page-change branch May 25, 2022 12:55
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New area logbook visual issues

3 participants