Use logbook livestream when requesting a time window that includes the future#12744
Merged
zsarnett merged 25 commits intohome-assistant:devfrom May 23, 2022
Merged
Use logbook livestream when requesting a time window that includes the future#12744zsarnett merged 25 commits intohome-assistant:devfrom
zsarnett merged 25 commits intohome-assistant:devfrom
Conversation
Member
Author
|
I wish I could figure out how to make the new rows fade in |
22 tasks
Member
Author
|
Did some testing to make sure closing windows removes the subscriptions /developer-tools/event |
bdraco
commented
May 22, 2022
balloob
reviewed
May 22, 2022
balloob
previously approved these changes
May 22, 2022
Member
Author
|
I pulled the power on the access point my phone was connected to, watched it switch to 5g, continue to stream, and waited for the AP to power back up. It successfully recovered streaming events during the switch over and switch back |
Member
Author
|
I think there is a bug here where its subscribing, unsubscribe, then subscribing when the logbook page loads |
Member
Author
|
Still have one issue. It spins if you reload the page and the live stream is running. |
Member
Author
|
So a hard refresh
|
Member
|
that's weird it would be set to undefined. That is a bug. |
balloob
approved these changes
May 23, 2022
zsarnett
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires home-assistant/core#72258
Proposed change
Use logbook livestream when requesting a time window that includes the future
Mobile



Main panel
Areas
More info

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: