Conversation
Just curios: Is there a reason for that? Hiding things in sub menus without a real need always introduces extra clicks. On a hardware dedicated page, those buttons seem rather fitting. |
The plans for this page will continue to grow and going ahead and placing them here will be the best instead of waiting. Something we should have done before |
| documentationURL = boardData.url; | ||
| imageURL = hardwareBrandsUrl({ | ||
| domain: "boards", | ||
| name: `${boardData.board.manufacturer}_${boardData.board.model}`, |
There was a problem hiding this comment.
should we not just pass manufacturer and model as separate params and let hardwareBrandsUrl handle concatenation?
There was a problem hiding this comment.
Im not sure that we can guarentee that manufacturer and model will be the defining points for this. Zwave devices for example. they may have other features to define the name
But I think we can do this for now and pivot
| this._OSData = await fetchHassioHassOsInfo(this.hass); | ||
| } | ||
| if (isComponentLoaded(this.hass, "hassio")) { | ||
| this._hostData = await fetchHassioHostInfo(this.hass); |
There was a problem hiding this comment.
now host data is not loaded when the hardware integration is loaded?
4 participants
Breaking change
Moves Reboot and Shutdown to overflow (not really breaking)
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: