Show the integration brand icon when there is no entity in logbook#12713
Merged
balloob merged 5 commits intohome-assistant:devfrom May 18, 2022
Merged
Show the integration brand icon when there is no entity in logbook#12713balloob merged 5 commits intohome-assistant:devfrom
balloob merged 5 commits intohome-assistant:devfrom
Conversation
- As more integration add logbook descriptions they will have no icon. We can use the brand icon for the integration when when we do not have an icon.
bdraco
changed the title
22 tasks
This comment was marked as outdated.
This comment was marked as outdated.
balloob
reviewed
May 18, 2022
| (!stateObj && | ||
| !overrideIcon && | ||
| item.domain && | ||
| isComponentLoaded(this.hass, item.domain) |
Member
Author
There was a problem hiding this comment.
I figured we didn't want the overhead of loading an image if it was likely to not exist and they would get 'icon not found' image which didn't look so hot in this context
balloob
approved these changes
May 18, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
have no icon. We can use the brand icon for the integration
when when we do not have an icon.
Before
After
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: