Add controller statistics to zwave_js config dashboard#12668
Merged
bramkragten merged 6 commits intohome-assistant:devfrom May 25, 2022
Merged
Add controller statistics to zwave_js config dashboard#12668bramkragten merged 6 commits intohome-assistant:devfrom
bramkragten merged 6 commits intohome-assistant:devfrom
Conversation
This was referenced May 12, 2022
Member
|
Can we put this in a expandable panel? As it is pretty technical advanced data? |
bramkragten
reviewed
May 19, 2022
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Show resolved
Hide resolved
bramkragten
reviewed
May 19, 2022
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Outdated
Show resolved
Hide resolved
raman325
force-pushed
the
controller_statistics
branch
from
b8df06d to
3519c3b
Compare
balloob
reviewed
May 20, 2022
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Show resolved
Hide resolved
bramkragten
reviewed
May 24, 2022
Comment on lines
+240
to
+246
| <span> | ||
| ${this.hass.localize( | ||
| "ui.panel.config.zwave_js.dashboard.driver_version" | ||
| )}: | ||
| </span> | ||
| <span>${this._network.client.driver_version}</span> | ||
| </div> |
Member
There was a problem hiding this comment.
Should we use the list items for the top part too?
Contributor
Author
There was a problem hiding this comment.
the reason I didn't make that change is because the mwc-list makes it harder to copy and paste the information out of there. Maybe this isn't an issue now that we have diagnostics
Contributor
Author
There was a problem hiding this comment.
I don't think it looks good. There's probably some CSS that can be done to make this look better, but that's a bit above my pay grade 🙂
Member
There was a problem hiding this comment.
OK, let's keep it as you have it for now then 😄
bramkragten
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds controller statistics to the zwave_js config dashboard (screenshot below). I added tooltips because the statistics are not easily understandable but the zwave-js provide clear definitions for each. An example of the tooltip is included in the screenshot. I also formatted the statistics and the properties above it into tables so that it's a little cleaner looking. I'm guessing there's probably a better approach than an HTML table so open to making changes as needed
Dependent on home-assistant/core#71723 (merged)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: