Skip to content

Fix setting _externalAccess#12584

Merged
zsarnett merged 1 commit intodevfrom
_externalAccess_fix
May 4, 2022
Merged

Fix setting _externalAccess#12584
zsarnett merged 1 commit intodevfrom
_externalAccess_fix

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 4, 2022

Breaking change

Proposed change

You can have cloud loaded and not in use (its a part of default config), and you can still have external_url set correctly and being used.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added this to the 2022.5.0 milestone May 4, 2022
@zsarnett zsarnett merged commit 552c474 into dev May 4, 2022
@zsarnett zsarnett deleted the _externalAccess_fix branch May 4, 2022 13:17
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants