Skip to content

Support requesting translations for multiple integrations in one request#12704

Merged
balloob merged 8 commits intohome-assistant:devfrom
bdraco:multiple_translations_at_once
May 18, 2022
Merged

Support requesting translations for multiple integrations in one request#12704
balloob merged 8 commits intohome-assistant:devfrom
bdraco:multiple_translations_at_once

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented May 17, 2022

Proposed change

Requires home-assistant/core#71979

This fixes an issue where the translations didn't appear right away when there are a large number of discoveries.

Onboarding calls look much cleaner now vs home-assistant/core#71979 (comment)

Screen Shot 2022-05-16 at 20 24 16

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bdraco
Copy link
Member Author

bdraco commented May 17, 2022

Need to figure out how to memorize that is already has them since opening the flow requests again

@bdraco
Copy link
Member Author

bdraco commented May 17, 2022

After reverting to dev, that seems like it is an existing issue. AFAICT, They are unconditionally loaded even if they have been fetched before.

@bdraco bdraco marked this pull request as ready for review May 17, 2022 01:35
balloob
balloob previously approved these changes May 17, 2022
@balloob balloob merged commit af6b0d3 into home-assistant:dev May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants