Skip to content

Fixes logbook#12740

Merged
balloob merged 1 commit intodevfrom
logbook-fixes
May 20, 2022
Merged

Fixes logbook#12740
balloob merged 1 commit intodevfrom
logbook-fixes

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 20, 2022

Breaking change

Proposed change

  • Fix recent time in logbook card. Recent time is in seconds, not microseconds.
  • When tracking recent entries, filter out old entries so we don't create a never ending increasing list which can cause OOM issues.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit fae1bcf into dev May 20, 2022
@balloob balloob deleted the logbook-fixes branch May 20, 2022 18:25
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants