Skip to content

Add logbook to area info page#12715

Merged
balloob merged 1 commit intodevfrom
area-logbook
May 17, 2022
Merged

Add logbook to area info page#12715
balloob merged 1 commit intodevfrom
area-logbook

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 17, 2022

Breaking change

Proposed change

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 17, 2022

Needs the same guarding as #12714 if there are no entities it fetches all the logbook history

@balloob
Copy link
Copy Markdown
Member Author

balloob commented May 17, 2022

I've added that guarding to ha-logbook so when I merge or rebase this PR, it should get it.

https://github.com/home-assistant/frontend/blob/dev/src/panels/logbook/ha-logbook.ts#L182-L184

@balloob balloob merged commit 5fb1504 into dev May 17, 2022
@balloob balloob deleted the area-logbook branch May 17, 2022 19:20
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants