Add configuration panel for Application Credentials#12344
Add configuration panel for Application Credentials#12344bramkragten merged 14 commits intohome-assistant:devfrom
Conversation
|
@matthiasdebaat Let's talk about this. Not sure where this should be. The configuration sections are all changing so this will definitely not stay where is but maybe move to the system tab 🤷 |
Thanks, really appreciate this. I'll continue to work on the functionality, thought just wanted to flag this early. |
@zsarnett i saw you landed a config revamp. Do you have a more well formed opinion now of where this should land, or otherwise have any principles regarding the most recent revamp? I still have other pieces to iterate on fix up but thought I would ask while this was top of mind. |
cf07225 to
d3bfdc3
Compare
I just rebased and can see how |
|
Hey @allenporter , Sorry I should have sent a message yesterday. We believe the best place for this will be in an Overflow menu on the Integrations, Devices, Entities, and Helpers page. The overflow menu can link your configuration page but will not be included in the tabs above |
|
Oh no problem! Thanks for that, it makes sense to me as this is definitely integration related, and the only thing holding be back from placing it there was that it didn't seem anywhere near big enough to be on its own tab. My frontend development skills are definitely still in the range of "copying from existing examples". Is there prior art you can point me at I can borrow from? or maybe i can grab time with you to discuss in more detail an approach? As an example of the types if things i'm not sure how to navigate (so to speak): i was playing with this in server section and had a little trouble figuring out the right layout to use with the right set of things i need (e.g. fab, tabs, data table, header labels, etc) as nothing existing seemed to have that combination, then had a little trouble knowing when to reuse vs when to go custom. |
|
Similar to the help icon except you will need to use an overflow button Overflow Icon Button |
|
Something like this <ha-button-menu
corner="BOTTOM_START"
slot="toolbar-icon"
activatable
>
<ha-icon-button
slot="trigger"
.label=${this.hass.localize("ui.common.menu")}
.path=${mdiDotsVertical}
></ha-icon-button>
<ha-clickable-list-item
@click=${this._entryClicked}
href="/config/lovelace/resources"
aria-label=${this.hass.localize(
"ui.panel.config.lovelace.resources.caption"
)}
>
${this.hass.localize(
"ui.panel.config.lovelace.resources.caption"
)}
</ha-clickable-list-item>
</ha-button-menu> |
d3bfdc3 to
51d6e97
Compare
|
I'll try to take a look this weekend or Monday |
|
No rush, I also need to do one last selector for an integration drop down |
|
Awesome work @allenporter! |
ece12da to
d987131
Compare
|
I messed up the git commands but should be all fixed up now. Your commits are all the first commit now... Sorry about that. But the overflow should be good |
|
@zsarnett 🔥 🔥🔥🔥!!!! thank you, so kind of you. I now will work on making the integration selector and take out of draft. |
|
When the backend gets merged can you set it back to ready for review? |
src/panels/config/application_credentials/dialog-add-application-credential.ts
Show resolved
Hide resolved
src/panels/config/application_credentials/dialog-add-application-credential.ts
Show resolved
Hide resolved
src/panels/config/application_credentials/dialog-add-application-credential.ts
Outdated
Show resolved
Hide resolved
src/panels/config/application_credentials/dialog-add-application-credential.ts
Outdated
Show resolved
Hide resolved
src/panels/config/application_credentials/dialog-add-application-credential.ts
Outdated
Show resolved
Hide resolved
Core PR said: So figured i'd get your pulse before actually merging. |
src/panels/config/application_credentials/dialog-add-application-credential.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Zack Barett <zackbarett@hey.com>
c2cedd2 to
d03798a
Compare
src/panels/config/application_credentials/dialog-add-application-credential.ts
Outdated
Show resolved
Hide resolved
yarn prettier --write src/panels/config/application_credentials/dialog-add-application-credential.ts
|
Whoops, noticed I had a lint error, fixed. |




Proposed change
Add a configuration panel for Application Credentials which allow users to configure OAuth Client ID and OAuth Client
Secret for an integration using the user interface.
Work in progress:
#devs_us)Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: