Add option to compare energy graphs with previous period#12723
Merged
Conversation
balloob
reviewed
May 18, 2022
|
|
||
| const dayDifference = differenceInDays(end || new Date(), start); | ||
| const period = | ||
| dayDifference > 35 ? "month" : dayDifference > 2 ? "day" : "hour"; |
balloob
reviewed
May 18, 2022
src/panels/energy/ha-panel-energy.ts
Outdated
| key: "energy_dashboard", | ||
| }); | ||
| energyCollection.setCompare(this._compare); | ||
| energyCollection.refresh(); |
Member
There was a problem hiding this comment.
We only need to refresh if compare is now true and it's not loaded for current period yet?
balloob
reviewed
May 18, 2022
src/panels/energy/ha-panel-energy.ts
Outdated
| .path=${mdiDotsVertical} | ||
| slot="trigger" | ||
| ></ha-icon-button> | ||
| <ha-check-list-item left .selected=${this._compare}> |
Member
There was a problem hiding this comment.
Let's show this as a "comparing mode enabled" bar in the UI at the top. Probably ha-alert?
balloob
reviewed
May 18, 2022
src/panels/energy/ha-panel-energy.ts
Outdated
| collectionKey="energy_dashboard" | ||
| ></hui-energy-period-selector> | ||
| `} | ||
| <ha-button-menu |
Member
There was a problem hiding this comment.
Let's make this a button, "COMPARE DATA" maybe as label? Or this icon
balloob
reviewed
May 18, 2022
balloob
reviewed
May 18, 2022
| @@ -0,0 +1,113 @@ | |||
| import { differenceInDays, endOfDay } from "date-fns"; | |||
Member
There was a problem hiding this comment.
Suggested change
| import { differenceInDays, endOfDay } from "date-fns"; | |
| import { differenceInDays, endOfDay } from "date-fns/esm"; |
Member
Author
There was a problem hiding this comment.
It should already use that as it has:
"main": "index.js",
"module": "esm/index.js",
in package.json?
Member
There was a problem hiding this comment.
Oh. Well I just fixed it everywhere else 😅
balloob
previously approved these changes
May 18, 2022
balloob
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add option to compare energy graphs with previous period
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: