ci: fix preset in vs2022 mode

[alandtse]

Summary by CodeRabbit

• Chores
  • Improved CI/CD build configuration to support multiple compiler presets and distinct build directories.
  • Enhanced cache validation and cleanup processes for more reliable and efficient automated builds.

[coderabbitai]

📝 Walkthrough

Walkthrough

The setup-build-environment GitHub Actions composite action now accepts parameterized cmake-preset and build-dir inputs (defaults: ALL and build/ALL), replacing hard-coded paths. The stale-cache detection logic now resolves CMAKE_GENERATOR by looking up the configured preset in CMakePresets.json with recursive inherits chain traversal. The build workflow matrix defines per-compiler preset and output directory values that propagate through all subsequent build steps.

Changes

Cohort / File(s)	Summary
Setup Build Environment Action .github/actions/setup-build-environment/action.yaml	Added cmake-preset and build-dir composite-action inputs. Updated cache path configuration and stale-cache detection to use parameterized build-dir. Enhanced CMAKE_GENERATOR resolution to recursively follow preset inherits chains in CMakePresets.json.
Build Workflow Matrix .github/workflows/build.yaml	Updated build matrix to define per-compiler cmake-preset and build-dir values. Refactored all CMake, testing, and shader compilation steps to use matrix-driven values instead of hard-coded ALL/build/ALL paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• build: update template to avoid extra directory #1812 — Introduces binaryDir field in CMake presets to parameterize output directory configuration.
• build: update to VS 2026 #1990 — Enhances CMAKE_GENERATOR resolution and cache detection logic in the setup-build-environment action.
• ci: add checks to build #1170 — Modifies stale-cache detection and removal for CMakeCache.txt in the build output directory.

Suggested reviewers

• doodlum
• jiayev

Poem

🐰 The matrix hops with presets spry,
Each compiler gets its build-dir nigh,
Cache logic digs through inheritance deep,
While workflows dance—no hard-codes to keep!
Parameterized paths make CMake serene. 🏗️

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'ci: fix preset in vs2022 mode' directly relates to the main changes: updating GitHub Actions workflow and setup-build-environment action to support configurable CMake presets and build directories, with specific VS2022 preset handling.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

🧹 Nitpick comments (1)

.github/actions/setup-build-environment/action.yaml (1)

127-138: Consider guarding against null inherits before iteration.

When a preset has no inherits property, @($p.inherits) creates an array containing $null, causing an unnecessary recursive call. While functionally correct (returns $null as expected), adding a null check improves clarity and efficiency.

🔧 Proposed refinement

                   if ($p.generator) { return $p.generator }
+                  if (-not $p.inherits) { return $null }
                   $parents = if ($p.inherits -is [array]) { $p.inherits } else { @($p.inherits) }
                   foreach ($parent in $parents) {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/actions/setup-build-environment/action.yaml around lines 127 - 138,
The Resolve-PresetGenerator function currently always wraps $p.inherits in
@(...) which yields an array with $null when inherits is absent; modify the
logic to first check that $p.inherits is not $null (and not empty) before
constructing $parents so you only iterate actual parents. Concretely, update the
$parents assignment in Resolve-PresetGenerator to guard against $null (e.g., if
($p.inherits -ne $null) { $parents = ... } else { $parents = @() }) and then
iterate $parents, leaving the rest of the recursion unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/actions/setup-build-environment/action.yaml:
- Around line 127-138: The Resolve-PresetGenerator function currently always
wraps $p.inherits in @(...) which yields an array with $null when inherits is
absent; modify the logic to first check that $p.inherits is not $null (and not
empty) before constructing $parents so you only iterate actual parents.
Concretely, update the $parents assignment in Resolve-PresetGenerator to guard
against $null (e.g., if ($p.inherits -ne $null) { $parents = ... } else {
$parents = @() }) and then iterate $parents, leaving the rest of the recursion
unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d4031117-eeb1-46db-9810-6e48cdf5a5b5

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0d0d7 and f5da19a.

📒 Files selected for processing (2)

• .github/actions/setup-build-environment/action.yaml
• .github/workflows/build.yaml

[alandtse]

Merging despite failing 2022 builds since this is intended to fix.