Skip to content

feat(weather editor): add delete json button to objects window#1914

Merged
davo0411 merged 8 commits into
community-shaders:devfrom
SkrubbySkrubInAShrub:json-object-list
Feb 20, 2026
Merged

feat(weather editor): add delete json button to objects window#1914
davo0411 merged 8 commits into
community-shaders:devfrom
SkrubbySkrubInAShrub:json-object-list

Conversation

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented Feb 19, 2026

  • Shows which objects have a json file active
  • Allows deletion of the json file without openign the object widget
  • Sorting functionality

Summary by CodeRabbit

  • New Features

    • JSON attachment management with per-widget caching and visual indicators in the widget list
    • New JSON column in the widget details table for visibility
    • JSON-aware sorting to prioritize widgets with attachments
  • Bug Fixes / Improvements

    • Inline JSON delete action with confirmation modal and improved delete workflow
    • Cache invalidation on resource updates and after widget changes to keep state consistent
    • Improved multi-column row interactions and delete-button styling for more reliable UX

SkrubbySkrubInAShrub and others added 2 commits February 20, 2026 00:35
Automated formatting by clang-format, prettier, and other hooks.
See https://pre-commit.ci for details.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 19, 2026

📝 Walkthrough

Walkthrough

Adds a per-widget JSON-attachment cache, a new JSON column and delete button in the details table, JSON-aware sorting, a global confirmation modal for JSON deletion, cache invalidation hooks, and widget notifications when their JSON attachment changes.

Changes

Cohort / File(s) Summary
EditorWindow core & cache
src/WeatherEditor/EditorWindow.h, src/WeatherEditor/EditorWindow.cpp
Added jsonAttachmentCache (std::unordered_map<Widget*, bool>), methods RefreshJsonAttachmentCache, HasCachedJsonAttachment, InvalidateJsonAttachmentCache, OnWidgetJsonAttachmentChanged, pendingDeleteWidget/pendingDeletePopupRequested. Invalidate cache in SetupResources() and call refresh before sorting.
Details table & sorting
src/WeatherEditor/EditorWindow.cpp
Expanded details table from 5→6 columns (new JSON column), introduced enum-based ColumnID and SortColumn::JsonAttachment, wired sort mapping from ImGui specs to new column, updated sorting to prioritize cached JSON attachments, added JSON delete button rendering and ImGuiSelectableFlags_AllowOverlap adjustments.
Widget deletion & modal API
src/WeatherEditor/Widget.h, src/WeatherEditor/Widget.cpp
Changed DrawDeleteConfirmationModal()DrawDeleteConfirmationModal(const char* popupId = "DeleteConfirmation"); widgets notify editor via EditorWindow::GetSingleton()->OnWidgetJsonAttachmentChanged(this) after save/delete; refactored delete button styling to Util::ErrorButtonStyle().
UI flow & modal
src/WeatherEditor/EditorWindow.cpp
Added global JSON delete confirmation modal (ListDeleteConfirmation), pending delete state flow, and reset logic after modal closes.

Sequence Diagram

sequenceDiagram
    participant User
    participant EditorWindow as EditorWindow UI
    participant Widget
    participant JsonCache as JsonCache

    User->>EditorWindow: Click JSON delete button
    EditorWindow->>EditorWindow: Set pendingDeleteWidget + open modal
    User->>EditorWindow: Confirm deletion
    EditorWindow->>Widget: Invoke delete JSON attachment
    Widget->>Widget: Remove saved JSON state
    Widget->>EditorWindow: OnWidgetJsonAttachmentChanged(widget)
    EditorWindow->>JsonCache: InvalidateJsonAttachmentCache(widget)
    EditorWindow->>EditorWindow: RefreshJsonAttachmentCache(sortedWidgets) / Refresh UI
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Suggested reviewers

  • davo0411
  • doodlum

Poem

🐰 I nibbled bytes and stored a tiny trace,
A JSON crumb behind each widget's face.
A button blinks — confirm, then hop away,
The cache forgets, the lists are neat today.
Hooray for tidy fields and clearer play!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 6.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main feature: adding a delete JSON button to the objects window. This aligns with the primary changes of introducing a new JSON delete button column, cache mechanism for JSON attachments, and sorting functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2026

Using provided base ref: e825ccc
Using base ref: e825ccc
Base commit date: 2026-02-20T19:54:03+10:00 (Friday, February 20, 2026 07:54 PM)
No actionable suggestions for changed features.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (3)
src/WeatherEditor/EditorWindow.cpp (2)

134-706: Conventional commit: use lowercase description and consider adding a scope.

Per project guidelines, commit titles should use a lowercase description. The PR title also benefits from a scope to make it easier to search:

feat(weather-editor): add delete json button to objects window
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/WeatherEditor/EditorWindow.cpp` around lines 134 - 706, The commit
message uses an uppercase description and lacks a scope; update the commit/title
to follow conventional commits with a lowercase description and a scope—for
example change the PR title to "feat(weather-editor): add delete json button to
objects window" (apply when creating the commit for changes in
EditorWindow::ShowObjectsWindow or related modifications) so it matches project
guidelines and improves searchability.

528-543: Duplicate json/delete column rendering — extract to a lambda.

These two blocks (lines 528–543 for the "current cell's lighting template" path and lines 666–681 for the regular list) are identical except for the ImageButton label prefix. Any future change (icon size, tooltip text, style) must be applied twice.

♻️ Suggested refactor — inline lambda before the table iteration
auto drawJsonDeleteColumn = [&](Widget* w, const char* idPrefix) {
    ImGui::TableNextColumn();
    if (HasCachedJsonAttachment(w)) {
        auto* menu = globals::menu;
        if (menu && menu->uiIcons.deleteSettings.texture) {
            const float iconSize = ImGui::GetFrameHeight() * 0.85f;
            {
                auto _style = Util::ErrorButtonStyle();
                ImGui::SetNextItemAllowOverlap();
                if (ImGui::ImageButton(std::format("{}_{}", idPrefix, w->GetFormID()).c_str(),
                        menu->uiIcons.deleteSettings.texture, { iconSize, iconSize }))
                    pendingDeleteWidget = w;
            }
            if (ImGui::IsItemHovered())
                ImGui::SetTooltip("Delete json file");
        }
    }
};

Then replace both blocks:

- // json / delete column
- ImGui::TableNextColumn();
- if (HasCachedJsonAttachment(sortedWidgets[i])) {
-     ...
- }
+ drawJsonDeleteColumn(sortedWidgets[i], "##jsondel_cur");   // current-cell path
// and
+ drawJsonDeleteColumn(sortedWidgets[i], "##jsondel");       // regular list path

Also applies to: 666-681

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/WeatherEditor/EditorWindow.cpp` around lines 528 - 543, Extract the
duplicated JSON/delete column rendering into a local lambda (e.g.,
drawJsonDeleteColumn) that takes the Widget* (or Widget& w) and a const char*
idPrefix, and inside it call ImGui::TableNextColumn(), check
HasCachedJsonAttachment(w), read globals::menu and
menu->uiIcons.deleteSettings.texture, compute iconSize via
ImGui::GetFrameHeight() * 0.85f, scope Util::ErrorButtonStyle(), call
ImGui::SetNextItemAllowOverlap(), and call ImGui::ImageButton with
std::format("{}_{}", idPrefix, w->GetFormID()).c_str() to set
pendingDeleteWidget on click and show the same tooltip when hovered; then
replace both duplicated blocks (the one using the "current" label and the
regular list) with calls to drawJsonDeleteColumn(sortedWidgets[i],
"##jsondel_cur") and drawJsonDeleteColumn(sortedWidgets[i], "##jsondel") (or the
exact prefixes used) respectively.
src/WeatherEditor/EditorWindow.h (1)

208-216: Fragile SortColumn-to-column-index coupling via static_cast.

EditorWindow.cpp line 292 converts spec.ColumnIndex directly: currentSortColumn = static_cast<SortColumn>(spec.ColumnIndex). This works today because the enum values exactly match the column indices (0–5), but it silently breaks if any column is inserted, removed, or reordered.

Note: this also fixes a pre-existing bug where SortColumn::Status was absent — sorting by that column previously fell through to default: break and did nothing.

♻️ Suggested approach: map column index via a lookup table
- currentSortColumn = static_cast<SortColumn>(spec.ColumnIndex);
+ static constexpr SortColumn kColumnToSort[] = {
+     SortColumn::None,          // 0 – Fav (NoSort)
+     SortColumn::EditorID,      // 1
+     SortColumn::FormID,        // 2
+     SortColumn::File,          // 3
+     SortColumn::Status,        // 4
+     SortColumn::JsonAttachment, // 5
+ };
+ if (spec.ColumnIndex < IM_ARRAYSIZE(kColumnToSort))
+     currentSortColumn = kColumnToSort[spec.ColumnIndex];
+ else
+     currentSortColumn = SortColumn::None;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/WeatherEditor/EditorWindow.h` around lines 208 - 216, The code currently
relies on a fragile static_cast from spec.ColumnIndex to the SortColumn enum
(SortColumn) when assigning currentSortColumn, which breaks if columns are
reordered or changed; replace the static_cast with an explicit mapping (e.g.,
constexpr array or switch) that maps each column index (spec.ColumnIndex) to the
corresponding SortColumn value, validate bounds and fall back to
SortColumn::None for unknown indices, and ensure SortColumn::Status is included
in the mapping so sorting for that column is handled correctly (update the
assignment site that currently does currentSortColumn =
static_cast<SortColumn>(spec.ColumnIndex) to use this lookup).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/WeatherEditor/EditorWindow.cpp`:
- Around line 693-702: The code calls ImGui::OpenPopup every frame while
pendingDeleteWidget is set and always calls InvalidateJsonAttachmentCache when
the popup closes; change this to call ImGui::OpenPopup exactly once when the
popup is first requested and remove the redundant InvalidateJsonAttachmentCache
call on popup close. Concretely: introduce a boolean or check (e.g., a new flag
like pendingDeletePopupOpened or use ImGui::IsPopupOpen/BeginPopup to gate a
single OpenPopup call) so OpenPopup("ListDeleteConfirmation") is invoked only
once when pendingDeleteWidget is first assigned, keep
pendingDeleteWidget->DrawDeleteConfirmationModal("ListDeleteConfirmation")
as-is, and delete the InvalidateJsonAttachmentCache(pendingWidget) invocation
from the popup-close branch (relying on Delete() ->
OnWidgetJsonAttachmentChanged to handle invalidation on confirm).
- Around line 340-346: The JsonAttachment sort currently computes comparison as
static_cast<int>(bHasJson) - static_cast<int>(aHasJson) which places true before
false for ascending; change the arithmetic so ascending yields false before true
(e.g., set comparison = static_cast<int>(aHasJson) - static_cast<int>(bHasJson)
or otherwise invert the sign) in the SortColumn::JsonAttachment branch that uses
HasCachedJsonAttachment to ensure standard boolean sort direction; update only
the comparison assignment in EditorWindow.cpp.

In `@src/WeatherEditor/Widget.cpp`:
- Around line 17-20: The call to
EditorWindow::GetSingleton()->OnWidgetJsonAttachmentChanged(this) is invoked
before I/O in Widget::Save(), Widget::Load(), and Widget::Delete(); move that
call to the end of each function's success path so it runs only after the
operation completes successfully. Specifically, in Widget::Save() call
OnWidgetJsonAttachmentChanged(this) after SaveSettings() and any file-write
success checks; in Widget::Load() invoke it after the load completes and any
parsing checks; and in Widget::Delete() invoke it after the file is deleted
successfully. Ensure any early-return or error paths do not call
OnWidgetJsonAttachmentChanged so the cache/indicator is only invalidated on
successful completion.

---

Nitpick comments:
In `@src/WeatherEditor/EditorWindow.cpp`:
- Around line 134-706: The commit message uses an uppercase description and
lacks a scope; update the commit/title to follow conventional commits with a
lowercase description and a scope—for example change the PR title to
"feat(weather-editor): add delete json button to objects window" (apply when
creating the commit for changes in EditorWindow::ShowObjectsWindow or related
modifications) so it matches project guidelines and improves searchability.
- Around line 528-543: Extract the duplicated JSON/delete column rendering into
a local lambda (e.g., drawJsonDeleteColumn) that takes the Widget* (or Widget&
w) and a const char* idPrefix, and inside it call ImGui::TableNextColumn(),
check HasCachedJsonAttachment(w), read globals::menu and
menu->uiIcons.deleteSettings.texture, compute iconSize via
ImGui::GetFrameHeight() * 0.85f, scope Util::ErrorButtonStyle(), call
ImGui::SetNextItemAllowOverlap(), and call ImGui::ImageButton with
std::format("{}_{}", idPrefix, w->GetFormID()).c_str() to set
pendingDeleteWidget on click and show the same tooltip when hovered; then
replace both duplicated blocks (the one using the "current" label and the
regular list) with calls to drawJsonDeleteColumn(sortedWidgets[i],
"##jsondel_cur") and drawJsonDeleteColumn(sortedWidgets[i], "##jsondel") (or the
exact prefixes used) respectively.

In `@src/WeatherEditor/EditorWindow.h`:
- Around line 208-216: The code currently relies on a fragile static_cast from
spec.ColumnIndex to the SortColumn enum (SortColumn) when assigning
currentSortColumn, which breaks if columns are reordered or changed; replace the
static_cast with an explicit mapping (e.g., constexpr array or switch) that maps
each column index (spec.ColumnIndex) to the corresponding SortColumn value,
validate bounds and fall back to SortColumn::None for unknown indices, and
ensure SortColumn::Status is included in the mapping so sorting for that column
is handled correctly (update the assignment site that currently does
currentSortColumn = static_cast<SortColumn>(spec.ColumnIndex) to use this
lookup).

Comment thread src/WeatherEditor/EditorWindow.cpp
Comment thread src/WeatherEditor/EditorWindow.cpp
Comment thread src/WeatherEditor/Widget.cpp
@SkrubbySkrubInAShrub SkrubbySkrubInAShrub changed the title feat: Add delete json button to objectswindow feat(weather editor): add delete json button to objects window Feb 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2026

✅ A pre-release build is available for this PR:
Download

SkrubbySkrubInAShrub and others added 3 commits February 20, 2026 01:00
Automated formatting by clang-format, prettier, and other hooks.
See https://pre-commit.ci for details.
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
src/WeatherEditor/EditorWindow.cpp (2)

292-311: Hardcoded column indices in the sort switch are fragile.

Mapping spec.ColumnIndex values 1–5 directly to SortColumn cases will silently mis-sort if a column is inserted, removed, or reordered. ImGuiTableColumnSortSpecs::ColumnUserID is designed exactly for this: assign a unique uint32_t ID to each sortable column via the optional user_id argument to TableSetupColumn, then switch on ColumnUserID instead.

♻️ Proposed refactor (column IDs)
+enum ColumnID : uint32_t { ColFav = 0, ColEditorID, ColFormID, ColFile, ColStatus, ColJson };
 ImGui::TableSetupColumn("Fav",       ImGuiTableColumnFlags_WidthFixed | ImGuiTableColumnFlags_NoSort, 38.0f);
-ImGui::TableSetupColumn("Editor ID", ImGuiTableColumnFlags_WidthStretch, 3.5f);
-ImGui::TableSetupColumn("Form ID",   ImGuiTableColumnFlags_WidthFixed,   90.0f);
-ImGui::TableSetupColumn("File",      ImGuiTableColumnFlags_WidthStretch, 2.0f);
-ImGui::TableSetupColumn("Status",    ImGuiTableColumnFlags_WidthStretch, 1.5f);
-ImGui::TableSetupColumn("JSON",      ImGuiTableColumnFlags_WidthFixed,   55.0f);
+ImGui::TableSetupColumn("Editor ID", ImGuiTableColumnFlags_WidthStretch, 3.5f,  0, ColEditorID);
+ImGui::TableSetupColumn("Form ID",   ImGuiTableColumnFlags_WidthFixed,   90.0f, 0, ColFormID);
+ImGui::TableSetupColumn("File",      ImGuiTableColumnFlags_WidthStretch, 2.0f,  0, ColFile);
+ImGui::TableSetupColumn("Status",    ImGuiTableColumnFlags_WidthStretch, 1.5f,  0, ColStatus);
+ImGui::TableSetupColumn("JSON",      ImGuiTableColumnFlags_WidthFixed,   55.0f, 0, ColJson);
 // ...
-switch (spec.ColumnIndex) {
-case 1: currentSortColumn = SortColumn::EditorID; break;
-case 2: currentSortColumn = SortColumn::FormID; break;
-case 3: currentSortColumn = SortColumn::File; break;
-case 4: currentSortColumn = SortColumn::Status; break;
-case 5: currentSortColumn = SortColumn::JsonAttachment; break;
-default: currentSortColumn = SortColumn::None; break;
+switch (spec.ColumnUserID) {
+case ColEditorID: currentSortColumn = SortColumn::EditorID; break;
+case ColFormID:   currentSortColumn = SortColumn::FormID; break;
+case ColFile:     currentSortColumn = SortColumn::File; break;
+case ColStatus:   currentSortColumn = SortColumn::Status; break;
+case ColJson:     currentSortColumn = SortColumn::JsonAttachment; break;
+default:          currentSortColumn = SortColumn::None; break;
 }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/WeatherEditor/EditorWindow.cpp` around lines 292 - 311, The switch is
using fragile hardcoded spec.ColumnIndex values; change the table setup to
assign stable uint32_t user IDs for each sortable column via
TableSetupColumn(..., user_id) and then switch on spec.ColumnUserID (not
spec.ColumnIndex) to map to SortColumn (e.g., EditorID, FormID, File, Status,
JsonAttachment, None). Update the switch in EditorWindow.cpp to use
spec.ColumnUserID and ensure each column registration that calls
TableSetupColumn uses the corresponding unique user_id constant so
reordering/insertion won't break sorting.

374-390: std::format heap allocation inside the per-widget render loop.

Line 382 constructs a temporary std::string via std::format on every frame for every widget that is visible. Prefer a stack buffer to avoid repeated heap allocation in the hot render path.

♻️ Proposed fix
-if (ImGui::ImageButton(std::format("##jsondel_{}", widget->GetFormID()).c_str(), ...))
+char idBuf[32];
+snprintf(idBuf, sizeof(idBuf), "##jsondel_%s", widget->GetFormID().c_str());
+if (ImGui::ImageButton(idBuf, ...))
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/WeatherEditor/EditorWindow.cpp` around lines 374 - 390, The per-widget
render lambda drawJsonDeleteButton currently calls std::format("##jsondel_{}",
widget->GetFormID()) each frame which allocates on the heap; replace that with a
stack-allocated char buffer (e.g., char buf[32]) and write the ID into it using
snprintf or std::to_chars (format "##jsondel_<id>") before calling
ImGui::ImageButton, so the unique widget ID remains the same but avoids
per-frame heap allocations; update the ImageButton call in drawJsonDeleteButton
to use this buffer and keep pendingDeleteWidget/pendingDeletePopupRequested
logic unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/WeatherEditor/EditorWindow.cpp`:
- Around line 336-337: RefreshJsonAttachmentCache currently iterates
sortedWidgets and calls widget->HasSavedFile() (std::filesystem::exists) for
every widget on first view, causing an O(N) filesystem hit; change the approach
to populate the JSON-attachment cache lazily by moving the exists() check into
drawJsonDeleteButton (or whatever function renders per-widget UI) so only
visible/filtered widgets trigger HasSavedFile(), or implement an async/batched
prefetch that marks cache entries without blocking the UI; update
RefreshJsonAttachmentCache to only initialize metadata for already-visible
widgets (use the same visibility/filtering logic used when building the display
list) and remove the global eager loop over sortedWidgets to avoid the one-frame
stall.
- Line 283: Update the ImGui table column header string from "json" to "JSON" to
match the Title Case convention used by other headers; locate the
ImGui::TableSetupColumn call that currently passes "json" (in EditorWindow.cpp)
and replace the literal with "JSON" so the UI label is consistent with "Fav",
"Editor ID", "Form ID", "File", and "Status".

---

Nitpick comments:
In `@src/WeatherEditor/EditorWindow.cpp`:
- Around line 292-311: The switch is using fragile hardcoded spec.ColumnIndex
values; change the table setup to assign stable uint32_t user IDs for each
sortable column via TableSetupColumn(..., user_id) and then switch on
spec.ColumnUserID (not spec.ColumnIndex) to map to SortColumn (e.g., EditorID,
FormID, File, Status, JsonAttachment, None). Update the switch in
EditorWindow.cpp to use spec.ColumnUserID and ensure each column registration
that calls TableSetupColumn uses the corresponding unique user_id constant so
reordering/insertion won't break sorting.
- Around line 374-390: The per-widget render lambda drawJsonDeleteButton
currently calls std::format("##jsondel_{}", widget->GetFormID()) each frame
which allocates on the heap; replace that with a stack-allocated char buffer
(e.g., char buf[32]) and write the ID into it using snprintf or std::to_chars
(format "##jsondel_<id>") before calling ImGui::ImageButton, so the unique
widget ID remains the same but avoids per-frame heap allocations; update the
ImageButton call in drawJsonDeleteButton to use this buffer and keep
pendingDeleteWidget/pendingDeletePopupRequested logic unchanged.

Comment thread src/WeatherEditor/EditorWindow.cpp Outdated
Comment on lines +336 to 337
RefreshJsonAttachmentCache(sortedWidgets);
if (currentSortColumn != SortColumn::None) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

RefreshJsonAttachmentCache triggers O(N) filesystem I/O for all category widgets on first visit.

RefreshJsonAttachmentCache calls widget->HasSavedFile() (i.e., std::filesystem::exists()) for each widget not yet in the cache. Because this is called on sortedWidgets — the entire category list before filtering — all widgets in the category incur a filesystem hit on the first frame that category is viewed. For categories with many records (Skyrim has hundreds of weathers/lighting templates), this can cause a one-frame stall.

Consider populating the cache lazily in drawJsonDeleteButton (only for visible/filtered widgets) or batching it asynchronously. Alternatively, document the expected stall so it is a conscious trade-off.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/WeatherEditor/EditorWindow.cpp` around lines 336 - 337,
RefreshJsonAttachmentCache currently iterates sortedWidgets and calls
widget->HasSavedFile() (std::filesystem::exists) for every widget on first view,
causing an O(N) filesystem hit; change the approach to populate the
JSON-attachment cache lazily by moving the exists() check into
drawJsonDeleteButton (or whatever function renders per-widget UI) so only
visible/filtered widgets trigger HasSavedFile(), or implement an async/batched
prefetch that marks cache entries without blocking the UI; update
RefreshJsonAttachmentCache to only initialize metadata for already-visible
widgets (use the same visibility/filtering logic used when building the display
list) and remove the global eager loop over sortedWidgets to avoid the one-frame
stall.

SkrubbySkrubInAShrub and others added 3 commits February 20, 2026 11:52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@src/WeatherEditor/EditorWindow.cpp`:
- Around line 1861-1871: RefreshJsonAttachmentCache currently calls
widget->HasSavedFile() (which does filesystem::exists) for every widget not in
jsonAttachmentCache, causing O(N) FS hits on category open; remove that eager
population and make the cache lazy: change RefreshJsonAttachmentCache(…) to only
ensure entries are not removed (or to no-op) and move the
jsonAttachmentCache.emplace(widget, widget->HasSavedFile()) into
drawJsonDeleteButton so that drawJsonDeleteButton checks jsonAttachmentCache for
the widget and, on miss, calls widget->HasSavedFile() once and inserts the
result; reference jsonAttachmentCache, RefreshJsonAttachmentCache,
drawJsonDeleteButton, and HasSavedFile to locate and update the code.
- Line 294: The TableSetupColumn call uses a lowercase header string "json";
update the header to "JSON" in the ImGui::TableSetupColumn invocation that sets
up ColJson (ImGui::TableSetupColumn("json", ImGuiTableColumnFlags_WidthFixed,
55.0f, ColJson)) so it matches the Title Case style of the other columns.

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator Author

the rest of the AI comments are not relevant or I don't agree .

@davo0411 davo0411 merged commit 0828631 into community-shaders:dev Feb 20, 2026
16 checks passed
davo0411 added a commit to davo0411/skyrim-community-shaders that referenced this pull request Mar 28, 2026
* fix(weather overrides): ensure json format for features (community-shaders#1748)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* perf(terrain blending): tweak defaults (community-shaders#1771)

* fix(lighting): vanilla envcolor mult the correct value (community-shaders#1775)

* fix(water): remove final colour saturate (community-shaders#1778)

* fix(unified-water): LOD water cache mismatch (community-shaders#1779)

* fix(weather editor): override desync with weather transitions (community-shaders#1782)

* fix(weather editor): no-override weather file deletion (community-shaders#1777)

* fix(weather editor): apply weather settings post-load (community-shaders#1776)

* fix(weather editor): handling of weathers without overrides (community-shaders#1773)

* feat(UI): feature headings (community-shaders#1786)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(VR): add wand pointing (community-shaders#1790)

* chore(UI): theme consistency (community-shaders#1787)

* fix(upscaling): warn about max nvidia resolution (community-shaders#1795)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* chore(linear lighting): UI settings changes (community-shaders#1785)

Co-authored-by: Jiaye <l936249247@hotmail.com>

* fix(grass-lighting) better basic grass brightness default (community-shaders#1780)

* chore(UI): remove settings and about tabs (community-shaders#1794)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(terrain shadows): fix compiler warnings (community-shaders#1798)

* fix: fix flickering particles (community-shaders#1791)

* fix(terrain blending): disable vr support (community-shaders#1799)

* refactor(upscaling): standardize behavior and tune settings (community-shaders#1783)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(UI): add auto-hide featurelist option (community-shaders#1793)

* fix: match grass brightness of vanilla (community-shaders#1801)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor(perfoverlay): remove color from "Other" and "Total" (community-shaders#1806)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(unified water): fix for mesh water jitter (community-shaders#1809)

* fix: clear shader cache on plugin version change (community-shaders#1739)

* feat(filewatcher): add hlsli tracking (community-shaders#1796)

* feat(linear lighting): add ambient multiplier (community-shaders#1805)

* fix(unified-water): underwater fog flicker (community-shaders#1807)

* fix(UI): conflicting esc key on welcome hotkey dialogue (community-shaders#1811)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(UI): add subtext font to tooltips (community-shaders#1810)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build: bump streamline to 2.10.3 (community-shaders#1813)

* build: resolve shader warnings (community-shaders#1818)

* feat(ui): add combo hotkey support (community-shaders#1808)

* feat: add feature constraints (community-shaders#1804)

* build: update version to 1.4.8 (community-shaders#1802)

* fix(VR): apply per eye upscaling (community-shaders#1819)

- Split upscaling across each eye for correctness and to avoid DLSS failing over 8k x 8k limit
- Changes HMD mask color to black to hide artifacts with fast movement

* build: bump common lib to 4.2.0 (community-shaders#1821)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* fix(grass collision): catch trashed actor pointers (community-shaders#1765)

* fix(weather editor): desynced override transitions (community-shaders#1820)

* fix(upscaling): fix preset and allocation handling (community-shaders#1824)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* build: remove linear lighting from core whilst in development (community-shaders#1826)

* chore: bump version to 1.4.9 (community-shaders#1827)

* fix: add back LLF core file and remove LL core file (community-shaders#1828)

* fix: dont save shader debug toggles (community-shaders#1831)

* fix: remove IBL from core, unfinished (community-shaders#1830)

* chore: update version to 1.4.10 (community-shaders#1832)

* chore(dynamic cubemaps): lessen normalisation darkening (community-shaders#1833)

* chore(llf): remove LightsVisualisationMode settings loading (community-shaders#1834)

* revert: "fix: dont save shader debug toggles (community-shaders#1831)"

This reverts commit f55f195.

* revert: "chore(llf): remove LightsVisualisationMode settings loading (community-shaders#1834)"

This reverts commit b3db5a7.

* fix: default enabledClasses true

* build: bump version

* feat(upscaling): custom DLSS preset (community-shaders#1837)

* fix(weather editor): sync UI for full transition (community-shaders#1822)

* fix(linearlighting): return correct buffer when ll feature off (community-shaders#1838)

* fix(PBR): skip IrradianceToLinear on specular in vanilla (community-shaders#1839)

* feat(weather editor): adjust slider ranges (community-shaders#1847)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather editor): replace volumetric Lighting RGB sliders with color picker (community-shaders#1846)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* fix(grass collision): collision radius math  (community-shaders#1849)

* chore: move new feature information into docs (community-shaders#1848)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* fix(ui): background blur with upscaling (community-shaders#1815)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor: move some features to core (community-shaders#1852)

* fix: fix blown out water specular (community-shaders#1853)

* feat(weather editor): toggle hotkey (community-shaders#1856)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(color picker): add an original color reference to all color pickers (community-shaders#1857)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* perf(emat): alternate tweaks (community-shaders#1850)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather-editor): merge weather picker and editor (community-shaders#1845)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(llf): remove LLF settings loading (community-shaders#1859)

* feat: exponential height fog (community-shaders#1708)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): block editor access in loading screens (community-shaders#1871)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather editor): improve weather picker UI and functionality (community-shaders#1863)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): repurpose unsaved changes tracking (community-shaders#1860)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: sync grass lighting defaults to match ENB (community-shaders#1844)

* fix: stop shader compilation on game exit (community-shaders#1867)

closes community-shaders#1130

* fix(weather editor): prevent inputs when editor is open (community-shaders#1872)

* fix(weather editor): add ctd guards (community-shaders#1864)

* feat(weather editor): remove WorldSpace widget and associated code (community-shaders#1878)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(vr): add OpenComposite menu support (community-shaders#1880)

* revert: "feat(vr): add OpenComposite VR menu" (community-shaders#1881)

* revert: "fix: stop shader compilation on game exit" (community-shaders#1882)

* feat(vr): add OpenComposite menu support (community-shaders#1883)

* feat(weather editor): add time controls (community-shaders#1877)

* feat: add shadowmap rasterizer override (community-shaders#1690)

* fix(weather editor): clear feature overrides with revert (community-shaders#1884)

* feat(UI): Interior Only (community-shaders#1854)

* fix(VR): fix Shadowmap Cascade Rasterizer (community-shaders#1888)

* fix(unified water): distance calculation for raindrops & LOD fade (community-shaders#1890)

* refactor: clarify core feature version mismatch text (community-shaders#1886)

* fix: stop shader compilation on game exit (community-shaders#1885)

* build: exclude hlsl tests from packaging (community-shaders#1894)

* chore: disable feature constraints in dev mode (community-shaders#1893)

* fix(vr): improve stereo UV handling (community-shaders#1899)

* fix(weather editor): move esc key to native input system (community-shaders#1897)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* fix: move ResolveMonoUVForEye outside VR guard (community-shaders#1906)

* fix(grass collision): validate actor  (community-shaders#1905)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* fix(terrain shadows): height map regression (community-shaders#1911)

* fix: util vertical fov math (community-shaders#1904)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* test: add float4 overload test (community-shaders#1902)

* refactor: move all features to globals::game::calendar (community-shaders#1909)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix(UI): resolution based font (community-shaders#1907)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): make objects window be independently scrollable (community-shaders#1908)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(UI): consolidate searchbar to util and add to weather editor (community-shaders#1898)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): add filled star for favourites. (community-shaders#1913)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather editor): add delete json button to objects window (community-shaders#1914)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(VR): resolution-based font (community-shaders#1923)

* refactor: use depthbuffer helper (community-shaders#1925)

* refactor: move TurboColormap into Color.hlsli (community-shaders#1924)

* fix(weather editor): expand clickable area of feature override (community-shaders#1921)

* feat(weather editor): enable snapping to viewport (community-shaders#1917)

* feat(weather editor): highlight enabled cloud layers (community-shaders#1916)

* fix(VR): SSGI discrepancies (community-shaders#1926)

* feat: volumetric shadows (community-shaders#1874)

* ci: enhance feature version audit (community-shaders#1927)

* feat(weather editor): add filter options for objects window (community-shaders#1922)

* feat(weather editor): sticky headers and scrollable content (community-shaders#1930)

* fix(UI): ImGui scaling for borderless mode (community-shaders#1929)

* ci: don't fail on feature audits (community-shaders#1934)

* fix(pbr): use scrap heap allocation (community-shaders#1928)

* chore(UI): add subsurface scattering to Interior Only (community-shaders#1932)

* fix(weather editor): align highlights, fix tooltip (community-shaders#1918)

* fix(ssgi): guard VR only compilation (community-shaders#1938)

* build: update template to avoid extra directory (community-shaders#1812)

* style: fix hlsl formatting (community-shaders#1939)

* fix(UI): improve theme management UI flow (community-shaders#1933)

closes community-shaders#1919

* build(deps): update pre-commit hooks (community-shaders#1768)

* feat(UI): delete theme button (community-shaders#1940)

* feat(UI): open log file button (community-shaders#1942)

* fix(hair): marschner volumetric shadow tint (community-shaders#1944)

* fix(VR): screen space shadows desync (community-shaders#1946)

closes community-shaders#1840

* fix(VR): depth culling during upscaling/Terrain Blending (community-shaders#1858)

* feat(VR): add edge detection for stereo blending (community-shaders#1948)

* refactor: allocate trampoline once (community-shaders#1951)

* fix(UI): PBR MATO color scale RGB settings corrected (community-shaders#1957)

* fix(weather editor): guard against loadorder changes (community-shaders#1953)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: davo0411 <davidkehoe0411@outlook.com>

* fix(UI): feature description text wrapping (community-shaders#1960)

* fix(VR): exponential height fog stereo mismatch (community-shaders#1961)

* chore: pbr consistency changes (community-shaders#1841)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: jiayev <l936249247@hotmail.com>

* fix(skylighting): remove PBR lighting scale (community-shaders#1963)

* fix(skysync): effect mesh blackout during shadow caster transitions (community-shaders#1965)

* ci: fix wiki deletion with buffer update (community-shaders#1967)

* feat(weather-editor): option to hide viewport (community-shaders#1970)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* test(shader): fallback to warp on invalidarg (community-shaders#1956)

Co-authored-by: LukeFrankio <loren@example.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: triplanar projected materials (community-shaders#1950)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(ao): better ao calculations (community-shaders#1968)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(pbr): fix improper kD terms (community-shaders#1971)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* perf(emat): tweak fade and shadow intensity (community-shaders#1892)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(ibl): revamp ibl and dalc sh (community-shaders#1947)

* build: bump commonlib to 4.7.1 (community-shaders#1977)

* fix: upscaling monitor detection fixes (community-shaders#1978)

* fix(weather editor): prevent overrides resetting settings (community-shaders#1980)

* fix(VR): bad llf offset (community-shaders#1984)

* perf: cache frequent ui checks (community-shaders#1985)

* fix: preserve vanilla water TAA when no upscaler is active (community-shaders#1986)

Co-authored-by: jturnley <jturnley@users.noreply.github.com>

* fix(UI): first-time dialog fade affects all overlays (community-shaders#1976)

* fix(skysync): remove sunlight fade and volumetric lighting overrides (community-shaders#1966)

* refactor(HLSL): standardize epsilon constants (community-shaders#1992)

closes community-shaders#1227

* feat(UI): require Shift to dock windows (community-shaders#1989)

* fix(UI): input spam after alt-tab (community-shaders#1993)

* fix(sky sync): early return for invalid cells (community-shaders#1991)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: jiayev <l936249247@hotmail.com>

* fix(sky sync): remove undeclared variable (community-shaders#1994)

* refactor(pbr): clear up semantics (community-shaders#1995)

* fix(UI): scale layout values for high-DPI (community-shaders#1987)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(water): hdr water taa blend (community-shaders#1988)

* refactor(color): clarify gamma conversion functions (community-shaders#1996)

* feat(ISL-editor): add light counters and fix filtering (community-shaders#1997)

* fix(UI): DPI-aware window layouts (community-shaders#2000)

* fix(weather-editor): save color palette window (community-shaders#2001)

* refactor: centralize feature category names (community-shaders#2007)

closes community-shaders#1265

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

* chore: bump versions (community-shaders#2010)

* fix(water): sample history mask from current mask (community-shaders#2011)

* chore(wetness-effects): set default MaxPuddleWetness to 1.5 (community-shaders#1981)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather-editor): add free camera and play mode (community-shaders#2008)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build: bump versions and reduce false positives (community-shaders#2013)

* fix(VR): LLF cluster building and culling (community-shaders#2012)

* build: update to VS 2026 (community-shaders#1990)

* ci: fix preset in vs2022 mode (community-shaders#2015)

* ci: remove v2022 from shader jobs (community-shaders#2016)

* feat(upscaling): integrate Streamline Reflex controls (community-shaders#1958)

* fix(unified-water): BSWaterShaderProperty.plane (community-shaders#1998)

---------

Co-authored-by: Skrubby Skrub In A Shrub <87662196+SkrubbySkrubInAShrub@users.noreply.github.com>
Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>
Co-authored-by: jiayev <l936249247@hotmail.com>
Co-authored-by: Dlizzio <77717521+Dlizzio@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alan Tse <alandtse@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Bruce <44987693+brucenguyen@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Dawntic <197450198+Dawntic@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Alan Tse <alandtse@gmail.com>
Co-authored-by: Vanni Giachin <vanni.giachin@qlik.com>
Co-authored-by: zxcvbn <66063766+zndxcvbn@users.noreply.github.com>
Co-authored-by: ParticleTroned <248299730+ParticleTroned@users.noreply.github.com>
Co-authored-by: soda <130315225+soda3000@users.noreply.github.com>
Co-authored-by: YtzyFvra <59631290+YtzyFvra@users.noreply.github.com>
Co-authored-by: LukeFrankio <lorenzogrutzmann@gmail.com>
Co-authored-by: LukeFrankio <loren@example.com>
Co-authored-by: jturnley <32892261+jturnley@users.noreply.github.com>
Co-authored-by: jturnley <jturnley@users.noreply.github.com>
Co-authored-by: Igor Alan Albuquerque de Sousa <50077829+IgorAlanAlbuquerque@users.noreply.github.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
davo0411 added a commit to davo0411/skyrim-community-shaders that referenced this pull request Mar 29, 2026
* fix(weather overrides): ensure json format for features (community-shaders#1748)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* perf(terrain blending): tweak defaults (community-shaders#1771)

* fix(lighting): vanilla envcolor mult the correct value (community-shaders#1775)

* fix(water): remove final colour saturate (community-shaders#1778)

* fix(unified-water): LOD water cache mismatch (community-shaders#1779)

* fix(weather editor): override desync with weather transitions (community-shaders#1782)

* fix(weather editor): no-override weather file deletion (community-shaders#1777)

* fix(weather editor): apply weather settings post-load (community-shaders#1776)

* fix(weather editor): handling of weathers without overrides (community-shaders#1773)

* feat(UI): feature headings (community-shaders#1786)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(VR): add wand pointing (community-shaders#1790)

* chore(UI): theme consistency (community-shaders#1787)

* fix(upscaling): warn about max nvidia resolution (community-shaders#1795)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* chore(linear lighting): UI settings changes (community-shaders#1785)

Co-authored-by: Jiaye <l936249247@hotmail.com>

* fix(grass-lighting) better basic grass brightness default (community-shaders#1780)

* chore(UI): remove settings and about tabs (community-shaders#1794)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(terrain shadows): fix compiler warnings (community-shaders#1798)

* fix: fix flickering particles (community-shaders#1791)

* fix(terrain blending): disable vr support (community-shaders#1799)

* refactor(upscaling): standardize behavior and tune settings (community-shaders#1783)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(UI): add auto-hide featurelist option (community-shaders#1793)

* fix: match grass brightness of vanilla (community-shaders#1801)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor(perfoverlay): remove color from "Other" and "Total" (community-shaders#1806)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(unified water): fix for mesh water jitter (community-shaders#1809)

* fix: clear shader cache on plugin version change (community-shaders#1739)

* feat(filewatcher): add hlsli tracking (community-shaders#1796)

* feat(linear lighting): add ambient multiplier (community-shaders#1805)

* fix(unified-water): underwater fog flicker (community-shaders#1807)

* fix(UI): conflicting esc key on welcome hotkey dialogue (community-shaders#1811)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(UI): add subtext font to tooltips (community-shaders#1810)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build: bump streamline to 2.10.3 (community-shaders#1813)

* build: resolve shader warnings (community-shaders#1818)

* feat(ui): add combo hotkey support (community-shaders#1808)

* feat: add feature constraints (community-shaders#1804)

* build: update version to 1.4.8 (community-shaders#1802)

* fix(VR): apply per eye upscaling (community-shaders#1819)

- Split upscaling across each eye for correctness and to avoid DLSS failing over 8k x 8k limit
- Changes HMD mask color to black to hide artifacts with fast movement

* build: bump common lib to 4.2.0 (community-shaders#1821)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* fix(grass collision): catch trashed actor pointers (community-shaders#1765)

* fix(weather editor): desynced override transitions (community-shaders#1820)

* fix(upscaling): fix preset and allocation handling (community-shaders#1824)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* build: remove linear lighting from core whilst in development (community-shaders#1826)

* chore: bump version to 1.4.9 (community-shaders#1827)

* fix: add back LLF core file and remove LL core file (community-shaders#1828)

* fix: dont save shader debug toggles (community-shaders#1831)

* fix: remove IBL from core, unfinished (community-shaders#1830)

* chore: update version to 1.4.10 (community-shaders#1832)

* chore(dynamic cubemaps): lessen normalisation darkening (community-shaders#1833)

* chore(llf): remove LightsVisualisationMode settings loading (community-shaders#1834)

* revert: "fix: dont save shader debug toggles (community-shaders#1831)"

This reverts commit f55f195.

* revert: "chore(llf): remove LightsVisualisationMode settings loading (community-shaders#1834)"

This reverts commit b3db5a7.

* fix: default enabledClasses true

* build: bump version

* feat(upscaling): custom DLSS preset (community-shaders#1837)

* fix(weather editor): sync UI for full transition (community-shaders#1822)

* fix(linearlighting): return correct buffer when ll feature off (community-shaders#1838)

* fix(PBR): skip IrradianceToLinear on specular in vanilla (community-shaders#1839)

* feat(weather editor): adjust slider ranges (community-shaders#1847)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather editor): replace volumetric Lighting RGB sliders with color picker (community-shaders#1846)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* fix(grass collision): collision radius math  (community-shaders#1849)

* chore: move new feature information into docs (community-shaders#1848)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* fix(ui): background blur with upscaling (community-shaders#1815)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor: move some features to core (community-shaders#1852)

* fix: fix blown out water specular (community-shaders#1853)

* feat(weather editor): toggle hotkey (community-shaders#1856)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(color picker): add an original color reference to all color pickers (community-shaders#1857)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* perf(emat): alternate tweaks (community-shaders#1850)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather-editor): merge weather picker and editor (community-shaders#1845)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(llf): remove LLF settings loading (community-shaders#1859)

* feat: exponential height fog (community-shaders#1708)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): block editor access in loading screens (community-shaders#1871)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather editor): improve weather picker UI and functionality (community-shaders#1863)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): repurpose unsaved changes tracking (community-shaders#1860)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: sync grass lighting defaults to match ENB (community-shaders#1844)

* fix: stop shader compilation on game exit (community-shaders#1867)

closes community-shaders#1130

* fix(weather editor): prevent inputs when editor is open (community-shaders#1872)

* fix(weather editor): add ctd guards (community-shaders#1864)

* feat(weather editor): remove WorldSpace widget and associated code (community-shaders#1878)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(vr): add OpenComposite menu support (community-shaders#1880)

* revert: "feat(vr): add OpenComposite VR menu" (community-shaders#1881)

* revert: "fix: stop shader compilation on game exit" (community-shaders#1882)

* feat(vr): add OpenComposite menu support (community-shaders#1883)

* feat(weather editor): add time controls (community-shaders#1877)

* feat: add shadowmap rasterizer override (community-shaders#1690)

* fix(weather editor): clear feature overrides with revert (community-shaders#1884)

* feat(UI): Interior Only (community-shaders#1854)

* fix(VR): fix Shadowmap Cascade Rasterizer (community-shaders#1888)

* fix(unified water): distance calculation for raindrops & LOD fade (community-shaders#1890)

* refactor: clarify core feature version mismatch text (community-shaders#1886)

* fix: stop shader compilation on game exit (community-shaders#1885)

* build: exclude hlsl tests from packaging (community-shaders#1894)

* chore: disable feature constraints in dev mode (community-shaders#1893)

* fix(vr): improve stereo UV handling (community-shaders#1899)

* fix(weather editor): move esc key to native input system (community-shaders#1897)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* fix: move ResolveMonoUVForEye outside VR guard (community-shaders#1906)

* fix(grass collision): validate actor  (community-shaders#1905)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* fix(terrain shadows): height map regression (community-shaders#1911)

* fix: util vertical fov math (community-shaders#1904)

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>

* test: add float4 overload test (community-shaders#1902)

* refactor: move all features to globals::game::calendar (community-shaders#1909)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix(UI): resolution based font (community-shaders#1907)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): make objects window be independently scrollable (community-shaders#1908)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(UI): consolidate searchbar to util and add to weather editor (community-shaders#1898)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(weather editor): add filled star for favourites. (community-shaders#1913)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather editor): add delete json button to objects window (community-shaders#1914)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(VR): resolution-based font (community-shaders#1923)

* refactor: use depthbuffer helper (community-shaders#1925)

* refactor: move TurboColormap into Color.hlsli (community-shaders#1924)

* fix(weather editor): expand clickable area of feature override (community-shaders#1921)

* feat(weather editor): enable snapping to viewport (community-shaders#1917)

* feat(weather editor): highlight enabled cloud layers (community-shaders#1916)

* fix(VR): SSGI discrepancies (community-shaders#1926)

* feat: volumetric shadows (community-shaders#1874)

* ci: enhance feature version audit (community-shaders#1927)

* feat(weather editor): add filter options for objects window (community-shaders#1922)

* feat(weather editor): sticky headers and scrollable content (community-shaders#1930)

* fix(UI): ImGui scaling for borderless mode (community-shaders#1929)

* ci: don't fail on feature audits (community-shaders#1934)

* fix(pbr): use scrap heap allocation (community-shaders#1928)

* chore(UI): add subsurface scattering to Interior Only (community-shaders#1932)

* fix(weather editor): align highlights, fix tooltip (community-shaders#1918)

* fix(ssgi): guard VR only compilation (community-shaders#1938)

* build: update template to avoid extra directory (community-shaders#1812)

* style: fix hlsl formatting (community-shaders#1939)

* fix(UI): improve theme management UI flow (community-shaders#1933)

closes community-shaders#1919

* build(deps): update pre-commit hooks (community-shaders#1768)

* feat(UI): delete theme button (community-shaders#1940)

* feat(UI): open log file button (community-shaders#1942)

* fix(hair): marschner volumetric shadow tint (community-shaders#1944)

* fix(VR): screen space shadows desync (community-shaders#1946)

closes community-shaders#1840

* fix(VR): depth culling during upscaling/Terrain Blending (community-shaders#1858)

* feat(VR): add edge detection for stereo blending (community-shaders#1948)

* refactor: allocate trampoline once (community-shaders#1951)

* fix(UI): PBR MATO color scale RGB settings corrected (community-shaders#1957)

* fix(weather editor): guard against loadorder changes (community-shaders#1953)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: davo0411 <davidkehoe0411@outlook.com>

* fix(UI): feature description text wrapping (community-shaders#1960)

* fix(VR): exponential height fog stereo mismatch (community-shaders#1961)

* chore: pbr consistency changes (community-shaders#1841)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: jiayev <l936249247@hotmail.com>

* fix(skylighting): remove PBR lighting scale (community-shaders#1963)

* fix(skysync): effect mesh blackout during shadow caster transitions (community-shaders#1965)

* ci: fix wiki deletion with buffer update (community-shaders#1967)

* feat(weather-editor): option to hide viewport (community-shaders#1970)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* test(shader): fallback to warp on invalidarg (community-shaders#1956)

Co-authored-by: LukeFrankio <loren@example.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: triplanar projected materials (community-shaders#1950)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(ao): better ao calculations (community-shaders#1968)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(pbr): fix improper kD terms (community-shaders#1971)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* perf(emat): tweak fade and shadow intensity (community-shaders#1892)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(ibl): revamp ibl and dalc sh (community-shaders#1947)

* build: bump commonlib to 4.7.1 (community-shaders#1977)

* fix: upscaling monitor detection fixes (community-shaders#1978)

* fix(weather editor): prevent overrides resetting settings (community-shaders#1980)

* fix(VR): bad llf offset (community-shaders#1984)

* perf: cache frequent ui checks (community-shaders#1985)

* fix: preserve vanilla water TAA when no upscaler is active (community-shaders#1986)

Co-authored-by: jturnley <jturnley@users.noreply.github.com>

* fix(UI): first-time dialog fade affects all overlays (community-shaders#1976)

* fix(skysync): remove sunlight fade and volumetric lighting overrides (community-shaders#1966)

* refactor(HLSL): standardize epsilon constants (community-shaders#1992)

closes community-shaders#1227

* feat(UI): require Shift to dock windows (community-shaders#1989)

* fix(UI): input spam after alt-tab (community-shaders#1993)

* fix(sky sync): early return for invalid cells (community-shaders#1991)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: jiayev <l936249247@hotmail.com>

* fix(sky sync): remove undeclared variable (community-shaders#1994)

* refactor(pbr): clear up semantics (community-shaders#1995)

* fix(UI): scale layout values for high-DPI (community-shaders#1987)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(water): hdr water taa blend (community-shaders#1988)

* refactor(color): clarify gamma conversion functions (community-shaders#1996)

* feat(ISL-editor): add light counters and fix filtering (community-shaders#1997)

* fix(UI): DPI-aware window layouts (community-shaders#2000)

* fix(weather-editor): save color palette window (community-shaders#2001)

* refactor: centralize feature category names (community-shaders#2007)

closes community-shaders#1265

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

* chore: bump versions (community-shaders#2010)

* fix(water): sample history mask from current mask (community-shaders#2011)

* chore(wetness-effects): set default MaxPuddleWetness to 1.5 (community-shaders#1981)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>

* feat(weather-editor): add free camera and play mode (community-shaders#2008)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build: bump versions and reduce false positives (community-shaders#2013)

* fix(VR): LLF cluster building and culling (community-shaders#2012)

* build: update to VS 2026 (community-shaders#1990)

* ci: fix preset in vs2022 mode (community-shaders#2015)

* ci: remove v2022 from shader jobs (community-shaders#2016)

* feat(upscaling): integrate Streamline Reflex controls (community-shaders#1958)

* fix(unified-water): BSWaterShaderProperty.plane (community-shaders#1998)

---------

Co-authored-by: Skrubby Skrub In A Shrub <87662196+SkrubbySkrubInAShrub@users.noreply.github.com>
Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>
Co-authored-by: jiayev <l936249247@hotmail.com>
Co-authored-by: Dlizzio <77717521+Dlizzio@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alan Tse <alandtse@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Bruce <44987693+brucenguyen@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Dawntic <197450198+Dawntic@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Alan Tse <alandtse@gmail.com>
Co-authored-by: Vanni Giachin <vanni.giachin@qlik.com>
Co-authored-by: zxcvbn <66063766+zndxcvbn@users.noreply.github.com>
Co-authored-by: ParticleTroned <248299730+ParticleTroned@users.noreply.github.com>
Co-authored-by: soda <130315225+soda3000@users.noreply.github.com>
Co-authored-by: YtzyFvra <59631290+YtzyFvra@users.noreply.github.com>
Co-authored-by: LukeFrankio <lorenzogrutzmann@gmail.com>
Co-authored-by: LukeFrankio <loren@example.com>
Co-authored-by: jturnley <32892261+jturnley@users.noreply.github.com>
Co-authored-by: jturnley <jturnley@users.noreply.github.com>
Co-authored-by: Igor Alan Albuquerque de Sousa <50077829+IgorAlanAlbuquerque@users.noreply.github.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
ParticleTroned pushed a commit to ParticleTroned/skyrim-community-shaders that referenced this pull request May 2, 2026
…nity-shaders#1914)

Co-authored-by: SkrubbySkrubInAShrub <skrubbyskrubinashrub@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 0828631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants