feat(weather-editor): option to hide viewport

[SkrubbySkrubInAShrub]

Added a toggle to allow the user to hide the viewport, This will come in useful for when HDR is merged and it has been requested by multiple people.

Also changed for for the purpose of usability with this feature:

• Changed the options from buttons to checkboxes to prevent the dropdown menu from closing when clicking them.
• Moved the time slider to the header bar so that it is always available independently from the the viewport.

Fixed:

• Background turned black when viewport was opened, must have snuck in earlier

Summary by CodeRabbit

• New Features

  • Toggle to show/hide the viewport to reduce visual clutter and rendering work
  • Time slider added to the menu bar for quick time adjustments

• Improvements

  • Window focus behavior refined for smoother workflow
  • UI now dims background when the viewport is active for clearer context
  • Safer viewport handling: missing textures show a disabled message and resources are created/deleted as needed

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2c503a0f-bee0-4887-ada3-a128d94805aa

📥 Commits

Reviewing files that changed from the base of the PR and between fdb3228 and eade25d.

📒 Files selected for processing (1)

• src/WeatherEditor/EditorWindow.cpp

---

📝 Walkthrough

Walkthrough

Added a new Settings flag showViewport, wired it into EditorWindow rendering and menu (viewport checkbox); viewport creation/use now respects this flag and uses NoFocusOnAppearing; moved alpha handling to background-dimming; added a right-anchored time-of-day slider in the menu bar.

Changes

Cohort / File(s)	Summary
EditorWindow: header + implementation src/WeatherEditor/EditorWindow.h, src/WeatherEditor/EditorWindow.cpp	Added static constexpr float kMenuBarSliderWidth = 400.0f and bool showViewport = true to EditorWindow::Settings; viewport begin uses ImGuiWindowFlags_NoFocusOnAppearing; viewport creation/rendering gated by showViewport; removed global UI alpha push in favor of dimming game scene; added right-anchored time slider and menu checkbox that saves on change; texture create/delete now conditional on showViewport.
Palette window focus behavior src/WeatherEditor/PaletteWindow.cpp	Added ImGuiWindowFlags_NoFocusOnAppearing to Palette window creation to avoid stealing focus on appearance.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat(weather editor): enable snapping to viewport #1917: Modifies EditorWindow viewport/docking and window-flag handling similar to the viewport flag changes here.
• feat(weather editor): toggle hotkey #1856: Affects EditorWindow visibility/toggling; related to the new showViewport visibility control.

Suggested reviewers

• alandtse
• davo0411

Poem

🐰
I hid a viewport behind a flag so neat,
A slider hums as day and night compete,
Windows open gently, no focus to greet,
Textures wake when toggled — what a treat,
Carrot cheers from my burrowed seat 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately summarizes the main feature: adding an option to hide the viewport. This is clearly the primary change across the modified files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan for PR comments

• Generate coding plan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/WeatherEditor/EditorWindow.cpp`:
- Around line 1181-1195: The period label can overlap the close button because
its width isn't reserved when anchoring the slider; compute the period text
using TOD::GetPeriodName(TOD::GetActivePeriod()) and measure it with
ImGui::CalcTextSize (or CalcTextSizeUtf8) to get periodWidth, then include
periodWidth + itemSpacing in the SameLine anchor calculation that uses
ImGui::GetWindowWidth() - closeButtonSize - 10.0f - itemSpacing -
kMenuBarSliderWidth so the slider leaves room for the period text; update the
block around DrawGameHourSlider, the ImGui::SameLine positioning, and any
subsequent ImGui::SameLine()/ImGui::Text calls to use the measured width.
- Line 13: The JSON mapping for EditorWindow::Settings omitted the palette
fields, so serialized settings drop paletteFavorites, paletteColors, and
paletteValues; update the NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT
invocation for EditorWindow::Settings to include paletteFavorites,
paletteColors, and paletteValues (using the exact member names as declared in
the Settings struct) so j = settings and j.get_to(settings) will preserve the
palette data.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0cf3b11-5b36-4dd5-94ca-9df7d49664b4

📥 Commits

Reviewing files that changed from the base of the PR and between e57f5cd and f1365fe.

📒 Files selected for processing (3)

• src/WeatherEditor/EditorWindow.cpp
• src/WeatherEditor/EditorWindow.h
• src/WeatherEditor/PaletteWindow.cpp

[github-actions]

✅ A pre-release build is available for this PR:
Download

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/WeatherEditor/EditorWindow.cpp`:
- Around line 1235-1238: The viewport UI toggle currently only hides the ImGui
window (ShowViewportWindow()) but still allocates/fetches the framebuffer and
performs the DX11 CopyResource into tempTexture every frame; update the code
that allocates/updates tempTexture and performs the CopyResource (the
framebuffer fetch / CopyResource path around tempTexture) to be gated by
settings.showViewport so it early-returns when the viewport is hidden, and
implement lazy re-initialization of the framebuffer/tempTexture resources when
settings.showViewport transitions true again (validate resources before use and
recreate if null/invalid). Ensure resource cleanup when hiding (release or mark
unused) and guard any input/render interactions tied to the viewport so they
no-op when settings.showViewport is false.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 84f31165-7dc1-4fdd-b720-2ec2019890ec

📥 Commits

Reviewing files that changed from the base of the PR and between f1365fe and fdb3228.

📒 Files selected for processing (2)

• src/WeatherEditor/EditorWindow.cpp
• src/WeatherEditor/EditorWindow.h