ci: don't fail on feature audits

[alandtse]

Summary by CodeRabbit

• Chores
  • Enhanced build workflow error handling to ensure downstream processes continue running despite upstream failures.

[coderabbitai]

📝 Walkthrough

Walkthrough

A single line was added to the GitHub Actions workflow configuration to enable the feature-audit-pr job to continue execution when errors occur, allowing downstream steps to complete regardless of failures in that job.

Changes

Cohort / File(s)	Summary
GitHub Actions Configuration .github/workflows/build.yaml	Added continue-on-error: true to the feature-audit-pr job, enabling workflow continuation despite job failures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

• doodlum

Poem

🐰 When errors hop along the way,
Don't let the pipeline fall and sway,
With "continue" in our hearts so true,
Our workflows complete their journey through! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ci: don't fail on feature audits' directly and accurately describes the main change: adding continue-on-error to prevent the feature-audit-pr job from failing the workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 actionlint (1.7.11)

.github/workflows/build.yaml

could not read ".github/workflows/build.yaml": open .github/workflows/build.yaml: no such file or directory

🔧 YAMLlint (1.38.0)

.github/workflows/build.yaml

[Errno 2] No such file or directory: '.github/workflows/build.yaml'

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

🧹 Nitpick comments (1)

.github/workflows/build.yaml (1)

463-467: continue-on-error: true at job level makes needs.feature-audit-pr.result == 'failure' unreachable downstream

When continue-on-error: true is applied at the job level, needs.<job_id>.result reports success even if the job actually fails. This means the explicit || needs.feature-audit-pr.result == 'failure' branch in feature-audit-pr-comment's if condition (line 499) is dead code. The downstream job still runs correctly via the success branch, but the code no longer reflects the original intent to handle both success and failure states.

Consider simplifying the condition to clarify actual behavior:

✂️ Simplify dead branch in `feature-audit-pr-comment`

-        if: always() && github.event_name == 'pull_request_target' && (needs.feature-audit-pr.result == 'success' || needs.feature-audit-pr.result == 'failure')
+        if: always() && github.event_name == 'pull_request_target' && needs.feature-audit-pr.result != 'skipped'

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build.yaml around lines 463 - 467, The feature-audit-pr
job sets continue-on-error: true which causes needs.feature-audit-pr.result to
always report success, so the || needs.feature-audit-pr.result == 'failure'
branch in the downstream feature-audit-pr-comment job is dead code; either
remove continue-on-error: true from the feature-audit-pr job to preserve real
failure semantics, or if you intentionally want to ignore failures keep
continue-on-error and simplify the feature-audit-pr-comment job's if condition
by removing the `|| needs.feature-audit-pr.result == 'failure'` clause (adjust
references to feature-audit-pr and feature-audit-pr-comment accordingly).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/build.yaml:
- Around line 463-467: The feature-audit-pr job sets continue-on-error: true
which causes needs.feature-audit-pr.result to always report success, so the ||
needs.feature-audit-pr.result == 'failure' branch in the downstream
feature-audit-pr-comment job is dead code; either remove continue-on-error: true
from the feature-audit-pr job to preserve real failure semantics, or if you
intentionally want to ignore failures keep continue-on-error and simplify the
feature-audit-pr-comment job's if condition by removing the `||
needs.feature-audit-pr.result == 'failure'` clause (adjust references to
feature-audit-pr and feature-audit-pr-comment accordingly).

[github-actions]

✅ A pre-release build is available for this PR:
Download