fix(UI): conflicting esc key on welcome hotkey dialogue

[Dlizzio]

Fixes the conflicting toggles (esc) with the startup box toggle and the shader cache. Now when pressing esc to dismiss the startup box it will not force background compilation of shader cache.

Summary by CodeRabbit

• Bug Fixes
  • Improved keyboard input handling for the first-time setup dialog to prevent unintended hotkey triggers when closing the dialog. Key presses used to dismiss the dialog are now properly tracked to avoid activating other actions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes implement dialog-closing key tracking to prevent Enter/Escape key releases from triggering standard hotkey handling. When the first-time setup dialog closes, the closing key is stored and later skipped during keyboard input processing to avoid unintended hotkey capture.

Changes

Cohort / File(s)	Summary
First-time Setup Dialog State Management src/Menu/HomePageRenderer.h, src/Menu/HomePageRenderer.cpp	Added static member keyThatClosedDialog to track which key closed the dialog, updated MarkFirstTimeSetupComplete() signature to accept closingKey parameter, introduced ShouldSkipKeyRelease(uint32_t key) helper method, and modified Enter/Escape handling to explicitly track and pass the closing key.
Keyboard Event Processing src/Menu.cpp	Added short-circuit logic in ProcessInputEventQueue() to check ShouldSkipKeyRelease() for non-VR keyboard events; if true, emits key release to ImGui and skips further hotkey processing for that event.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• refactor: hotkey handling #1118: Both PRs modify hotkey processing in Menu::ProcessInputEventQueue to handle dialog-related input logic.
• fix(ui): enter key now behaves properly when first time popup is open #1615: Both PRs prevent Enter/Escape from being captured as hotkeys during first-time setup through different mechanisms (state-based skip vs. guard logic).
• chore: edit welcome dialogue behavior #1743: Both PRs modify first-time setup dialog input handling including Enter/Escape handling and keyboard processing in Menu.cpp.

Suggested reviewers

• doodlum
• alandtse
• davo0411

Poem

🐰 A dialog that closes with grace,
The key that it pressed, now we trace,
When fingers release what they held,
No hotkeys shall sound, we've compelled,
The input to flow with more space! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: preventing the Esc key press from conflicting between the welcome dialog and shader cache toggle hotkey.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: db0b2a5
Using base ref: db0b2a5
Base commit date: 2026-02-02T23:50:44-08:00 (Monday, February 02, 2026 11:50 PM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download