fix: stop shader compilation on game exit

[brucenguyen]

Re-attempt #1867.

Removed usage of RE::Main, I unfortunately only tested on 1.5 SE but it seems like it doesn't work properly on 1.6 AE.

Now tracking this internally with CS code.

Purpose

This PR aims to mitigate an issue where you close the game before hitting the main menu and the process keeps running until it would hit the main menu. This is non-CS behaviour. CS just exacerbates by blocking main menu load with shader compilation.

• Upon receiving WM_CLOSE message, stop remaining shader compilation tasks
• Skip feature DataLoaded functions if game is already closed, to skip things like Unified Water cache

Testing

• Some testing notes are in previous PR
• Skrubby tested a build with this source on 1.6 AE and reported no issues
• I tested the same build on 1.5 SE with no issues

Summary by CodeRabbit

• Bug Fixes

  • Closing the game now cleanly cancels background shader compilation to ensure shutdown completes reliably.
  • Prevents post-exit operations from continuing during shutdown, reducing hangs and redundant work.

• Improvements

  • Added informational logging when shutdown interrupts background compilation to aid diagnostics.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

Adds a global atomic quit flag and a window-close handler that sets it and requests shader compilation stop; hooks WM_CLOSE to call the handler; exposes ShaderCache::StopCompilation(); DataLoaded now aborts waiting for background compilation when the quit flag is set.

Changes

Cohort / File(s)	Summary
Global state & API src/Globals.h, src/Globals.cpp	Adds game::quitGame (std::atomic) and globals::OnGameWindowClose() which sets the flag and invokes shaderCache->StopCompilation() if available.
Window hook src/Hooks.cpp	Handles WM_CLOSE in WndProc to call globals::OnGameWindowClose().
Shader compilation control src/ShaderCache.h, src/ShaderCache.cpp	Adds ShaderCache::StopCompilation() to request stopping ongoing compilation, log remaining tasks, and clear compilation state.
Startup / Data load flow src/XSEPlugin.cpp	DataLoaded wait loop now also checks !globals::game::quitGame; logs and aborts remaining DataLoaded processing when quitting.

Sequence Diagram

sequenceDiagram
    participant WndProc as WndProc (hook)
    participant Globals as Globals
    participant ShaderCache as ShaderCache
    participant DataLoaded as DataLoaded

    WndProc->>Globals: OnGameWindowClose()
    Globals->>Globals: set game::quitGame = true
    Globals->>ShaderCache: StopCompilation()
    ShaderCache->>ShaderCache: log remaining, request stop, clear state

    DataLoaded->>DataLoaded: wait (IsCompiling && !backgroundCompilation && !quitGame)
    DataLoaded->>Globals: read quitGame
    Globals-->>DataLoaded: quitGame == true
    DataLoaded->>DataLoaded: break and skip remaining processing

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: stop shader compilation on game exit #1867: Implements similar quit-flag, WM_CLOSE wiring, and StopCompilation() behavior across the same code paths.
• revert: "fix: stop shader compilation on game exit" #1882: Reverts the shutdown/stop-compilation changes introduced in related PRs.

Suggested reviewers

• alandtse
• davo0411
• doodlum

Poem

🐰 When the window whispers close, I flag the end,
I hush the compilers and let their shaders mend.
Tasks fold up, the background dreams away,
A rabbit hops off softly at shutdown's sway. 🎮✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: stopping shader compilation when the game exits.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: c1fc0aa
Using base ref: c1fc0aa
Base commit date: 2026-02-16T18:25:50Z (Monday, February 16, 2026 06:25 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/Globals.h`:
- Line 222: Replace the non-atomic flag quitGame with an atomic type to avoid
data races: change the extern declaration of quitGame to use std::atomic_bool in
Globals.h (and add `#include` <atomic> if missing), and update the corresponding
definition in Globals.cpp to define and initialize a std::atomic_bool
quitGame{false}; so reads/writes from WndProc (OnGameWindowClose) and the SKSE
messaging thread (DataLoaded polling in XSEPlugin.cpp) are safe without
additional synchronization.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[davo0411]

tested and happy?
also fix conflicts ples

[brucenguyen]

i tested SE and skrub tested AE, but fwiw this code doesn't rely on an RE anymore, so yeah it should be pretty solid