fix(UI): resolution based font

[Dlizzio]

Fixes scaling of resolution based font and enables it by default.

1080p:

1440p:

4K:

Summary by CodeRabbit

• Bug Fixes
  • Fixed font sizing calculations across all UI themes to ensure consistent and properly-scaled text rendering
  • Recalibrated default font scaling metrics for improved display consistency

[github-actions]

Using provided base ref: 27eb9e9
Using base ref: 27eb9e9
Base commit date: 2026-02-18T09:49:12-08:00 (Wednesday, February 18, 2026 09:49 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[SkrubbySkrubInAShrub]

may want to do this for the spacing and UI borders too.

[Dlizzio]

may want to do this for the spacing and UI borders too.

Probably with another project. I don't think it would be easy.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes standardize font sizing across all Community Shaders theme files by resetting the FontSize property to 0.0 and adjusting the default font ratio calculation in ThemeManager from 0.025f to (7.0f / 360.0f), enabling dynamic, resolution-based font scaling.

Changes

Cohort / File(s)	Summary
Theme Configuration Files package/SKSE/Plugins/CommunityShaders/Themes/Default.json, DragonBlood.json, DwemerBronze.json, HighContrast.json, Light.json, NordicFrost.json	Updated Theme.FontSize from 27.0 to 0.0 across all theme files, transitioning from fixed font sizing to resolution-based scaling.
Font Sizing Constants src/Menu/ThemeManager.h	Updated DEFAULT_FONT_RATIO constant from 0.025f to (7.0f / 360.0f), recalibrating the default font size derivation from screen dimensions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat(ui): font size and perf overlay improvements #1511: Introduces ResolveFontSize method treating 0.0 as resolution-based default, aligning with this PR's theme FontSize reset strategy.
• fix: menu refactor bugs #1335: Modifies font sizing configuration in ThemeManager constants and theme values, directly related to this PR's approach.
• feat(ui): implement dynamic font scaling based on screen resolution #1233: Implements dynamic font scaling in Menu::Init, complementing the theme-level and constant-level changes here.

Suggested reviewers

• doodlum
• alandtse

Poem

🐰 Fonts now dance with screen resolution,
No more static, stiff confusion!
From 27 down to graceful 0,
Ratios calculated just so—
Crisp text at every viewport's glow! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(UI): resolution based font' accurately summarizes the main change—adjusting font sizing to be resolution-based and enabling it by default across all theme files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Menu/ThemeManager.h (1)

27-27: ⚠️ Potential issue | 🟡 Minor

Schema doc still shows 27.0 as the example FontSize, inconsistent with the new default

All theme files now use 0.0, but the header comment at line 27 still documents "FontSize": 27.0,. This is misleading for anyone writing a new theme. The comment should show 0.0 and call out the sentinel behavior.

✏️ Suggested doc update

-*     "FontSize": 27.0,                    // Base font size (16-108px range)
+*     "FontSize": 0.0,                     // Base font size (16-108px). Use 0.0 for resolution-based sizing (recommended)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Menu/ThemeManager.h` at line 27, Update the header comment in
ThemeManager.h that documents the theme schema: change the example `"FontSize":
27.0` to `"FontSize": 0.0` and add a short note that 0.0 is the sentinel meaning
"use default system/font-scaling" (or equivalent wording used by ThemeManager).
Target the schema comment referencing the "FontSize" key in ThemeManager.h so
theme authors see the new default and the sentinel behavior.

🧹 Nitpick comments (1)

src/Menu/ThemeManager.h (1)

148-151: Conventional commit scope casing nit

The PR title fix(UI): resolution based font uses an uppercase scope UI. Per the project's conventional commit guidelines, scopes should be lowercase (e.g., fix(ui): resolution based font). As per coding guidelines: Style: lowercase description and examples like fix(water) and feat(vr) consistently use lowercase scopes.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Menu/ThemeManager.h` around lines 148 - 151, The PR title uses an
uppercase scope `UI`; update the commit/PR title to use a lowercase scope `ui`
(e.g., change `fix(UI): resolution based font` to `fix(ui): resolution based
font`) and amend the latest commit message(s) accordingly (git commit --amend or
git rebase -i) so history follows the project's conventional-commit casing;
verify any related branch or changelog entries referencing the scope (e.g.,
files like src/Menu/ThemeManager.h or symbols
DEFAULT_FONT_RATIO/DEFAULT_FONT_SIZE) are updated to match the lowercase `ui`
scope as well.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/Menu/ThemeManager.h`:
- Around line 149-152: DEFAULT_FONT_SIZE in ThemeManager.h is inconsistent with
DEFAULT_FONT_RATIO and must be changed from 27.0f to 21.0f so fallback sizing
matches ResolveFontSize behavior; update the static constexpr float
DEFAULT_FONT_SIZE in the ThemeManager class to 21.0f to match 1080 * (7.0f /
360.0f), and ensure ResolveFontSize() in src/Menu/ThemeManager.cpp continues to
use DEFAULT_FONT_SIZE as the fallback when globals::state or screenSize.y are
invalid.

---

Outside diff comments:
In `@src/Menu/ThemeManager.h`:
- Line 27: Update the header comment in ThemeManager.h that documents the theme
schema: change the example `"FontSize": 27.0` to `"FontSize": 0.0` and add a
short note that 0.0 is the sentinel meaning "use default system/font-scaling"
(or equivalent wording used by ThemeManager). Target the schema comment
referencing the "FontSize" key in ThemeManager.h so theme authors see the new
default and the sentinel behavior.

---

Nitpick comments:
In `@src/Menu/ThemeManager.h`:
- Around line 148-151: The PR title uses an uppercase scope `UI`; update the
commit/PR title to use a lowercase scope `ui` (e.g., change `fix(UI): resolution
based font` to `fix(ui): resolution based font`) and amend the latest commit
message(s) accordingly (git commit --amend or git rebase -i) so history follows
the project's conventional-commit casing; verify any related branch or changelog
entries referencing the scope (e.g., files like src/Menu/ThemeManager.h or
symbols DEFAULT_FONT_RATIO/DEFAULT_FONT_SIZE) are updated to match the lowercase
`ui` scope as well.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/Menu/ThemeManager.h (2)

27-27: Stale schema doc — example still shows "FontSize": 27.0.

The doc comment at line 27 shows the old hardcoded value. Since all themes now use 0.0 to opt into the resolution-based default, the example should reflect the new convention.

📝 Suggested update

-*     "FontSize": 27.0,                    // Base font size (16-108px range)
+*     "FontSize": 0.0,                     // Base font size (16-108px range); 0.0 = auto (resolution-based)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Menu/ThemeManager.h` at line 27, Update the stale example in the
ThemeManager.h doc comment that shows a hardcoded FontSize of 27.0 to use the
new convention of 0.0 (resolution-based default); edit the comment near the
ThemeManager declaration or the JSON schema example so the example line reads
using "FontSize": 0.0 to reflect current behavior used by ThemeManager/Theme
parsing logic.

---

1-1: Conventional commit scope should be lowercase.

The PR title fix(UI): resolution based font uses an uppercase scope. Per the Conventional Commits spec and project coding guidelines, scopes should be lowercase:

fix(ui): resolution based font

Consider also adding an issue reference if this addresses a tracked bug, e.g. Fixes #<issue>. As per coding guidelines, issue references are suggested for bug fixes.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Menu/ThemeManager.h` at line 1, Update the PR title and any related
commit messages to use a lowercase conventional commit scope: change "fix(UI):
resolution based font" to "fix(ui): resolution based font" (and add "Fixes
#<issue>" if this addresses a tracked bug) so the scope follows the project's
Conventional Commits guideline; ensure any squash/merge commit or branch tip
commit message is updated accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/Menu/ThemeManager.h`:
- Around line 149-152: DEFAULT_FONT_SIZE is inconsistent with the ratio-based
value and should be derived from DEFAULT_FONT_RATIO and DEFAULT_SCREEN_HEIGHT to
match ThemeManager::ResolveFontSize() fallback; change DEFAULT_FONT_SIZE to be
constexpr and computed as DEFAULT_FONT_RATIO * DEFAULT_SCREEN_HEIGHT (resulting
in 21.0f) and adjust the inline comment to reflect the correct resolution-based
derivation so the fallback behavior matches the ratio calculation.

---

Nitpick comments:
In `@src/Menu/ThemeManager.h`:
- Line 27: Update the stale example in the ThemeManager.h doc comment that shows
a hardcoded FontSize of 27.0 to use the new convention of 0.0 (resolution-based
default); edit the comment near the ThemeManager declaration or the JSON schema
example so the example line reads using "FontSize": 0.0 to reflect current
behavior used by ThemeManager/Theme parsing logic.
- Line 1: Update the PR title and any related commit messages to use a lowercase
conventional commit scope: change "fix(UI): resolution based font" to "fix(ui):
resolution based font" (and add "Fixes #<issue>" if this addresses a tracked
bug) so the scope follows the project's Conventional Commits guideline; ensure
any squash/merge commit or branch tip commit message is updated accordingly.