fix(upscaling): warn about max nvidia resolution

[alandtse]

Summary by CodeRabbit

• New Features

  • Show warnings when using DLSS upscaling at very high resolutions (above 8192 pixels).

• Bug Fixes

  • Improved diagnostic logging when DLSS settings retrieval fails, making failures easier to identify and troubleshoot.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a Streamline::MAX_RESOLUTION constant (8192), uses it to show a DLSS resolution-limit warning in Upscaling::DrawSettings UI when screen dimensions exceed the limit, and adds a conditional warning plus more detailed error logging in Streamline::GetInputResolutionScale on DLSS retrieval failure.

Changes

Cohort / File(s)	Summary
Streamline constant src/Features/Upscaling/Streamline.h	Added static constexpr uint32_t MAX_RESOLUTION = 8192 to Streamline (public).
Upscaling UI src/Features/Upscaling.cpp	Checks current UpscaleMethod and screen size against MAX_RESOLUTION; displays temporary warning text color and two DLSS-limit messages in DrawSettings before existing DLSS presets.
Resolution scale & logging src/Features/Upscaling/Streamline.cpp	On DLSS optimal settings failure, logs a conditional warning if requested output exceeds MAX_RESOLUTION, and enhances error log to include enum name and numeric code; returns fallback scale unchanged.

Sequence Diagram(s)

(omitted — changes are UI validation, constant addition, and enhanced logging; no new multi-component control flow requiring diagram)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: fix minor ui issues #1524: Similar change adding UI warning text in Upscaling::DrawSettings.
• chore(upscaling): add back upscale multiplier #1532: Related edits to Streamline's GetInputResolutionScale and DLSS option handling.
• chore(upscaling): update SDKs #1684: Other DLSS-related upscaling adjustments touching Upscaling/Streamline code.

Suggested reviewers

• doodlum
• davo0411
• jiayev

Poem

"A rabbit hops in code and sings,
I added limits, warning things.
When DLSS climbs past the line,
I flash a color, send a sign.
Hop safe, pixels — keep them fine!" 🐇✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding warnings about NVIDIA DLSS maximum resolution limits in the upscaling feature.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: f02aad7
Using base ref: f02aad7
Base commit date: 2026-01-31T16:30:08-08:00 (Saturday, January 31, 2026 04:30 PM)
No actionable suggestions for changed features.

[Copilot]

Pull request overview

This PR adds user-facing warnings and improved error diagnostics for DLSS resolution limits. When users attempt to use DLSS with resolutions exceeding NVIDIA's maximum supported resolution of 8192 pixels, they will now see clear warnings in the UI and more informative error messages in the logs.

Changes:

• Adds MAX_RESOLUTION constant (8192) to the Streamline class to define DLSS resolution limits
• Implements UI warning in the upscaling settings panel that displays when DLSS is selected with an oversized resolution
• Enhances error logging to include both the enum name and numeric code for DLSS failures, and adds specific messaging when resolution limits are exceeded

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/Features/Upscaling/Streamline.h	Adds MAX_RESOLUTION constant to define the DLSS resolution limit
src/Features/Upscaling/Streamline.cpp	Adds resolution check in error path and improves error logging with enum names
src/Features/Upscaling.cpp	Adds proactive UI warning when DLSS is selected with resolution exceeding limits

[github-actions]

✅ A pre-release build is available for this PR:
Download