revert: "fix: stop shader compilation on game exit"

[brucenguyen]

Reverts #1867

Summary by CodeRabbit

• Refactor
  • Removed internal shutdown handlers and simplified message processing logic.
  • Removed explicit shader compilation stop functionality.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes global RE::Main pointer declaration and initialization, eliminates the OnGameWindowClose() function and its window close message hook handling, and deletes the ShaderCache::StopCompilation() method. The shader compilation loop no longer checks for game quit state.

Changes

Cohort / File(s)	Summary
Global declarations and initialization src/Globals.h, src/Globals.cpp	Removed extern declaration and definition of RE::Main* main from the globals namespace, eliminating the global reference to the game's main singleton.
Window close event handling src/Hooks.cpp	Removed WM_CLOSE message handling from the window procedure hook, which previously called globals::OnGameWindowClose(). The message now passes directly to the next handler without invoking the cleanup function.
Shader compilation control src/ShaderCache.h, src/ShaderCache.cpp	Removed public StopCompilation() method from ShaderCache, eliminating the ability to explicitly halt ongoing asynchronous shader compilation operations.
Plugin message processing src/XSEPlugin.cpp	Simplified the DataLoaded message handler by removing the main->quitGame check and early exit logic from the shader compilation wait loop, which previously allowed early termination if the game was closing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: stop shader compilation on game exit #1867: This PR directly reverts all changes introduced in that PR, removing the global main pointer, window close handling, shader compilation stop capability, and quit state checks.

Suggested reviewers

• alandtse

Poem

🐰 The windows close, the main takes flight,
Shader stops need not fight,
Quit checks fade away so bright,
Clean code flows with all our might!

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the changeset as a revert of a previous fix related to shader compilation on game exit, which matches the PR's explicit objective to revert PR #1867.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: cf28c87
Using base ref: cf28c87
Base commit date: 2026-02-15T01:50:45-08:00 (Sunday, February 15, 2026 01:50 AM)
No actionable suggestions for changed features.

[brucenguyen]

quitGame hook might not be working correctly on AE. Not sure, will probably remove that portion of this fix but until then this revert will unblock dev

[github-actions]

✅ A pre-release build is available for this PR:
Download