feat(weather editor): toggle hotkey

[SkrubbySkrubInAShrub]

Adds a hotkey to open and close the weather editor.
By default bound to F11.
Also changed the editor to be drawn as overlay rather than part of the main menu so it can be opened separately from the main CS menu.

Summary by CodeRabbit

• New Features
  • Added a configurable hotkey (default: F11) to toggle the Weather Editor window
  • Weather Editor now operates independently from the main menu and can be shown/hidden via the hotkey
  • New keybinding setting in Settings to customize the Weather Editor toggle key

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a Weather Editor hotkey: introduces WeatherEditorToggleKey to Menu::Settings (vector), wires it into serialization, migration, UI settings, input/hotkey processing, and overlay rendering to toggle and render the Weather Editor window independently.

Changes

Cohort / File(s)	Summary
Settings & Hotkey Wiring src/Menu.h, src/Menu.cpp	Added WeatherEditorToggleKey (std::vector) to Menu::Settings, included it in JSON serialization, legacy key migration, smart loader/save, and extended hotkey action table to map the combo to EditorWindow toggle.
Overlay Rendering & Input src/Menu/OverlayRenderer.cpp	When EditorWindow is open, render the Weather Editor and enable mouse cursor; treat editor-open as a reason to skip other overlay content. Included WeatherEditor/EditorWindow.h.
Settings UI src/Menu/SettingsTabRenderer.h, src/Menu/SettingsTabRenderer.cpp	Exposed settingWeatherEditorToggleKey in SettingsState and added a keybinding UI row to display/edit settings.WeatherEditorToggleKey in the Keybindings tab.

Sequence Diagram(s)

mermaid
sequenceDiagram
autonumber
participant User
participant UI as Settings UI
participant InputQ as Input Queue
participant Menu as Menu::HotkeyHandler
participant Editor as EditorWindow
participant Overlay as OverlayRenderer
User->>UI: Configure WeatherEditorToggleKey
UI->>Menu: Save settings (serialize)
User->>InputQ: Press hotkey
InputQ->>Menu: Deliver InputEvent
Menu->>Menu: Match against WeatherEditorToggleKey
Menu-->>Editor: Toggle open state
Editor-->>Overlay: Request render when open
Overlay->>User: Render Weather Editor / enable cursor

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor(ui): add settings for shader block hotkeys #1624: Modifies Menu hotkey fields and wiring—overlaps changes to Menu::Settings, serialization, and SettingsTabRenderer.
• refactor: break apart menu #1330: Broad refactor touching Menu input/keybinding and overlay rendering paths that this change also modifies.
• feat(UI): enhance shader blocking #1564: Alters OverlayRenderer::RenderOverlay control flow; related to changes that make editor rendering independent of main menu state.

Suggested reviewers

• davo0411
• alandtse

Poem

🐇 A soft keybinding hop and twirl,
F11 (or chosen) makes the weather unfurl,
Settings saved, the editor springs,
I dance on keys with tiny wings,
Rain or shine — the rabbit sings!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 27.27% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat(weather editor): toggle hotkey' directly and concisely summarizes the main change: adding a toggle hotkey feature for the weather editor.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 5313fbe
Using base ref: 5313fbe
Base commit date: 2026-02-11T12:34:42Z (Wednesday, February 11, 2026 12:34 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

src/Menu/OverlayRenderer.cpp (1)

54-65: ⚠️ Potential issue | 🟠 Major

Weather editor and main menu are mutually exclusive — likely unintentional.

The if/else if chain means when EditorWindow::open is true, drawSettings() is never called, so the main CS menu won't render. If the user has the main menu open and presses F12 to open the weather editor, the main menu disappears.

The PR objective states the editor should be openable "separately from the main CS menu," which implies they should coexist. Consider rendering the weather editor independently rather than as a mutually exclusive branch:

Proposed fix to allow both to render simultaneously

-	// Draw weather editor independently of main menu state
-	if (EditorWindow::GetSingleton()->open) {
-		ImGui::GetIO().MouseDrawCursor = true;
-		EditorWindow::GetSingleton()->Draw();
-	} else if (menu.IsEnabled || HomePageRenderer::ShouldShowFirstTimeSetup()) {
+	// Draw weather editor independently of main menu state
+	if (EditorWindow::GetSingleton()->open) {
+		ImGui::GetIO().MouseDrawCursor = true;
+		EditorWindow::GetSingleton()->Draw();
+	}
+
+	if (menu.IsEnabled || HomePageRenderer::ShouldShowFirstTimeSetup()) {
 		ImGui::GetIO().MouseDrawCursor = true;
 		if (menu.IsEnabled) {
 			drawSettings();
 		}
-	} else {
+	}
+
+	if (!EditorWindow::GetSingleton()->open && !menu.IsEnabled && !HomePageRenderer::ShouldShowFirstTimeSetup()) {
 		ImGui::GetIO().MouseDrawCursor = false;
 	}

src/Menu.cpp (1)

1159-1162: ⚠️ Potential issue | 🟠 Major

ShouldSwallowInput doesn't account for the Weather Editor being open.

When the Weather Editor is open but the main menu is closed, ShouldSwallowInput() returns false. This means game input (movement, combat, etc.) won't be blocked while the user is interacting with the editor's ImGui widgets, which will likely cause unintended in-game actions.

Proposed fix

 bool Menu::ShouldSwallowInput()
 {
-	return IsEnabled || HomePageRenderer::ShouldShowFirstTimeSetup();
+	return IsEnabled || HomePageRenderer::ShouldShowFirstTimeSetup() || EditorWindow::GetSingleton()->open;
 }

🤖 Fix all issues with AI agents

In `@src/Menu.h`:
- Around line 382-391: Change the default WeatherEditorToggleKey from VK_F12 to
a less-conflicting key (e.g., VK_F11) to avoid clashes with RenderDoc capture
hotkeys; update the initializer for WeatherEditorToggleKey and adjust its inline
comment in Menu.h (referencing the WeatherEditorToggleKey variable) so the new
default and intent are clear to users.

[github-actions]

✅ A pre-release build is available for this PR:
Download