build: bump versions and reduce false positives

[alandtse]

Removing perf and refactor from audit bumping. This means we have to be careful those don't change any actual apis/features requiring new hlsl files.

Summary by CodeRabbit

• Chores
  • Bumped version metadata across multiple shader feature configs and normalized line endings.
  • Enhanced version-audit tooling: refined which commit types are considered nonfunctional vs. bump-worthy, tightened rules for triggering version bumps, improved commit parsing, and added fallback logic to derive a version bump from the latest change when an explicit bump commit isn’t found.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9e86a522-2cd3-497e-a707-3abb1a801e60

📥 Commits

Reviewing files that changed from the base of the PR and between 9c64fea and 43b2c07.

📒 Files selected for processing (1)

• tools/feature_version_audit.py

🚧 Files skipped from review as they are similar to previous changes (1)

• tools/feature_version_audit.py

---

📝 Walkthrough

Walkthrough

Bumps the [Info].Version fields in 18 shader feature INI files (metadata-only edits, some line-ending changes) and updates tools/feature_version_audit.py to refine commit-type handling, bump-commit selection, fallback behavior, and patch-bump classification.

Changes

Cohort / File(s)	Summary
Feature Metadata Version Bumps features/Dynamic Cubemaps/Shaders/Features/DynamicCubemaps.ini, features/Grass Collision/Shaders/Features/GrassCollision.ini, features/Grass Lighting/Shaders/Features/GrassLighting.ini, features/Hair Specular/Shaders/Features/HairSpecular.ini, features/IBL/Shaders/Features/ImageBasedLighting.ini, features/Linear Lighting/Shaders/Features/LinearLighting.ini, features/Screen Space GI/Shaders/Features/ScreenSpaceGI.ini, features/Screen-Space Shadows/Shaders/Features/ScreenSpaceShadows.ini, features/Sky Sync/Shaders/Features/SkySync.ini, features/Skylighting/Shaders/Features/Skylighting.ini, features/Terrain Blending/Shaders/Features/TerrainBlending.ini, features/Terrain Shadows/Shaders/Features/TerrainShadows.ini, features/Unified Water/Shaders/Features/UnifiedWater.ini, features/Upscaling/Shaders/Features/Upscaling.ini, features/VR/Shaders/Features/VR.ini, features/Volumetric Lighting/Shaders/Features/VolumetricLighting.ini, features/Weather Editor/Shaders/Features/WeatherEditor.ini, features/Wetness Effects/Shaders/Features/WetnessEffects.ini	Bumped [Info].Version values (patch/minor increments) in each INI; metadata-only edits with occasional line-ending/formatting changes.
Versioning Tool Logic tools/feature_version_audit.py	Expanded nonfunctional commit types to include refactor and perf; altered commit retrieval to use full commit body with record separators; changed bump-commit selection to prefer feat/fix/breaking-change messages and added get_latest_commit() fallback when bump commit is absent; propose_new_version() now treats only fix as patch-level.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• ci: enhance feature version audit #1927: Overlapping edits to tools/feature_version_audit.py (commit-type handling and bump-selection logic).
• ci: add feature audit checks #1193: Prior changes to tools/feature_version_audit.py touching get_commits_for_file, get_bump_commit, and bump logic.
• chore: update feature versions #1705: Overlaps with metadata version bumps for several of the same feature INI files.

Suggested reviewers

• doodlum
• davo0411

Poem

"I nibble lines and count each change,
Eighteen bumps arranged in range.
The tool learned which commits to skip,
I hop on keys with tiny grip.
Carrots for release, a joyful spring!" 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: version bumps across multiple feature INI files and refinement of the version audit tool to reduce false positives by excluding 'perf' and 'refactor' commits.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

tools/feature_version_audit.py (1)

120-132: Keep a fallback commit for attribution.

After this filter, bump_commit stays None for features touched only by perf:/refactor: commits, so --pr-check and the report lose the link/author even for new-feature or missing-INI attention items. Falling back to the newest touching commit would preserve ownership without reopening bump false positives.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tools/feature_version_audit.py` around lines 120 - 132, In get_bump_commit,
preserve a fallback authorable commit when no feat/fix/breaking match is found:
capture the newest touching commit from the git log output (the first
commit_hash parsed) as a fallback before filtering, then proceed to check
messages with RE_COMMIT_FEAT, RE_COMMIT_FIX, and RE_COMMIT_BREAKING; if no match
is returned, return that fallback commit_hash so features touched only by
perf:/refactor: still have an attribution. Ensure you reference the same
subprocess/git invocation (using file_path and base_ref) and keep behavior
unchanged when a matching commit is found.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tools/feature_version_audit.py`:
- Line 43: The current RE_COMMIT_NONFUNCTIONAL regex incorrectly treats "perf"
and "refactor" as nonfunctional; update it so only truly nonfunctional prefixes
are suppressed (e.g., keep only chore|docs|style|ci|test|build) and remove perf
and refactor from RE_COMMIT_NONFUNCTIONAL, and/or add an explicit override in
the commit-parsing logic (the code that uses RE_COMMIT_NONFUNCTIONAL around the
block referenced by lines 267-285) to force re-evaluation when commits include
shader- or API-affecting markers (e.g., detect "perf:"/"refactor:" plus a
"[nonfunctional]" token or scan commit body for shader-related files) so
shader-affecting perf/refactor commits still trigger a version bump.

---

Nitpick comments:
In `@tools/feature_version_audit.py`:
- Around line 120-132: In get_bump_commit, preserve a fallback authorable commit
when no feat/fix/breaking match is found: capture the newest touching commit
from the git log output (the first commit_hash parsed) as a fallback before
filtering, then proceed to check messages with RE_COMMIT_FEAT, RE_COMMIT_FIX,
and RE_COMMIT_BREAKING; if no match is returned, return that fallback
commit_hash so features touched only by perf:/refactor: still have an
attribution. Ensure you reference the same subprocess/git invocation (using
file_path and base_ref) and keep behavior unchanged when a matching commit is
found.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e0fd8127-1f20-4e3a-9d32-dababdbebe8c

📥 Commits

Reviewing files that changed from the base of the PR and between 8c08804 and a3891a5.

📒 Files selected for processing (19)

• features/Dynamic Cubemaps/Shaders/Features/DynamicCubemaps.ini
• features/Grass Collision/Shaders/Features/GrassCollision.ini
• features/Grass Lighting/Shaders/Features/GrassLighting.ini
• features/Hair Specular/Shaders/Features/HairSpecular.ini
• features/IBL/Shaders/Features/ImageBasedLighting.ini
• features/Linear Lighting/Shaders/Features/LinearLighting.ini
• features/Screen Space GI/Shaders/Features/ScreenSpaceGI.ini
• features/Screen-Space Shadows/Shaders/Features/ScreenSpaceShadows.ini
• features/Sky Sync/Shaders/Features/SkySync.ini
• features/Skylighting/Shaders/Features/Skylighting.ini
• features/Terrain Blending/Shaders/Features/TerrainBlending.ini
• features/Terrain Shadows/Shaders/Features/TerrainShadows.ini
• features/Unified Water/Shaders/Features/UnifiedWater.ini
• features/Upscaling/Shaders/Features/Upscaling.ini
• features/VR/Shaders/Features/VR.ini
• features/Volumetric Lighting/Shaders/Features/VolumetricLighting.ini
• features/Weather Editor/Shaders/Features/WeatherEditor.ini
• features/Wetness Effects/Shaders/Features/WetnessEffects.ini
• tools/feature_version_audit.py

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

tools/feature_version_audit.py (1)

43-43: ⚠️ Potential issue | 🟠 Major

Don't treat all perf:/refactor: commits as nonfunctional.

A feature touched only by perf:/refactor: commits now hits the is_nonfunctional_only path and skips the bump entirely. That can hide shader/API changes that still require a new INI/HLSL version.

Minimal fix

-RE_COMMIT_NONFUNCTIONAL = re.compile(r"^(chore|docs|style|ci|test|build|refactor|perf)(\(|:|\s)", re.IGNORECASE)
+RE_COMMIT_NONFUNCTIONAL = re.compile(r"^(chore|docs|style|ci|test|build)(\(|:|\s)", re.IGNORECASE)

Also applies to: 278-287

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tools/feature_version_audit.py` at line 43, The regex RE_COMMIT_NONFUNCTIONAL
currently treats "perf" and "refactor" commits as nonfunctional which causes
is_nonfunctional_only to skip bumps; update the pattern used by
RE_COMMIT_NONFUNCTIONAL to remove "perf" and "refactor" so only truly
nonfunctional types (e.g., chore, docs, style, ci, test, build) are matched, and
ensure the other occurrences referenced around the is_nonfunctional_only logic
(lines near 278-287) use the updated constant so perf/refactor commits no longer
bypass version bump checks.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tools/feature_version_audit.py`:
- Around line 126-136: This routine currently returns a per-file fallback_commit
when no matching feat/fix/breaking message is found, which lets the caller stop
early on a non-actionable commit; change the logic so that if a matching commit
(checked via RE_COMMIT_FEAT, RE_COMMIT_FIX, RE_COMMIT_BREAKING against msg) is
not found in the file's output the function returns None (or another sentinel)
instead of fallback_commit so the caller can continue scanning other changed
files for a real bump commit; keep the same parsing of output, commit_hash, and
msg but only return fallback_commit if you change the caller to accept it as a
definitive result — otherwise return None to avoid short-circuiting.

---

Duplicate comments:
In `@tools/feature_version_audit.py`:
- Line 43: The regex RE_COMMIT_NONFUNCTIONAL currently treats "perf" and
"refactor" commits as nonfunctional which causes is_nonfunctional_only to skip
bumps; update the pattern used by RE_COMMIT_NONFUNCTIONAL to remove "perf" and
"refactor" so only truly nonfunctional types (e.g., chore, docs, style, ci,
test, build) are matched, and ensure the other occurrences referenced around the
is_nonfunctional_only logic (lines near 278-287) use the updated constant so
perf/refactor commits no longer bypass version bump checks.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ad854992-3c7a-489d-ac54-cf7fa8b7b82c

📥 Commits

Reviewing files that changed from the base of the PR and between a3891a5 and 9b93b28.

📒 Files selected for processing (1)

• tools/feature_version_audit.py

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tools/feature_version_audit.py`:
- Around line 137-146: The fallback commit selection is non-deterministic
because you iterate a deduplicated set of changed files (changes) and pick the
"first" file in process order; make this stable by converting the set to a
deterministically ordered list (e.g., sorted(changes)) before iterating/choosing
a fallback and call get_latest_commit(file_path, base_ref) from that ordered
list; apply the same deterministic sorting wherever the code similarly picks the
first file/commit (including the other occurrence referenced around lines
389-401).
- Around line 131-132: The code only tests msg (which currently holds the commit
subject via "%s") against RE_COMMIT_BREAKING, so trailers like "BREAKING
CHANGE:" in the body are never seen; update the logic that builds msg (or fetch
the full commit message for commit_hash) to use the complete commit body (e.g.
use git show --pretty=%B or equivalent) before applying RE_COMMIT_FEAT,
RE_COMMIT_FIX and RE_COMMIT_BREAKING, then re-run the existing checks that
return commit_hash when a match is found.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a79ef63e-28c0-4b8d-90fa-adae983559ea

📥 Commits

Reviewing files that changed from the base of the PR and between 9b93b28 and 9c64fea.

📒 Files selected for processing (1)

• tools/feature_version_audit.py