fix(weather editor): apply weather settings post-load

[SkrubbySkrubInAShrub]

On startup and after loading weather adjustments the editor would only load these edits into memory and not actually apply them to the weathers in game, this PR ensures that all weather edits that are loaded also get applied when they are loaded.

Summary by CodeRabbit

• Bug Fixes
  • Saved settings now automatically apply when loaded, ensuring your preferences take effect immediately without requiring additional steps.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The Widget::Load() method now immediately calls ApplyChanges() after loading saved settings, ensuring loaded values are applied to the runtime state directly without requiring a separate explicit call.

Changes

Cohort / File(s)	Summary
Settings Application src/WeatherEditor/Widget.cpp	Added ApplyChanges() invocation immediately after loading saved settings to synchronize loaded values with runtime state

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

• doodlum

Poem

🐰✨ With one hop, changes now flow,

No settings left to linger slow!

Load and apply, both working as one,

The rabbit declares—the fix is done! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: applying weather settings after loading them, which is exactly what the one-line addition to Widget::Load() accomplishes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 423541f
Using base ref: 423541f
Base commit date: 2026-01-28T16:52:52Z (Wednesday, January 28, 2026 04:52 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/WeatherEditor/Widget.cpp`:
- Around line 115-116: LoadSettings() currently assigns numeric JSON values
(e.g., settings.intensity) directly and then ApplyChanges() applies them to
RE::* objects; add range clamping/validation in LoadSettings() (or a short
pre-ApplyChanges validation pass) to ensure all numeric fields are within
UI-expected bounds before ApplyChanges() runs. Locate LoadSettings() and for
each numeric setting read from JSON (such as settings.intensity) use std::clamp
with the same min/max ranges used in the UI or WeatherUtils.cpp, and handle
out-of-range or missing values consistently (fallback to defaults) so
ApplyChanges() only sees validated values. Ensure the null-check/try-catch stays
and that clamping occurs after parsing but before calling ApplyChanges().

[github-actions]

✅ A pre-release build is available for this PR:
Download