fix(UI): input spam after alt-tab

[Dlizzio]

Fixes spammed inputs after alt-tabbing out of skyrim window.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced keyboard input stability when switching applications. Fixed an issue where key inputs could become unresponsive or stuck after using alt-tab to switch windows. The system now accurately tracks and synchronizes key states with the operating system, ensuring consistent keyboard responsiveness whether you're switching between applications or working within a single window.

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified keyboard event handling in Menu.cpp to synchronize key-up events with OS state using GetAsyncKeyState(). This addresses DirectInput's tendency to lose key-up events after alt-tab operations by computing a pressed state that combines the event status with the actual OS key state before calling AddKeyEvent.

Changes

Cohort / File(s)	Summary
Keyboard Input Synchronization src/Menu.cpp	Changed key event handling to guard AddKeyEvent calls by checking both DirectInput events and OS state via GetAsyncKeyState. Applied to non-control keys and modifier keys (Ctrl, Shift, Alt). Removed fallback block that manually released Shift and Tab keys when OS reported them unpressed. Added explanatory comment about DirectInput's lost key-up events after alt-tab.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• fix(UI): conflicting esc key on welcome hotkey dialogue #1811: Modifies Menu.cpp's keyboard event handling and how key-up release events are routed.
• fix(input): resolve alt-tab and shift-tab bugs #1196: Modifies Menu.cpp's input handling using GetAsyncKeyState to synchronize modifier/Tab/Shift key-up events with OS state.

Suggested reviewers

• davo0411
• alandtse
• doodlum

Poem

🐰 A rabbit hops with keyboard in paw,
DirectInput lost keys—what a flaw!
Now alt-tab releases sync true,
OS state checked through and through.
Pressed keys dance where they belong! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(UI): input spam after alt-tab' directly and concisely describes the main change: fixing input spam that occurs after alt-tabbing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

🧹 Nitpick comments (1)

src/Menu.cpp (1)

1092-1101: Please link the bug issue in the PR description.

Since this is a bug fix, add Fixes #<issue> (or Closes #<issue>) once you have the issue number.

As per coding guidelines: "Issue References (if PR fixes bugs or implements features): Suggest adding appropriate GitHub keywords: 'Fixes #123' or 'Closes #123' for bug fixes."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Menu.cpp` around lines 1092 - 1101, This PR fixes a bug in the input
handling in Menu.cpp (the block updating ImGui key/mod states using
GetAsyncKeyState and io.AddKeyEvent), so update the pull request description to
include an issue reference using the GitHub keywords (e.g., add a line "Fixes
#<issue>" or "Closes #<issue>") pointing to the bug tracker entry; ensure the
referenced issue number is correct and placed in the PR description so merging
will automatically close the issue.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/Menu.cpp`:
- Around line 1092-1101: This PR fixes a bug in the input handling in Menu.cpp
(the block updating ImGui key/mod states using GetAsyncKeyState and
io.AddKeyEvent), so update the pull request description to include an issue
reference using the GitHub keywords (e.g., add a line "Fixes #<issue>" or
"Closes #<issue>") pointing to the bug tracker entry; ensure the referenced
issue number is correct and placed in the PR description so merging will
automatically close the issue.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5b8c4d46-5a63-4f4a-8ff8-5ef4a86e1793

📥 Commits

Reviewing files that changed from the base of the PR and between 354859c and 2ae1466.

📒 Files selected for processing (1)

• src/Menu.cpp

[github-actions]

✅ A pre-release build is available for this PR:
Download