fix(UI): first-time dialog fade affects all overlays

[Dlizzio]

First-time dialog box background fade now appears over shader compilation window.

Summary by CodeRabbit

• Bug Fixes
  • Added a fullscreen modal overlay to the first-time setup dialog for improved visual prominence.
  • Ensured the setup dialog receives focus reliably for smoother interaction.
  • Reordered overlay rendering to improve dialog visibility and UI layering.

[coderabbitai]

📝 Walkthrough

Walkthrough

Replaced the Util modal-background call with an inlined fullscreen modal overlay drawn on the dialog draw list, added ImGui window-focus for the first-time setup window, introduced a MODAL_OVERLAY_ALPHA constant, and moved the first-time-setup overlay rendering to occur after feature overlays.

Changes

Cohort / File(s)	Summary
Modal Overlay Rendering src/Menu/HomePageRenderer.cpp	Removed Util::DrawModalBackground, added ImGui::SetNextWindowFocus, and draw a fullscreen filled-rect modal overlay (clipped) on the dialog's draw list so it sits behind dialog content.
Rendering Constants src/Menu/HomePageRenderer.h	Added static constexpr uint8_t MODAL_OVERLAY_ALPHA = 160; and included <cstdint>.
Overlay Rendering Order src/Menu/OverlayRenderer.cpp	Changed RenderOverlay() order: RenderFirstTimeSetupOverlay() now runs after RenderFeatureOverlays() instead of before.

Sequence Diagram(s)

mermaid
sequenceDiagram
autonumber
participant OR as OverlayRenderer
participant HF as HomePageRenderer
participant DL as ImGuiDrawList
rect rgba(200,200,255,0.5)
Note over OR: Before: first-time overlay rendered early
OR->>HF: RenderFirstTimeSetupOverlay()
HF->>DL: Draw modal background (previous)
end
rect rgba(200,255,200,0.5)
Note over OR: After: feature overlays first, then first-time overlay
OR->>OR: RenderFeatureOverlays()
OR->>HF: RenderFirstTimeSetupOverlay()
HF->>DL: Draw fullscreen filled rect (MODAL_OVERLAY_ALPHA) -> Draw dialog content
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• chore: edit welcome dialogue behavior #1743: Related changes to HomePageRenderer's first-time-setup modal behavior and modal background utilities.
• feat(ui): font size and perf overlay improvements #1511: Changes to OverlayRenderer's RenderOverlay ordering/behavior.
• fix(UI): conflicting esc key on welcome hotkey dialogue #1811: Modifications to HomePageRenderer's first-time-setup dialog rendering flow.

Suggested reviewers

• alandtse
• doodlum
• davo0411

Poem

🐰 I hopped on a canvas, soft and wide,
Drew a muted blanket where secrets hide,
Focused the window, then layered the rest,
Overlay tucked neatly behind the quest,
A tiny rabbit cheers—now the UI's dressed!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: fixing the first-time dialog's fade overlay to properly affect all overlays by reordering render calls and improving overlay rendering.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/Menu/OverlayRenderer.cpp (1)

73-75: Consider moving first-time overlay after A/B testing for strict topmost modal precedence.

Right now HandleABTesting() renders after RenderFirstTimeSetupOverlay(), so AB-testing UI can appear above the first-time modal when enabled.

Proposed ordering tweak

 	RenderFeatureOverlays();
-	RenderFirstTimeSetupOverlay();
 	HandleABTesting();
+	RenderFirstTimeSetupOverlay();
 	FinalizeImGuiFrame();

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Menu/OverlayRenderer.cpp` around lines 73 - 75, The first-time setup
modal is being rendered before A/B testing UI (RenderFeatureOverlays();
RenderFirstTimeSetupOverlay(); HandleABTesting();) which lets AB testing appear
above it; reorder the calls so HandleABTesting() runs before
RenderFirstTimeSetupOverlay() (i.e., RenderFeatureOverlays(); HandleABTesting();
RenderFirstTimeSetupOverlay()) so the first-time overlay is drawn last and
always appears as the topmost modal.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/Menu/HomePageRenderer.h`:
- Line 17: The header HomePageRenderer.h uses uint8_t for the static constant
MODAL_OVERLAY_ALPHA but does not include <cstdint>; add an explicit `#include`
<cstdint> at the top of HomePageRenderer.h so uint8_t is defined locally
(avoiding reliance on transitive includes) and ensure the include is placed
before the MODAL_OVERLAY_ALPHA declaration so the header is self-contained.

---

Nitpick comments:
In `@src/Menu/OverlayRenderer.cpp`:
- Around line 73-75: The first-time setup modal is being rendered before A/B
testing UI (RenderFeatureOverlays(); RenderFirstTimeSetupOverlay();
HandleABTesting();) which lets AB testing appear above it; reorder the calls so
HandleABTesting() runs before RenderFirstTimeSetupOverlay() (i.e.,
RenderFeatureOverlays(); HandleABTesting(); RenderFirstTimeSetupOverlay()) so
the first-time overlay is drawn last and always appears as the topmost modal.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 865923bc-2371-4aa9-8348-69c7ab7166ad

📥 Commits

Reviewing files that changed from the base of the PR and between 4f1df36 and e65fb68.

📒 Files selected for processing (3)

• src/Menu/HomePageRenderer.cpp
• src/Menu/HomePageRenderer.h
• src/Menu/OverlayRenderer.cpp

[github-actions]

✅ A pre-release build is available for this PR:
Download

[alandtse]

Fix should cover some bug. Are you saying the fade is impacting other overlays improperly? If so, then ok. I'm not clear from your title or description on the intended impact here.

[Dlizzio]

Fix should cover some bug. Are you saying the fade is impacting other overlays improperly? If so, then ok. I'm not clear from your title or description on the intended impact here.

There is a fade behind the dialogue box and the shader compilation window was appearing above it. My fix only impacts that overlay and makes it appear behind it.