feat: add shadowmap rasterizer override

[Dawntic]

This PR addresses issue #1575 by adding the ability to adjust the depth and slope scale bias of each shadow cascades rasterizers. The goal of this is to eliminate peter panning and self shadowing in both cascades.
This PR removes the shader based offset applied to the shadow mask lookup depth. It also adds an additional bias to the volumetric lighting coordinate math to avoid sub-voxel bleeding.

Both the shadow mask and volumetric lighting shaders have had logic added to flip the default shadow state for interiors vs exteriors. This is a consistency fix unrelated to biasing that didn't seem worth a 3 line PR.

Note: This does not have a VR offset yet.

Vanilla shadowmask:

New shadowmask:

Summary by CodeRabbit

• New Features

  • Added per-cascade rasterizer handling and a new rasterizer fix to apply cascade-specific shadow rasterizer settings.

• Bug Fixes

  • Simplified shadow depth comparisons to reduce false occlusion and artifacts.
  • Prevented unintended shadow tinting indoors.
  • Adjusted cascade depth-bias behavior and cloning to improve shadow stability and visual quality.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a new EngineFix that applies per-cascade rasterizer states during cascade shadow rendering, updates shader shadow logic (compute-coordinate init and depth comparisons), and forces transparent/no-shadow behavior when SharedData::InInterior is true.

Changes

Cohort / File(s)	Summary
Shader Shadow Rendering Updates package/Shaders/ISVolumetricLightingGenerateCS.hlsl, package/Shaders/Utility.hlsl	Adjusted normalized-coordinate initialization in the compute shader; noShadow default now depends on SharedData::InInterior; simplified depth comparisons to use positionLS.z; interior guard zeros shadowColor and final lerp respects interior state.
Engine Fix Registration src/EngineFix.cpp	Added include and static ShadowmapCascadeRasterizerFix instance and registered it in the OnPostPostLoad fixes list.
Cascade Rasterizer State Management src/EngineFixes/ShadowmapCascadeRasterizerFix.h, src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp	New ShadowmapRasterizerFix with Install() and a thunk hook for cascade render; captures/backups global raster states; clones and applies per-cascade rasterizer states; maps descriptor fields to D3D11 rasterizer desc; restores originals after final cascade; adds cascade-specific bias descriptors.

Sequence Diagram(s)

sequenceDiagram
    participant Engine as Engine
    participant Fix as ShadowmapCascadeRasterizerFix
    participant States as Global Raster States
    participant Renderer as Cascade Render Path

    Engine->>Fix: Install()
    Fix->>States: Capture & backup gRasterStates
    Fix->>Fix: Initialize cascade counters & clone states

    Renderer->>Fix: thunk invoked (cascade N start)
    Fix->>Fix: Prepare/clone states for cascade N
    Fix->>States: Apply cascade-N raster states to global
    Fix->>Renderer: Call original cascade render function
    Renderer->>Renderer: Render cascade N

    Renderer->>Fix: thunk invoked (after final cascade)
    Fix->>States: Restore original global raster states
    Fix->>Renderer: Return to normal rendering

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• perf: optimize utility and diffuseiblcs #1346 — Modifies Poisson/shadow visibility code in package/Shaders/Utility.hlsl, overlaps shadow visibility logic changes.
• feat: add Interior Sun Shadows #1076 — Changes cascade shadow rendering / rasterizer state behavior and install hooks; relates to per-cascade rasterizer state management.

Suggested reviewers

• davo0411
• alandtse

Poem

🐰 I tweak the biases, hop through states,
Three cascades dance while shadow waits,
Coordinates nudged, interiors made clear,
Per-cascade hops keep renders sincere,
A tiny nibble — then the frame celebrates.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: add shadowmap rasterizer override' accurately describes the main change—adding per-cascade shadow rasterizer state management with depth and slope-scale bias controls.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: afa9b41
Using base ref: afa9b41
Base commit date: 2026-02-15T21:17:17+10:00 (Sunday, February 15, 2026 09:17 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 4

🤖 Fix all issues with AI agents

In @src/EngineFixes/ShadowmapCascadeRasterizerFix.h:
- Line 46: Remove the redundant "#pragma once" instance in
ShadowmapCascadeRasterizerFix.h by deleting the duplicate pragma at the end of
the file so only the single top-of-file "#pragma once" remains; no other changes
required.
- Line 13: The header hardcodes static constexpr uint numCascades = 2 which
mismatches Utility.hlsl supporting up to 3 cascades; change numCascades to 3 and
add the missing third cascade rasterizer descriptor/state where the cascade
descriptor table/array or switch in ShadowmapCascadeRasterizerFix (the code that
cycles cascadeIndex) is defined so cascadeIndex can be 0,1,2; ensure the added
descriptor matches the other two (rasterizer state and bias settings) and update
any loop bounds or modulo logic that uses numCascades so the thunk cycles
through three cascades consistently with the shader.

🧹 Nitpick comments (2)

package/Shaders/Utility.hlsl (1)

630-631: Suggest formatting improvements for consistency.

The interior shadow guard logic is correct and aligns with the PR's objective to flip default shadow state for interiors.

Minor formatting improvements

-	if(SharedData::InInterior)
-		shadowColor = float4(0,0,0,0);
+	if (SharedData::InInterior)
+		shadowColor = float4(0, 0, 0, 0);

src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp (1)

39-44: Consider marking helper function as inline.

This simple field-assignment helper could benefit from inline to avoid call overhead when invoked in the tight loop at Line 57.

-void ShadowmapRasterizerFix::GetUpdatedRasterDesc(D3D11_RASTERIZER_DESC& outputDesc, ShadowMapRasterizerDescriptor shadowmapDesc)
+inline void ShadowmapRasterizerFix::GetUpdatedRasterDesc(D3D11_RASTERIZER_DESC& outputDesc, ShadowMapRasterizerDescriptor shadowmapDesc)

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee0158a and c5ad7bf.

📒 Files selected for processing (5)

• package/Shaders/ISVolumetricLightingGenerateCS.hlsl
• package/Shaders/Utility.hlsl
• src/EngineFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.h

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• package/Shaders/Utility.hlsl
• package/Shaders/ISVolumetricLightingGenerateCS.hlsl
• src/EngineFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.h

**/*

⚙️ CodeRabbit configuration file

**/*: When reviewing PRs, please provide suggestions for:

1. Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
   if the existing title does not describe the code changes):
   Format: type(scope): description
   Length: 50 characters limit for title, 72 for body
   Style: lowercase description, no ending period
   Examples:

   • feat(vr): add cross-eye sampling
   • fix(water): resolve flowmap bug
   • docs: update shader documentation

2. Issue References (if PR fixes bugs or implements features):
   Suggest adding appropriate GitHub keywords:

   • "Fixes #123" or "Closes #123" for bug fixes
   • "Implements #123" or "Addresses #123" for features
   • "Related to #123" for partial implementations

Otherwise, use your standard review approach focusing on code quality.

Files:

• package/Shaders/Utility.hlsl
• package/Shaders/ISVolumetricLightingGenerateCS.hlsl
• src/EngineFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.h

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/EngineFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.h

🧠 Learnings (7)

📓 Common learnings

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

Learnt from: jiayev
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-08-03T18:37:19.690Z
Learning: ISReflectionsRayTracing.hlsl and ISWorldMap.hlsl in the skyrim-community-shaders repository are image-space post-processing shaders that perform color sampling and blending operations that need proper linear color space handling for the linear lighting system. ISReflectionsRayTracing handles screen-space reflections and should use conditional Color::IrradianceToLinear/Gamma conversions similar to ISCompositeLensFlareVolumetricLighting.hlsl. ISWorldMap performs 7x7 color accumulation that should be done in linear space similar to the pattern used in ISSAOComposite.hlsl.

Learnt from: jiayev
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-18T15:21:03.641Z
Learning: In the skyrim-community-shaders rendering pipeline, materials with alpha < 1 or alpha blending enabled are rendered in non-deferred mode rather than deferred mode. This means issues with dynamic cubemaps on transparent materials are actually non-deferred rendering issues.

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Avoid GPU register/buffer conflicts in HLSL; verify register usage (e.g., with hlslkit buffer scanning)

📚 Learning: 2025-08-03T18:37:19.690Z

Learnt from: jiayev
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-08-03T18:37:19.690Z
Learning: ISReflectionsRayTracing.hlsl and ISWorldMap.hlsl in the skyrim-community-shaders repository are image-space post-processing shaders that perform color sampling and blending operations that need proper linear color space handling for the linear lighting system. ISReflectionsRayTracing handles screen-space reflections and should use conditional Color::IrradianceToLinear/Gamma conversions similar to ISCompositeLensFlareVolumetricLighting.hlsl. ISWorldMap performs 7x7 color accumulation that should be done in linear space similar to the pattern used in ISSAOComposite.hlsl.

Applied to files:

• package/Shaders/Utility.hlsl
• package/Shaders/ISVolumetricLightingGenerateCS.hlsl

📚 Learning: 2025-08-17T18:37:35.839Z

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Avoid GPU register/buffer conflicts in HLSL; verify register usage (e.g., with hlslkit buffer scanning)

Applied to files:

• package/Shaders/Utility.hlsl
• package/Shaders/ISVolumetricLightingGenerateCS.hlsl

📚 Learning: 2025-07-05T05:20:45.823Z

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

Applied to files:

• package/Shaders/Utility.hlsl

📚 Learning: 2025-06-17T05:40:22.785Z

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 577
File: features/Wetness Effects/Shaders/WetnessEffects/WetnessEffects.hlsli:57-61
Timestamp: 2025-06-17T05:40:22.785Z
Learning: Default parameter values are supported in the HLSL compiler used by the skyrim-community-shaders project, contrary to standard HLSL (FXC/DXC) limitations.

Applied to files:

• package/Shaders/Utility.hlsl
• package/Shaders/ISVolumetricLightingGenerateCS.hlsl

📚 Learning: 2025-08-17T18:37:35.839Z

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Place all feature shaders under features/YourFeature/Shaders/

Applied to files:

• package/Shaders/Utility.hlsl

📚 Learning: 2025-06-08T11:25:14.536Z

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 577
File: src/Features/WetnessEffects.h:36-36
Timestamp: 2025-06-08T11:25:14.536Z
Learning: In the skyrim-community-shaders project, boolean flags in C++ structs that interface with HLSL shaders use `uint` type instead of `bool` for compatibility reasons. This ensures consistent 4-byte size, proper 16-byte alignment in constant buffers, and cross-platform compatibility when passing data between C++ and HLSL shaders.

Applied to files:

• package/Shaders/Utility.hlsl

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Run Shader Unit Tests
• GitHub Check: Validate shader compilation (Flatrim, .github/configs/shader-validation.yaml)
• GitHub Check: Validate shader compilation (VR, .github/configs/shader-validation-vr.yaml)
• GitHub Check: Build plugin and addons

🔇 Additional comments (8)

package/Shaders/ISVolumetricLightingGenerateCS.hlsl (2)

97-97: LGTM: Interior shadow state flip is consistent.

The default shadow state now correctly reflects interior/exterior conditions, aligning with the broader changes in Utility.hlsl (Line 630-631, 698) that handle interior shadowing differently.

---

82-82: Clarify the z-coordinate offset and verify sampler behavior for negative coordinates.

Line 82 applies dispatchID.z - 1.0 which produces negative normalized coordinates when dispatchID.z == 0 (always, given [numthreads(32, 32, 1)]). This offset differs from the xy coordinates' +0.5 adjustment. Confirm this asymmetry is intentional and that the 1D texture sampler (line 86) is configured to handle negative UVs safely, either through addressing mode clamping or by design.

package/Shaders/Utility.hlsl (3)

653-659: LGTM: Shadow threshold removal aligns with rasterizer-based bias approach.

Removing the shader-based threshold (shadowMapThreshold) from these comparisons is consistent with the PR's objective to move depth/slope bias control to the per-cascade rasterizer state (introduced in ShadowmapCascadeRasterizerFix). This eliminates the dual-bias issue mentioned in the PR description.

---

669-675: LGTM: Cascade blending threshold removal is consistent.

The removal of shader-based thresholds in the cascade 1 blending path maintains consistency with the primary cascade handling (Lines 653-659) and ensures uniform behavior across all shadow filter modes.

---

698-698: LGTM: Interior-aware shadow blending is correct.

The lerp with !SharedData::InInterior correctly handles the shadow base value:

• Exteriors: lerp(1, shadowVisibility, fadeFactor) maintains existing behavior
• Interiors: lerp(0, shadowVisibility, fadeFactor) applies shadows from a "fully lit" base

This works in tandem with the guard at Lines 630-631, which ensures interiors outside the cascade range remain fully lit.

src/EngineFix.cpp (1)

4-14: LGTM: Fix registration follows established pattern.

The new ShadowmapRasterizerFix is correctly wired into the OnPostPostLoad fixes list following the same pattern as ShadowmapCascadeCullingFix. The grouping of related shadow-map fixes is appropriate.

src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp (2)

3-9: Verify relocation offset across all runtime versions.

The hardcoded offset 0xC6 uses REL::Relocate(0xC6, 0xC6, 0xC6), indicating the same offset for SE/AE/VR. Confirm this offset is correct across all three runtime versions, as address layouts can differ.

---

11-37: Add defensive cascade validation or document the sequential call guarantee.

The static cascade counter assumes this function is called exactly once per cascade in sequential order (0, 1, 0, 1, ...). While the Install() comment documents this assumption, the code has no guards against:

• Conditional cascade skipping
• Out-of-order cascade rendering
• Multiple calls per cascade

Either add assert() or if checks to validate the expected call pattern, or add a code comment cross-referencing the engine code/version that guarantees this behavior. This protects against silent state corruption if the rendering pipeline changes.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[coderabbitai]

Actionable comments posted: 6

🤖 Fix all issues with AI agents

In @src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp:
- Around line 55-62: The created rasterizer COM objects stored in
shadowmapRasterStates by the CreateRasterizerState call are never released,
causing a resource leak; add a ShadowmapRasterizerFix::Cleanup (or call from the
class destructor/Uninstall) that iterates the shadowmapRasterStates
multi-dimensional array, calls Release() on each non-null state and sets the
pointer to nullptr, and ensure Cleanup is invoked when the fix is unloaded or
the application shuts down (or document that the states are intentionally
persistent for process lifetime).
- Line 29: Fix the typo in the comment "Implace" to read "In-place" in
ShadowmapCascadeRasterizerFix.cpp; locate the comment string (currently
"Implace") near the rasterizer/cascade handling comments and update it to
"In-place" so the comment is correctly spelled.
- Line 8: The global pointer gRasterStates (RasterStateArray) can be null after
relocation and is dereferenced in thunk (causing a crash); add a null check
either when assigning in Install() or at the start of thunk(): if gRasterStates
is null, log an error via logger::error (with a clear message including
"gRasterStates is null") and call the original function (func(light, arg1, arg2,
flags)) to return early instead of proceeding, ensuring no dereference occurs;
update Install() to validate REL::RelocationID result or add the early-return
guard in thunk() before any access to gRasterStates.
- Around line 18-21: After reading numCascades from RE::GetINISetting, validate
and clamp it to a safe range to avoid underflow and out-of-bounds access: if
numCascades is 0 set it to 1, and if it exceeds maxCascades set it to
maxCascades; update any logic that uses numCascades (e.g., the cascade loop,
indexing into shadowmapRasterStates[cascade], and calculations that use
numCascades - 1) so they use the validated value; keep the existing
backupGameRasterStates and gRasterStates handling but perform this validation
immediately after reading the INI setting to prevent infinite loops and OOB
indexing.
- Line 20: The code dereferences RE::GetINISetting("iNumSplits:Display")->data.u
without checking for nullptr; modify the code in
ShadowmapCascadeRasterizerFix.cpp so you first store the result of
RE::GetINISetting("iNumSplits:Display") in a local pointer (e.g., auto setting =
RE::GetINISetting(...)), check if setting is non-null, and only then read
setting->data.u into numCascades; if setting is null, assign a safe default to
numCascades (or skip override) and optionally log the missing setting.

In @src/EngineFixes/ShadowmapCascadeRasterizerFix.h:
- Around line 13-18: Validate and clamp numCascades against maxCascades early
(e.g., in Install() or thunk()) to prevent out-of-bounds access to
shadowmapRasterStates; add a check such as if (numCascades > maxCascades) {
logger::error("numCascades ({}) exceeds maxCascades ({}), clamping",
numCascades, maxCascades); numCascades = maxCascades; } or simply numCascades =
std::min(numCascades, maxCascades); so all subsequent indexing into
shadowmapRasterStates[cascade] is safe.

🧹 Nitpick comments (4)

src/EngineFixes/ShadowmapCascadeRasterizerFix.h (2)

9-9: Document the RasterStateArray dimensions.

The four-dimensional array [2][3][12][2] represents 144 distinct rasterizer state permutations, but the meaning of each dimension (e.g., fill mode, cull mode, depth mode, scissor) is not documented. Adding a comment would improve maintainability.

📝 Example documentation

+// RasterStateArray dimensions: [fillMode][cullMode][depthMode][scissorMode]
+// fillMode: 2 modes (solid, wireframe)
+// cullMode: 3 modes (none, front, back)
+// depthMode: 12 depth configurations
+// scissorMode: 2 modes (enabled, disabled)
 using RasterStateArray = ID3D11RasterizerState* [2][3][12][2];

---

20-30: Consider externalizing bias constants to INI settings.

The per-cascade depth bias, clamp, and slope scale values are hardcoded. While acceptable for initial implementation, exposing these as INI settings would allow users to fine-tune shadow quality without recompiling, especially given that the PR objectives mention addressing peter-panning and self-shadowing which can be scene-dependent.

src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp (2)

38-38: Simplify cascade counter wraparound logic.

The expression cascade = ++cascade < numCascades ? cascade : 0; is correct but unnecessarily complex. A simpler pattern improves readability.

♻️ Clearer alternative

-	cascade = ++cascade < numCascades ? cascade : 0;
+	cascade = (cascade + 1) % numCascades;

Note: This assumes numCascades > 0 (which should be validated as noted in earlier comments).

---

51-66: Add error logging for failed rasterizer state creation.

While DX::ThrowIfFailed will throw an exception on failure, catching and logging which specific state permutation failed would aid debugging. Consider wrapping the creation in a try-catch to log the indices before re-throwing.

📊 Suggested error context

 					if (auto* gRasterizer = (*inputArray)[fill][cull][depth][scissor]) {
 						D3D11_RASTERIZER_DESC desc{};
 						gRasterizer->GetDesc(&desc);

 						GetUpdatedRasterDesc(desc, cascadeDescriptors[cascade]);

-						DX::ThrowIfFailed(globals::d3d::device->CreateRasterizerState(&desc, &shadowmapRasterStates[cascade][fill][cull][depth][scissor]));
+						auto hr = globals::d3d::device->CreateRasterizerState(&desc, &shadowmapRasterStates[cascade][fill][cull][depth][scissor]);
+						if (FAILED(hr)) {
+							logger::error("Failed to create rasterizer state for cascade {} at [{}][{}][{}][{}]: {:X}", cascade, fill, cull, depth, scissor, static_cast<uint32_t>(hr));
+							DX::ThrowIfFailed(hr);
+						}
 					}

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee84fac and 7773b56.

📒 Files selected for processing (2)

• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp
• src/EngineFixes/ShadowmapCascadeRasterizerFix.h

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/EngineFixes/ShadowmapCascadeRasterizerFix.h
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/EngineFixes/ShadowmapCascadeRasterizerFix.h
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp

**/*

⚙️ CodeRabbit configuration file

**/*: When reviewing PRs, please provide suggestions for:

1. Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
   if the existing title does not describe the code changes):
   Format: type(scope): description
   Length: 50 characters limit for title, 72 for body
   Style: lowercase description, no ending period
   Examples:

   • feat(vr): add cross-eye sampling
   • fix(water): resolve flowmap bug
   • docs: update shader documentation

2. Issue References (if PR fixes bugs or implements features):
   Suggest adding appropriate GitHub keywords:

   • "Fixes #123" or "Closes #123" for bug fixes
   • "Implements #123" or "Addresses #123" for features
   • "Related to #123" for partial implementations

Otherwise, use your standard review approach focusing on code quality.

Files:

• src/EngineFixes/ShadowmapCascadeRasterizerFix.h
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp

🧠 Learnings (2)

📚 Learning: 2025-10-02T14:20:33.454Z

Learnt from: ThePagi
Repo: doodlum/skyrim-community-shaders PR: 1369
File: src/Features/SnowCover.cpp:515-515
Timestamp: 2025-10-02T14:20:33.454Z
Learning: In the Community Shaders codebase (skyrim-community-shaders repository), hardcoded shader resource slot numbers are used directly in code rather than being defined as named constants. This is the established convention and should not be flagged as an issue.

Applied to files:

• src/EngineFixes/ShadowmapCascadeRasterizerFix.h

📚 Learning: 2025-08-17T18:37:35.839Z

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Avoid GPU register/buffer conflicts in HLSL; verify register usage (e.g., with hlslkit buffer scanning)

Applied to files:

• src/EngineFixes/ShadowmapCascadeRasterizerFix.h
• src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Validate shader compilation (Flatrim, .github/configs/shader-validation.yaml)
• GitHub Check: Validate shader compilation (VR, .github/configs/shader-validation-vr.yaml)
• GitHub Check: Build plugin and addons
• GitHub Check: Run Shader Unit Tests

🔇 Additional comments (2)

src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp (2)

11-39: Document or enforce single-threaded execution for cascade state management.

The thunk uses static variables (cascade, initialized) without synchronization. While shadow rendering in game engines typically runs on a single render thread, this should be explicitly documented to prevent future issues. Either add a comment stating this is single-threaded, or implement synchronization if concurrent calls are possible.

---

3-9: Check RelocationID form for VR runtime support.

The code uses the 2-argument form of RelocationID (e.g., RelocationID(101495, 108489)), which only supports SE/AE. If VR is a supported runtime for this plugin, these should be updated to the 3-argument form with VR IDs (e.g., RelocationID(id_se, id_ae, id_vr)). The specific ID numbers require verification against the Address Library databases (SKSE Address Library for SE/AE, VR Address Library for VR).

[doodlum]

Looks good.
Shadows on first person model are bugged.
Please resolve AI comments

[Dawntic]

Looks good. Shadows on first person model are bugged. Please resolve AI comments

I have tweaked some settings but i couldn't re-create your issue to a big degree. There is some minor aliasing but it's less than vanilla and fairly unavoidable without other fixes.
If for some reason your game looks different from the pics I've added above then i would need to see a screen cap of the shadow mask & color buffer.

[davo0411]

@Dawntic @doodlum is this done? does doodlum have any issues still? this is going stale. I want to merge the fixes, they appear very solid.

[Dawntic]

@Dawntic @doodlum is this done? does doodlum have any issues still? this is going stale. I want to merge the fixes, they appear very solid.

Waiting on dood to test it.

[coderabbitai]

🧹 Nitpick comments (1)

package/Shaders/Utility.hlsl (1)

630-632: Minor formatting inconsistency.

The style here doesn't match the rest of the file (e.g., line 633 uses if ( with a space, and other float4 literals use spaces after commas).

Proposed formatting fix

-	if(SharedData::InInterior)
-		shadowColor = float4(0,0,0,0);
+	if (SharedData::InInterior)
+		shadowColor = float4(0, 0, 0, 0);