ci: remove vs2022 from PR checks#2269
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI and reusable actions were simplified to target Visual Studio 2026 only: VS2022 inputs/matrix entries and conditionals were removed, MSVC toolchain selection was hardcoded to v18.0, CMake preset/build-dir references changed from ALL-VS2022 to ALL, and minor input description edits were made. ChangesVS2026 Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 YAMLlint (1.38.0).github/actions/setup-build-environment/action.yaml[Errno 2] No such file or directory: '.github/actions/setup-build-environment/action.yaml' 🔧 Checkov (3.2.525).github/actions/setup-build-environment/action.yaml2026-05-02 22:25:52,705 [MainThread ] [ERROR] Template file not found: .github/actions/setup-build-environment/action.yaml ... [truncated 9329 characters] ... setup-build-environment/action.yaml' Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
|
No actionable suggestions for changed features. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/actions/setup-build-environment/action.yaml:
- Around line 7-10: The action declares an input named vs-version but still
hardcodes vsversion: "18.0" and conditionally uses the input elsewhere, causing
inconsistent behavior; either wire the vs-version input into the MSVC setup or
remove the input and any branches that reference it. Fix by mapping the
vs-version input to the correct MSVC/toolset value used by the MSVC setup step
(replace the hardcoded vsversion: "18.0" with a computed value based on
inputs.vs-version and update any conditional that checks vs-version), or remove
the vs-version input and delete the conditional logic that branches on it so the
vsversion remains a single authoritative source. Ensure you update references to
vs-version, vsversion, and the MSVC setup step to use the chosen single approach
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 15c8c1c2-94f6-4d67-9c15-bb256ab25b6b
📒 Files selected for processing (4)
.github/actions/prepare-shaders/action.yml.github/actions/setup-build-environment/action.yaml.github/workflows/_shared-build.yaml.github/workflows/release-build.yaml
💤 Files with no reviewable changes (1)
- .github/workflows/release-build.yaml
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/actions/setup-build-environment/action.yaml (1)
37-42:⚠️ Potential issue | 🟠 MajorCheck the Visual Studio installer exit code explicitly.
Start-Process -Waitonly blocks until the child process exits; it does not populate the exit code. You must use-PassThruto get theProcessobject and access itsExitCodeproperty. In this flow, a failed Build Tools install can silently proceed and only surface later as a misleading MSVC setup/build failure.Suggested fix
- Start-Process -FilePath $installerPath -ArgumentList ` + $installer = Start-Process -FilePath $installerPath -ArgumentList ` "--quiet", "--wait", "--norestart", "--nocache", ` "--add", "Microsoft.VisualStudio.Workload.VCTools", ` "--add", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", ` "--add", "Microsoft.VisualStudio.Component.Windows11SDK.26100" ` - -Wait -NoNewWindow + -Wait -NoNewWindow -PassThru + if ($installer.ExitCode -ne 0) { + throw "Visual Studio Build Tools install failed with exit code $($installer.ExitCode)" + } Remove-Item $installerPath -ErrorAction SilentlyContinue🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/actions/setup-build-environment/action.yaml around lines 37 - 42, The Start-Process call that runs the Visual Studio installer should capture and check the process exit code; change the invocation of Start-Process (the call that uses $installerPath and the argument list adding VisualStudio components) to include -PassThru, store the returned Process object (e.g., $proc) and then inspect $proc.ExitCode after it finishes, and if the ExitCode is non-zero throw/exit with a clear error (so the workflow fails early); ensure this logic surrounds the same Start-Process invocation and uses the same argument list that includes "--add", "Microsoft.VisualStudio.Workload.VCTools", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", and "Microsoft.VisualStudio.Component.Windows11SDK.26100".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/actions/setup-build-environment/action.yaml:
- Around line 37-42: The Start-Process call that runs the Visual Studio
installer should capture and check the process exit code; change the invocation
of Start-Process (the call that uses $installerPath and the argument list adding
VisualStudio components) to include -PassThru, store the returned Process object
(e.g., $proc) and then inspect $proc.ExitCode after it finishes, and if the
ExitCode is non-zero throw/exit with a clear error (so the workflow fails
early); ensure this logic surrounds the same Start-Process invocation and uses
the same argument list that includes "--add",
"Microsoft.VisualStudio.Workload.VCTools",
"Microsoft.VisualStudio.Component.VC.Tools.x86.x64", and
"Microsoft.VisualStudio.Component.Windows11SDK.26100".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 75da4ce4-8ee6-4e79-b809-67f9b8a2b93f
📒 Files selected for processing (2)
.github/actions/setup-build-environment/action.yaml.github/workflows/_shared-build.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/_shared-build.yaml
doodlum
changed the title
3 participants
PR checks fail due to vs2022 failing to run.
Summary by CodeRabbit