revert: "feat(vr): add OpenComposite VR menu"

[alandtse]

Reverts #1880

Summary by CodeRabbit

• Refactor
  • Simplified VR overlay handling system with updated overlay positioning and controller interaction utilities.
  • Removed in-scene overlay rendering pipeline and associated shader modules.
  • Removed VR controller input processing and drag functionality.
  • Removed VR runtime detection module.
  • Restructured overlay state management and visibility logic.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes the in-scene VR overlay rendering system, including associated shaders, input handling, OpenVR detection modules, overlay dragging, and settings UI. It adds new public VR overlay management methods and simplifies the OpenVR detection structure, consolidating wand-pointing utilities into VRUtils.

Changes

Cohort / File(s)	Summary
VR Shader Removal package/Shaders/VR/InSceneOverlay.ps.hlsl, package/Shaders/VR/InSceneOverlay.vs.hlsl	Removed pixel and vertex shader files for in-scene overlay rendering.
VR Core Architecture Refactoring src/Features/VR.h	Removed in-scene rendering resources and related functions; added public overlay management methods (UpdateVROverlayPosition(), EnsureOverlayInitialized(), DestroyOverlay()); simplified OverlayAttachMode enum; refactored OpenVRInfo struct; promoted DetectOpenVRInfo() and IsOpenVRCompatible() to public; updated ComputeWandIntersection() signature.
VR Implementation Removals src/Features/VR/InSceneOverlay.cpp, src/Features/VR/Input.cpp, src/Features/VR/OverlayDrag.cpp, src/Features/VR/SettingsUI.cpp, src/Features/VR/WandPointing.cpp	Removed complete VR subsystem implementations: in-scene overlay rendering (611 lines), input handling (376 lines), overlay drag behavior (405 lines), settings UI (1026 lines), and wand-pointing cursor logic (144 lines).
VR Detection System Removal src/Features/VR/OpenVRDetection.h, src/Features/VR/OpenVRDetection.cpp	Removed OpenVR detection module including VRDetection namespace, runtime type detection, DLL probing, and file metadata gathering (184 lines total).
Utility Functions Consolidation src/Utils/VRUtils.h, src/Utils/VRUtils.cpp	Added overlay transform, input flag, controller color, and wand intersection utility functions; replaced GetIPDFromHMD() with new ComputeWandIntersection() utility; updated matrix conversion implementations (164 lines added).
Integration Point Updates src/Menu.cpp	Added VR overlay initialization via EnsureOverlayInitialized() in Menu::Init() and destruction via DestroyOverlay() in destructor.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• fix(VR): disable hmd menu for incompatible openvr #1309 — Adds OpenVR detection and related detection types that this PR removes.
• feat(vr): add OpenComposite VR menu #1880 — Introduces in-scene VR overlay, input, detection, and related modules that this PR fully removes.
• feat(vr): add imgui support #1296 — Modifies VR classes and utility helpers that this PR refactors.

Suggested reviewers

• doodlum
• jiayev

---

🐰 Shaders fade to dust, old overlays must go,
In-scene dreams dismantled, letting new systems flow,
Wand-pointing retired, detection redrawn,
VR simplified—a cleaner path is born! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 38.89% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: reverting the OpenComposite VR menu feature.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-1880-open_composite

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: cf28c87
Using base ref: cf28c87
Base commit date: 2026-02-15T01:50:45-08:00 (Sunday, February 15, 2026 01:50 AM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@src/Features/VR.h`:
- Around line 430-436: The comment "PRIVATE IMPLEMENTATION" is misleading
because DetectOpenVRInfo() and IsOpenVRCompatible() are declared under public:,
so either change the access specifier to private or update the comment to match
public; decide which is intended and then: if they should be internal, replace
the `public:` keyword with `private:` for the block containing DetectOpenVRInfo
and IsOpenVRCompatible; otherwise, keep `public:` and rename the comment to
"PUBLIC IMPLEMENTATION" (or remove it) so the comment matches the access level
for DetectOpenVRInfo() and IsOpenVRCompatible().

In `@src/Utils/VRUtils.cpp`:
- Around line 156-178: GetControllerDeviceColor currently defines controller
colors (Primary/Secondary/Both) that conflict with the Util::Colors definitions
in VRUtils.h; update GetControllerDeviceColor to use the canonical colors from
Util::Colors (or rename the local constants and add clear documentation if a
different palette is intended) so both device-specific UI and other controller
UI use the same color source; specifically replace the local constexpr ImVec4
Primary/Secondary/Both in GetControllerDeviceColor with references to
Util::Colors::Primary/Secondary/Both (or add a comment and distinct names like
RecordingPrimary if keeping a separate scheme) and ensure any callers of
GetControllerDeviceColor and the Util::Colors consumers render consistently.

🧹 Nitpick comments (1)

src/Features/VR.h (1)

87-99: PR title follows conventional commit format — no changes needed.

The PR title revert: "feat(vr): add OpenComposite VR menu" correctly follows conventional commit format for a revert. Consider adding Reverts #1880`` in the PR description for traceability. As per coding guidelines, using "Reverts #1880" links the revert to the original PR.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Misleading comment: "PRIVATE IMPLEMENTATION" section is actually public.

Line 430 declares public: but line 432 comments // PRIVATE IMPLEMENTATION. The AI summary confirms DetectOpenVRInfo() and IsOpenVRCompatible() were intentionally moved to public. Either update the comment to reflect the actual access level or change to private: if these should remain internal.

Suggested fix

 public:
 	//=============================================================================
-	// PRIVATE IMPLEMENTATION
+	// DETECTION AND COMPATIBILITY
 	//=============================================================================
 
 	void DetectOpenVRInfo();
 	bool IsOpenVRCompatible() const;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	public:
	//=============================================================================
	// PRIVATE HELPERS
	// PRIVATE IMPLEMENTATION
	//=============================================================================
	bool GetGripPressed(bool isLeft, bool isRight) const;
	void ResetComboRecording();
	void ApplyRecordedCombo();
	void DetectOpenVRInfo();
	bool IsOpenVRCompatible() const;
	public:
	//=============================================================================
	// DETECTION AND COMPATIBILITY
	//=============================================================================
	void DetectOpenVRInfo();
	bool IsOpenVRCompatible() const;

🤖 Prompt for AI Agents

In `@src/Features/VR.h` around lines 430 - 436, The comment "PRIVATE
IMPLEMENTATION" is misleading because DetectOpenVRInfo() and
IsOpenVRCompatible() are declared under public:, so either change the access
specifier to private or update the comment to match public; decide which is
intended and then: if they should be internal, replace the `public:` keyword
with `private:` for the block containing DetectOpenVRInfo and
IsOpenVRCompatible; otherwise, keep `public:` and rename the comment to "PUBLIC
IMPLEMENTATION" (or remove it) so the comment matches the access level for
DetectOpenVRInfo() and IsOpenVRCompatible().

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Color definitions here conflict with Util::Colors in VRUtils.h.

GetControllerDeviceColor defines Primary = Green, Secondary = Blue, Both = Purple, but Util::Colors in VRUtils.h (line 28-31) defines Primary = Yellow, Secondary = Blue, Both = Green. Both are used for controller-related UI but will render different colors for the same device type, which could confuse users.

If these are intentionally for different contexts (e.g., DrawButtonCombo vs. device-specific UI), consider documenting that distinction. Otherwise, unify the color schemes.

#!/bin/bash
# Check where GetControllerDeviceColor is used vs Util::Colors
rg -n "GetControllerDeviceColor\|GetControllerPrimaryColor\|GetControllerSecondaryColor\|GetControllerBothColor" --type=cpp --type=hpp -C2

🤖 Prompt for AI Agents

In `@src/Utils/VRUtils.cpp` around lines 156 - 178, GetControllerDeviceColor
currently defines controller colors (Primary/Secondary/Both) that conflict with
the Util::Colors definitions in VRUtils.h; update GetControllerDeviceColor to
use the canonical colors from Util::Colors (or rename the local constants and
add clear documentation if a different palette is intended) so both
device-specific UI and other controller UI use the same color source;
specifically replace the local constexpr ImVec4 Primary/Secondary/Both in
GetControllerDeviceColor with references to Util::Colors::Primary/Secondary/Both
(or add a comment and distinct names like RecordingPrimary if keeping a separate
scheme) and ensure any callers of GetControllerDeviceColor and the Util::Colors
consumers render consistently.

[github-actions]

✅ A pre-release build is available for this PR:
Download