refactor: centralize feature category names

[mvanhorn]

Summary

Replaces all hard-coded category string literals in GetCategory() overrides with constexpr std::string_view constants from a new FeatureCategories namespace.

Changes

• New file: src/FeatureCategories.h - 10 constants (Characters, Display, Grass, Landscape & Textures, Lighting, Materials, Other, Sky, Utility, Water)
• src/Feature.h: Default GetCategory() now returns FeatureCategories::kOther
• 33 feature headers: Each GetCategory() override updated to use the corresponding constant

34 files changed, 35 insertions(+), 34 deletions(-).

Closes #1265

This contribution was developed with AI assistance (Claude Code).

Summary by CodeRabbit

• Refactor
  • Centralized feature category definitions for improved code maintainability and consistency across the system.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR centralizes feature category names from hardcoded string literals scattered across 34 feature implementations into a dedicated FeatureCategories namespace with inline constexpr std::string_view constants, then updates all features and the base Feature class to reference these centralized constants.

Changes

Cohort / File(s)	Summary
FeatureCategories Centralization src/FeatureCategories.h	New header defining 10 category constants (kCharacters, kDisplay, kGrass, kLandscapeAndTextures, kLighting, kMaterials, kOther, kSky, kUtility, kWater) as inline constexpr std::string_view values.
Base Feature Update src/Feature.h	Added #include FeatureCategories.h and updated default GetCategory() implementation to return FeatureCategories::kOther instead of string literal "Other".
Lighting Features src/Features/ExponentialHeightFog.h, src/Features/IBL.h, src/Features/InteriorSun.h, src/Features/InverseSquareLighting.h, src/Features/LightLimitFix.h, src/Features/LinearLighting.h, src/Features/ScreenSpaceGI.h, src/Features/ScreenSpaceShadows.h, src/Features/Skylighting.h, src/Features/VolumetricLighting.h, src/Features/VolumetricShadows.h	Updated GetCategory() overrides to return FeatureCategories::kLighting instead of string literal "Lighting".
Material Features src/Features/DynamicCubemaps.h, src/Features/ExtendedMaterials.h, src/Features/ExtendedTranslucency.h	Updated GetCategory() overrides to return FeatureCategories::kMaterials instead of string literal "Materials".
Landscape & Terrain Features src/Features/LODBlending.h, src/Features/TerrainBlending.h, src/Features/TerrainHelper.h, src/Features/TerrainShadows.h, src/Features/TerrainVariation.h	Updated GetCategory() overrides to return FeatureCategories::kLandscapeAndTextures instead of string literal "Landscape & Textures".
Water Features src/Features/UnifiedWater.h, src/Features/WaterEffects.h, src/Features/WetnessEffects.h	Updated GetCategory() overrides to return FeatureCategories::kWater instead of string literal "Water".
Sky Features src/Features/CloudShadows.h, src/Features/SkySync.h	Updated GetCategory() overrides to return FeatureCategories::kSky instead of string literal "Sky".
Character Features src/Features/HairSpecular.h, src/Features/SubsurfaceScattering.h	Updated GetCategory() overrides to return FeatureCategories::kCharacters instead of string literal "Characters".
Grass Features src/Features/GrassCollision.h, src/Features/GrassLighting.h	Updated GetCategory() overrides to return FeatureCategories::kGrass instead of string literal "Grass".
Utility Features src/Features/OverlayFeature.h, src/Features/RenderDoc.h, src/Features/VR.h, src/Features/WeatherEditor.h	Updated GetCategory() overrides to return FeatureCategories::kUtility instead of string literal "Utility".
Display Feature src/Features/Upscaling.h	Updated GetCategory() override to return FeatureCategories::kDisplay instead of string literal "Display".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• PR #1155: Introduced the category string literals that this PR centralizes into constants and references across all features.
• PR #1178: Implements menu categorization using Feature::GetCategory(); these centralized constants ensure consistent categorization throughout the codebase.
• PR #1713: Previously reclassified several features into different categories; this PR ensures those category labels are now maintained via centralized constants.

Suggested reviewers

• davo0411
• alandtse
• jiayev

Poem

🐰 String literals scattered far and wide,
Now gather 'round with constants as their guide,
A tidy namespace keeps them safe and sound,
No typos lurk where centralization's found! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 2.13% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and concisely summarizes the main change: centralizing feature category names into a new FeatureCategories.h header file.
Linked Issues check	✅ Passed	The PR successfully implements all coding requirements from issue #1265: creates a FeatureCategories namespace with centralized constexpr string_view constants, updates Feature.h default implementation, and modifies all 33 feature headers to use these constants instead of hardcoded strings.
Out of Scope Changes check	✅ Passed	All changes are directly related to centralizing feature category names as specified in issue #1265; no out-of-scope modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

🧹 Nitpick comments (1)

src/FeatureCategories.h (1)

6-15: Add kPostProcessing to complete category centralization.

"Post-Processing" still exists as a hardcoded category in menu/icon paths, so this header is not yet a full single source of truth for category names.

Suggested diff

 namespace FeatureCategories
 {
 	inline constexpr std::string_view kCharacters = "Characters";
 	inline constexpr std::string_view kDisplay = "Display";
 	inline constexpr std::string_view kGrass = "Grass";
 	inline constexpr std::string_view kLandscapeAndTextures = "Landscape & Textures";
 	inline constexpr std::string_view kLighting = "Lighting";
 	inline constexpr std::string_view kMaterials = "Materials";
 	inline constexpr std::string_view kOther = "Other";
+	inline constexpr std::string_view kPostProcessing = "Post-Processing";
 	inline constexpr std::string_view kSky = "Sky";
 	inline constexpr std::string_view kUtility = "Utility";
 	inline constexpr std::string_view kWater = "Water";
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/FeatureCategories.h` around lines 6 - 15, Add a centralized constant for
the missing Post-Processing category: define inline constexpr std::string_view
kPostProcessing = "Post-Processing" alongside the other constants in
FeatureCategories (the existing kCharacters, kDisplay, kGrass, etc.), and
replace any remaining hardcoded "Post-Processing" occurrences (e.g., menu or
icon path usages) to reference FeatureCategories::kPostProcessing so the header
becomes the single source of truth for category names.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/FeatureCategories.h`:
- Around line 6-15: Add a centralized constant for the missing Post-Processing
category: define inline constexpr std::string_view kPostProcessing =
"Post-Processing" alongside the other constants in FeatureCategories (the
existing kCharacters, kDisplay, kGrass, etc.), and replace any remaining
hardcoded "Post-Processing" occurrences (e.g., menu or icon path usages) to
reference FeatureCategories::kPostProcessing so the header becomes the single
source of truth for category names.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 212ac0a9-cec6-4d64-86d2-b62ea1dbca17

📥 Commits

Reviewing files that changed from the base of the PR and between 3616a17 and 3dc1d6d.

📒 Files selected for processing (35)

• src/Feature.h
• src/FeatureCategories.h
• src/Features/CloudShadows.h
• src/Features/DynamicCubemaps.h
• src/Features/ExponentialHeightFog.h
• src/Features/ExtendedMaterials.h
• src/Features/ExtendedTranslucency.h
• src/Features/GrassCollision.h
• src/Features/GrassLighting.h
• src/Features/HairSpecular.h
• src/Features/IBL.h
• src/Features/InteriorSun.h
• src/Features/InverseSquareLighting.h
• src/Features/LODBlending.h
• src/Features/LightLimitFix.h
• src/Features/LinearLighting.h
• src/Features/OverlayFeature.h
• src/Features/RenderDoc.h
• src/Features/ScreenSpaceGI.h
• src/Features/ScreenSpaceShadows.h
• src/Features/SkySync.h
• src/Features/Skylighting.h
• src/Features/SubsurfaceScattering.h
• src/Features/TerrainBlending.h
• src/Features/TerrainHelper.h
• src/Features/TerrainShadows.h
• src/Features/TerrainVariation.h
• src/Features/UnifiedWater.h
• src/Features/Upscaling.h
• src/Features/VR.h
• src/Features/VolumetricLighting.h
• src/Features/VolumetricShadows.h
• src/Features/WaterEffects.h
• src/Features/WeatherEditor.h
• src/Features/WetnessEffects.h

[github-actions]

✅ A pre-release build is available for this PR:
Download

[alandtse]

Thanks!