chore(llf): remove LightsVisualisationMode settings loading

[doodlum]

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Removed Contact Shadows and Lights Visualization Mode settings from the Light Limit Fix feature.

• Refactor

  • Simplified internal settings management for the Light Limit Fix feature.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request removes public serializable settings from the LightLimitFix feature, including the Settings nested type definition and the EnableContactShadows field. LoadSettings and SaveSettings methods are converted to no-ops, and settings restoration logic is eliminated.

Changes

Cohort / File(s)	Summary
LightLimitFix Settings Removal src/Features/LightLimitFix.h, src/Features/LightLimitFix.cpp	Removed EnableContactShadows boolean field from Settings struct, eliminated public Settings type serialization definition, converted LoadSettings and SaveSettings to no-op functions, and removed settings reset logic in RestoreDefaultSettings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix(llf): fix some llf issues #1467: Removes EnableContactShadows setting and contact-shadow functionality from LightLimitFix feature.
• refactor(UI): move light limit visualization into debug #1619: Modifies LightLimitFix::Settings structure by removing public visualization-related fields from the settings interface.
• feat(llf): remove particle lights #1495: Modifies LightLimitFix settings/API by changing or removing Settings type and its fields.

Suggested reviewers

• alandtse

Poem

🐰 A rabbit's burrow, once cluttered with care,
Now streamlined and tidy, with settings stripped bare,
No shadows to ponder, no switches to flip,
Just simple, clean code—a most satisfying tip! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: removing LightsVisualisationMode settings loading, which is evident from the removal of the NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT macro and the disabling of LoadSettings/SaveSettings functionality.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch llf-no-settings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 3c02eac
Using base ref: 3c02eac
Base commit date: 2026-02-07T03:00:26Z (Saturday, February 07, 2026 03:00 AM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/Features/LightLimitFix.cpp`:
- Around line 176-178: RestoreDefaultSettings currently does nothing so runtime
'settings' isn't reset when the user chooses "restore defaults"; update
RestoreDefaultSettings (in class LightLimitFix) to reinitialize the settings
struct to its default state (the same defaults used when settings were first
constructed), ensuring fields like EnableLightsVisualisation and
LightsVisualisationMode are set back to their default values; locate the
settings instance used by LightLimitFix and assign a fresh/default-constructed
settings object or explicitly set each default field to match initial defaults
so UI changes are reverted at runtime.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

RestoreDefaultSettings may need to re-initialize settings to its defaults.

With LoadSettings/SaveSettings removed, RestoreDefaultSettings is the only explicit reset path. If a user changes EnableLightsVisualisation or LightsVisualisationMode via the UI (lines 25, 32) and then triggers a "restore defaults" action, this empty body will silently do nothing—leaving the runtime settings struct in its modified state.

Consider resetting the struct here:

Suggested fix

 void LightLimitFix::RestoreDefaultSettings()
 {
+	settings = {};
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	void LightLimitFix::RestoreDefaultSettings()
	{
	settings = {};
	}
	void LightLimitFix::RestoreDefaultSettings()
	{
	settings = {};
	}

🤖 Prompt for AI Agents

In `@src/Features/LightLimitFix.cpp` around lines 176 - 178,
RestoreDefaultSettings currently does nothing so runtime 'settings' isn't reset
when the user chooses "restore defaults"; update RestoreDefaultSettings (in
class LightLimitFix) to reinitialize the settings struct to its default state
(the same defaults used when settings were first constructed), ensuring fields
like EnableLightsVisualisation and LightsVisualisationMode are set back to their
default values; locate the settings instance used by LightLimitFix and assign a
fresh/default-constructed settings object or explicitly set each default field
to match initial defaults so UI changes are reverted at runtime.

[github-actions]

✅ A pre-release build is available for this PR:
Download