feat(weather editor): block editor access in loading screens

[SkrubbySkrubInAShrub]

Prevents the user from opening the editor when in the main menu or when loading the game.
Could prevent other unforseen behaviour too.

Summary by CodeRabbit

• Bug Fixes
  • Weather Editor button is now disabled when the player lacks a valid game context
  • Editor window automatically closes if the player loses a valid game cell context
  • Weather Editor hotkey respects active player state before toggling

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request adds defensive runtime guards to the Weather Editor feature across three key UI integration points. It ensures the editor only operates when the player has a valid active cell by adding null/validity checks in hotkey handling, rendering paths, and the overlay controller, with auto-close logic when the player loses valid context.

Changes

Cohort / File(s)	Summary
Weather Editor UI Safety Guards src/Features/WeatherEditor.cpp, src/Menu.cpp, src/Menu/OverlayRenderer.cpp	Added runtime validation checks to ensure the weather editor operates only when player and active cell exist. DrawSettings button state now reflects cell validity; RenderWeatherDetailsWindow and DrawOverlay return early without valid context; hotkey toggle guards with null checks; OverlayRenderer auto-closes editor when player loses valid cell.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly Related PRs

• feat(weather editor): toggle hotkey #1856: Modifies Weather Editor hotkey and overlay rendering logic with similar editor state and toggle handling patterns.
• chore(weather-editor): merge weather picker and editor #1845: Direct modifications to the same WeatherEditor, Menu, and OverlayRenderer components for Weather Editor integration.

Suggested Reviewers

• davo0411
• alandtse

Poem

🐰 A weather editor, once wild and free,
Now checks if a player exists, don't you see?
Guards and early returns keep the chaos at bay,
So when cells are missing, the editor won't play! ⛈️

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev
Title check	✅ Passed	The title accurately summarizes the main change: preventing weather editor access during loading screens and the main menu by adding runtime guards for player/cell validity checks.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: b3243f3
Using base ref: b3243f3
Base commit date: 2026-02-13T10:38:46+10:00 (Friday, February 13, 2026 10:38 AM)
No actionable suggestions for changed features.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Menu.cpp (1)

1-1: ⚠️ Potential issue | 🟡 Minor

PR title has a typo: "acces" → "access".

Per coding guidelines, the conventional commit title should be:
feat(weather-editor): block editor access in loading screens

Also, if this PR addresses a specific issue, consider adding Fixes #<issue> or Closes #<issue> to the description. As per coding guidelines on conventional commits and issue references.

[SkrubbySkrubInAShrub]

my PR has a typo 😞

[github-actions]

✅ A pre-release build is available for this PR:
Download