fix(VR): fix Shadowmap Cascade Rasterizer

[alandtse]

Needed for #1690

Summary by CodeRabbit

• Improvements
  • Shadow cascade count is now read dynamically from the game's settings (configurable), improving consistency and reliability of shadow rendering.
  • Initial cascade handling is more robust to out-of-range values.
  • VR compatibility requirement raised to library version 0.200.0 for updated runtime support.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

Install and runtime logic for shadowmap cascade handling was changed to source the cascade count from a game setting and to use an extended relocation when installing the render-cascade thunk; a templated game-setting accessor was added; VR address library minimum version was raised.

Changes

Cohort / File(s)	Summary
Shadowmap Cascade Rasterizer src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp, src/EngineFixes/ShadowmapCascadeRasterizerFix.h	Install() now supplies an extended relocation parameter to the render-cascade thunk; cascade count initialization reads from a game setting (iNumSplits:Display) via the new Settings map; initial cascade backup/clamping logic adjusted to use the runtime value.
Game Settings Utility src/Utils/GameSetting.h	Added template <typename T> GetGameSettingValue(const std::string&, const GameSetting&) to unify reading settings from INI or from an offset in memory with type-aware casting and fallback/default handling.
Plugin version check src/XSEPlugin.cpp	Raised required VR address library version in Load() from 0.193.0 to 0.200.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: add shadowmap rasterizer override #1690: Updates to ShadowmapCascadeRasterizerFix implementation and related cascade/count handling that overlap with this PR's changes.

Suggested reviewers

• davo0411
• doodlum

Poem

🐇 I hopped through code where cascades play,
I fetched the setting, no hard‑coded way.
Thunk got longer, offsets neat,
Types resolved, defaults to greet,
Shadow hops now dance at full display.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title addresses VR-specific fixes to the Shadowmap Cascade Rasterizer, which aligns with the main changes involving cascade count initialization and relocation adjustments.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: a185c8d
Using base ref: a185c8d
Base commit date: 2026-02-15T20:06:09-08:00 (Sunday, February 15, 2026 08:06 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/EngineFixes/ShadowmapCascadeRasterizerFix.h`:
- Around line 52-58: The Settings entry for "iNumSplits:Display" exposes a
GameSetting with maxValue 4 which contradicts the code's maxCascades = 3 and
causes the UI slider to allow 4 while runtime clamps to 3; update the
GameSetting maxValue to 3 (or alternatively make maxCascades dynamic and derive
the GameSetting maxValue from it) so the ImGui control and runtime behavior
match—look for the Settings initializer and the "iNumSplits:Display" GameSetting
in ShadowmapCascadeRasterizerFix (and any use of maxCascades) and make the
change there.

🧹 Nitpick comments (2)

src/EngineFixes/ShadowmapCascadeRasterizerFix.cpp (1)

10-10: Potential negative-to-unsigned wrap on numCascades.

GetGameSettingValue<std::int32_t> can return a negative value (e.g., if someone sets iNumSplits:Display=-1 in the INI). The static_cast<uint> would wrap it to a very large number. While the std::min clamp on line 22 would eventually correct it, consider validating/clamping here to avoid a transiently invalid numCascades.

Proposed fix

-	numCascades = static_cast<uint>(Util::GetGameSettingValue<std::int32_t>("iNumSplits:Display", Settings.at("iNumSplits:Display")));
+	numCascades = static_cast<uint>(std::clamp(Util::GetGameSettingValue<std::int32_t>("iNumSplits:Display", Settings.at("iNumSplits:Display")), 1, static_cast<std::int32_t>(maxCascades)));

src/Utils/GameSetting.h (1)

118-149: std::get<T> on line 140 will throw std::bad_variant_access if T doesn't match the default value's active type.

If a caller instantiates GetGameSettingValue<float> but the GameSetting::defaultValue was initialized with an int, the fallback path throws. Consider using std::visit or std::get_if with a clear error message, or document the requirement that T must match the variant's active type.

Proposed safer fallback

-			auto defaultValue = std::get<T>(settingData.defaultValue);
-			logger::warn("GetGameSettingValue: '{}' not found in INI or GameSettingCollection, using default: {}", settingName, defaultValue);
-			return defaultValue;
+			if (auto* pDefault = std::get_if<T>(&settingData.defaultValue)) {
+				logger::warn("GetGameSettingValue: '{}' not found in INI or GameSettingCollection, using default: {}", settingName, *pDefault);
+				return *pDefault;
+			}
+			logger::error("GetGameSettingValue: '{}' default value type mismatch", settingName);
+			return T{};

[github-actions]

✅ A pre-release build is available for this PR:
Download