fix(weather editor): sync UI for full transition

[SkrubbySkrubInAShrub]

uses inTransition bool introduced in #1820 to properly take control of the feature UI when a transition occurs.
Previously the editor would release control of the UI the moment a transition starts to a weather without an override.
However user control was not yet possible as the system is still lerping the variables.
Now the UI control will only be released once the transition has finished fully.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced detection of weather variable transitions to ensure weather-controlled UI controls (sliders, checkboxes) properly lock during active transitions, preventing accidental modifications and displaying appropriate prompts for Weather Editor access.
  • Improved feature refresh timing to immediately update settings when weather transitions complete, enabling more responsive system behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce transition-state awareness to the weather-control system. New public methods in WeatherVariableRegistry expose whether variables are mid-transition at multiple levels. UI.cpp's IsWeatherControlled now returns early if a feature variable is transitioning. WeatherManager's update logic is modified to also refresh features when transitions complete.

Changes

Cohort / File(s)	Summary
Weather Variable Registry src/WeatherVariableRegistry.h	Added four new public transition-query methods: IsInTransition() on IWeatherVariable and WeatherVariable, IsVariableInTransition() on FeatureWeatherRegistry, and IsFeatureVariableInTransition() on GlobalWeatherRegistry to expose per-variable, per-feature, and global-level transition state.
Weather-Controlled UI Logic src/Utils/UI.cpp	Updated IsWeatherControlled to include an early return condition that treats a feature as weather-controlled if its variable is mid-transition, activating weather-control paths earlier in the rendering pipeline.
Feature Update Timing src/WeatherManager.cpp	Modified UpdateFeatures conditional logic to refresh features not only on weather or lerp factor changes, but also when a transition completes (lerp crosses 1.0), tightening control flow for transition completion.

Sequence Diagram(s)

sequenceDiagram
    participant UI as UI Layer
    participant Mgr as WeatherManager
    participant Reg as FeatureWeatherRegistry
    
    Mgr->>Reg: Start feature transition<br/>(lerp: 0.0)
    Reg->>Reg: Set inTransition = true
    
    UI->>Reg: IsFeatureVariableInTransition()?
    Reg-->>UI: true (mid-transition)
    UI->>UI: Render weather-controlled state<br/>(e.g., disable edits, prompt)
    
    loop During Transition
        Mgr->>Mgr: Lerp update (0.0 → 1.0)
        Mgr->>Reg: UpdateFeatures()
        Reg-->>Mgr: Features updated
    end
    
    Mgr->>Reg: Transition completes<br/>(lerp ≥ 1.0)
    Reg->>Reg: Set inTransition = false
    Mgr->>Reg: UpdateFeatures(transitionEnding)
    Reg-->>Mgr: Final feature refresh
    
    UI->>Reg: IsFeatureVariableInTransition()?
    Reg-->>UI: false (complete)
    UI->>UI: Resume normal rendering

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat(weather): per-feature settings rework, main feature lock #1704: Modifies Util::WeatherUI::IsWeatherControlled and weather-variable transition query APIs with similar weather-aware UI control flow.
• fix(weather editor): handling of weathers without overrides #1773: Modifies weather variable/feature transition handling in WeatherVariableRegistry and WeatherManager's UpdateFeatures logic.
• chore(ibl): add per weather settings #1703: Adds per-variable transition queries for weather-controlled UI controls, integrating transition state awareness into UI rendering.

Suggested reviewers

• davo0411

Poem

🐰 With whiskers twitching at transitions true,
Weather states now flow through every hue,
Mid-lerp the UI knows to wait and see,
Till transitions dance to symphony! ✨🌦️

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(weather editor): control UI for full transition' accurately describes the main change: retaining UI control during the full weather transition rather than releasing it early.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: da2ce6d
Using base ref: da2ce6d
Base commit date: 2026-02-05T20:19:00-08:00 (Thursday, February 05, 2026 08:19 PM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download