feat(weather editor): improve weather picker UI and functionality

[SkrubbySkrubInAShrub]

Improve the merged weather picker code with better UX.

Changes:

• Rework weather status panel with always-visible progress bar
• Add Lock/Unlock Weather toggle button
• Simplify Reset Weather button UI
• Use ForceWeather for instant transitions
• remove collapsible behavior

Summary by CodeRabbit

• New Features

  • New pre-processing step and standalone Weather Details window with configurable open state.
  • Enhanced weather controls UI with dynamic colored flag chips, improved filtering and re-sorting.

• Improvements

  • Reworked editor flow with stronger weather-lock enforcement, clearer status panel, always-visible transition progress, auto-opening overlay, richer multi-color weather names and expanded tooltips.

• Documentation

  • Expanded public API docs for new rendering helpers.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a public Prepass() to WeatherEditor to centralize weather-lock enforcement and pre-render updates, reorganizes weather UI into discrete rendering helpers (details, controls, info), updates overlay/details-window open behavior, refactors weather naming/color/flag logic, and revises filtering/sorting and many UI texts/tooltips.

Changes

Cohort / File(s)	Summary
Header API src/Features/WeatherEditor.h	Added virtual void Prepass() override; plus public rendering helpers: RenderWeatherDetailsWindow(bool* open), DisplayWeatherInfo(...), RenderCoreWeatherDetails(...), RenderFeatureWeatherAnalysis(), RenderWeatherControls(RE::Sky*), RenderWeatherInformationDisplay(...). Doc blocks expanded.
Rendering flow & state src/Features/WeatherEditor.cpp	Added Prepass() enforcing locked weather and updating internal forced state; DrawSettings() now calls Prepass() first; picker logic split into prepass + updated DrawWeatherPickerSection(); overlay/window open tracking moved to s_prevOverlayVisible to auto-open details window.
Weather details & overlay window src/Features/WeatherEditor.cpp	RenderWeatherDetailsWindow now accepts/uses open flag in ImGui::Begin; DrawWeatherStatusPanel() always shows transition progress and explicit custom/default messaging; overlay behavior adjusted to auto-open details when visibility changes.
Color, naming & flag mapping src/Features/WeatherEditor.cpp	GetWeatherTypeColor() uses priorityOrder vector; added GetWeatherFlagColorByName() and improved GetWeatherFlagNames() (Unknown(...) handling); RenderMultiColorWeatherName() renders multi-color chips and treats empty/single-flag as single-color; GetDisplayName() simplified.
Controls, filtering & sorting src/Features/WeatherEditor.cpp	RenderWeatherControls() updated for dynamic colored flag chips, new filter UI/layout; UpdateFilteredWeathers() rebuilds and re-sorts s_filteredWeathers with updated comparator; checkbox sizing and tooltip copy adjusted.
Misc UI tweaks & includes src/Features/WeatherEditor.cpp	UI text/tooltip updates, spacing/header tweaks, small refactors in rendering order and flow; include ordering adjusted (moved EditorWindow include).

Sequence Diagram(s)

sequenceDiagram
    participant DrawSettings as DrawSettings
    participant Prepass as Prepass
    participant Sky as Sky
    participant DrawPicker as DrawPicker
    participant ImGui as ImGui
    participant WeatherDetailsWindow as WeatherDetailsWindow

    DrawSettings->>Prepass: call Prepass()
    Prepass->>Sky: enforce locked/forced weather
    Prepass-->>DrawSettings: update internal state

    DrawSettings->>DrawPicker: render picker UI (header, overlay toggle)
    DrawPicker->>ImGui: render widgets & tooltips
    ImGui-->>DrawPicker: user interactions

    DrawPicker->>WeatherDetailsWindow: RenderWeatherDetailsWindow(bool* open)
    WeatherDetailsWindow->>ImGui: ImGui::Begin/End with open flag
    ImGui-->>WeatherDetailsWindow: window open/close events

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• chore(weather-editor): merge weather picker and editor #1845 — Directly overlaps WeatherEditor refactor and Merge of WeatherPicker into WeatherEditor: similar APIs and overlay integration.
• feat(weather editor): toggle hotkey #1856 — Overlaps overlay/details open behavior and moving WeatherEditor drawing into overlay path.
• feat(weather): per-feature settings rework, main feature lock #1704 — Related WeatherEditor UI/flow changes and navigation/locking features.

Suggested reviewers

• davo0411
• alandtse

Poem

🐇 I nudged the clouds to hold in place,
A Prepass hug to steady space.
Chips of colour, windows swing,
The overlay hums — small things sing,
A rabbit smiles: the sky finds grace.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 7.69% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main changes: refactoring the weather picker UI with improved UX, redesigned status panel, new lock/unlock functionality, and simplified buttons.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: b3243f3
Using base ref: b3243f3
Base commit date: 2026-02-13T10:38:46+10:00 (Friday, February 13, 2026 10:38 AM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/Features/WeatherEditor.cpp`:
- Around line 297-314: The priorityColors vector currently lists Pleasant first
so the loop (for(const auto& [flag, color] : priorityColors) {
if(weather->data.flags.any(flag)) ... }) gives Pleasant highest precedence,
which contradicts the doc comment; reorder the entries in priorityColors to
match the documented priority (Rain > Snow > PermAurora > AuroraFollowsSun >
Cloudy > Pleasant) so that RE::TESWeather::WeatherDataFlag::kRainy is checked
first and RE::TESWeather::WeatherDataFlag::kPleasant last, preserving the
special-case return of theme.StatusPalette.SuccessColor for kPleasant.

🧹 Nitpick comments (3)

src/Features/WeatherEditor.cpp (3)

224-241: Extract the repeated transition-active check into a local variable.

The condition (currentWeathers.lastWeather && currentWeathers.lerpFactor < 1.0f) is evaluated four times. A local bool would improve readability and prevent subtle divergence if the condition changes.

♻️ Suggested simplification

-		// Always show progress bar
-		float displayPct = (currentWeathers.lastWeather && currentWeathers.lerpFactor < 1.0f) ?
-		                       currentWeathers.lerpFactor :
-		                       1.0f;
-
-		// Show background color when transition is complete
-		if (!(currentWeathers.lastWeather && currentWeathers.lerpFactor < 1.0f)) {
-			ImGui::PushStyleColor(ImGuiCol_PlotHistogram, ImGui::GetStyleColorVec4(ImGuiCol_FrameBg));
-		}
-
-		ImGui::ProgressBar(displayPct, ImVec2(-1, 0),
-			(currentWeathers.lastWeather && currentWeathers.lerpFactor < 1.0f) ?
-				std::format("Transition: {:.1f}%", currentWeathers.lerpFactor * 100.0f).c_str() :
-				"");
-
-		if (!(currentWeathers.lastWeather && currentWeathers.lerpFactor < 1.0f)) {
-			ImGui::PopStyleColor();
-		}
+		const bool isTransitioning = currentWeathers.lastWeather && currentWeathers.lerpFactor < 1.0f;
+		float displayPct = isTransitioning ? currentWeathers.lerpFactor : 1.0f;
+
+		if (!isTransitioning) {
+			ImGui::PushStyleColor(ImGuiCol_PlotHistogram, ImGui::GetStyleColorVec4(ImGuiCol_FrameBg));
+		}
+
+		ImGui::ProgressBar(displayPct, ImVec2(-1, 0),
+			isTransitioning ?
+				std::format("Transition: {:.1f}%", currentWeathers.lerpFactor * 100.0f).c_str() :
+				"");
+
+		if (!isTransitioning) {
+			ImGui::PopStyleColor();
+		}

---

951-951: Redundant condition in the check.

flagNames.size() == 1 already covers the (flagNames.size() == 1 && flagNames[0] == "None") case. The third clause is dead code.

♻️ Simplified condition

-	if (flagNames.empty() || flagNames.size() == 1 || (flagNames.size() == 1 && flagNames[0] == "None")) {
+	if (flagNames.size() <= 1) {

---

1002-1022: Weather flag colors are duplicated between GetWeatherTypeColor and GetWeatherFlagColor.

The same color values (e.g., ImVec4(0.4f, 0.7f, 1.0f, 1.0f) for Rainy) are defined in both the priorityColors vector (line 297) and this switch statement. If a color changes in one place but not the other, they'll silently diverge. Consider having one delegate to the other.

♻️ Example: Make GetWeatherTypeColor use GetWeatherFlagColor

 // In GetWeatherTypeColor, replace the static vector with:
 static const std::vector<RE::TESWeather::WeatherDataFlag> priorityOrder = {
-    // ... pairs with colors ...
+    RE::TESWeather::WeatherDataFlag::kPleasant,
+    RE::TESWeather::WeatherDataFlag::kCloudy,
+    RE::TESWeather::WeatherDataFlag::kRainy,
+    RE::TESWeather::WeatherDataFlag::kSnow,
+    RE::TESWeather::WeatherDataFlag::kPermAurora,
+    RE::TESWeather::WeatherDataFlag::kAuroraFollowsSun,
 };
 
-for (const auto& [flag, color] : priorityColors) {
+for (const auto& flag : priorityOrder) {
     if (weather->data.flags.any(flag)) {
-        if (flag == RE::TESWeather::WeatherDataFlag::kPleasant) {
-            return theme.StatusPalette.SuccessColor;
-        }
-        return color;
+        return GetWeatherFlagColor(flag);  // Single source of truth
     }
 }

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Features/WeatherEditor.cpp (1)

1043-1054: ⚠️ Potential issue | 🟡 Minor

Null-pointer dereference if called with a null weather.

GetDisplayName removed its null guard. Line 1045 will dereference weather unconditionally. While current callers filter nulls, this is a public helper and any future (or external) caller passing nullptr will crash.

🛡️ Proposed fix

 std::string WeatherEditor::GetDisplayName(const RE::TESWeather* weather)
 {
+	if (!weather) {
+		return "Unknown";
+	}
 	const char* name = weather->GetName();

🧹 Nitpick comments (2)

src/Features/WeatherEditor.cpp (2)

402-404: Float-to-uint8 truncation loses precision — use rounding.

static_cast<std::uint8_t>(1.0f * 255.0f) yields 254 (truncation of 254.999…) instead of 255. This means picking pure white/max in the color picker won't store the expected max value.

♻️ Proposed fix — round before casting

-		weather->data.lightningColor.red = static_cast<std::uint8_t>(lightningColor[0] * 255.0f);
-		weather->data.lightningColor.green = static_cast<std::uint8_t>(lightningColor[1] * 255.0f);
-		weather->data.lightningColor.blue = static_cast<std::uint8_t>(lightningColor[2] * 255.0f);
+		weather->data.lightningColor.red = static_cast<std::uint8_t>(lightningColor[0] * 255.0f + 0.5f);
+		weather->data.lightningColor.green = static_cast<std::uint8_t>(lightningColor[1] * 255.0f + 0.5f);
+		weather->data.lightningColor.blue = static_cast<std::uint8_t>(lightningColor[2] * 255.0f + 0.5f);

---

560-563: checkboxWidth estimate of 80px may be too narrow for "Aurora Sun" label.

The label "Aurora Sun" plus checkbox glyph is likely wider than 80px, which could cause overlap or horizontal overflow when the layout wraps. Consider measuring the widest label with ImGui::CalcTextSize or bumping the estimate to ~110px.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/Features/WeatherEditor.cpp`:
- Around line 638-654: The "Lock Weather" button silently no-ops when
sky->currentWeather is null; wrap the ImGui::Button(lockLabel) with a disable
block and adjust the tooltip so users see why it’s disabled: use
ImGui::BeginDisabled(!sky->currentWeather && !isLocked) / ImGui::EndDisabled()
(or PushItemFlag/PopItemFlag if BeginDisabled isn't available) so the button is
disabled when there's no current weather, keep the existing click branch for
unlocking (editorWindow->UnlockWeather) and only call
editorWindow->LockWeather(sky->currentWeather) when sky->currentWeather is
non-null, and update the HoverTooltipWrapper text to explain the disabled state
(e.g., "No active weather to lock") when appropriate.

🧹 Nitpick comments (1)

src/Features/WeatherEditor.cpp (1)

1017-1038: Dual mapping between flag names and enum values is fragile.

GetWeatherFlagNames (lines 898–910) defines the enum→string mapping (e.g. "PermAurora"→"Aurora"), while GetWeatherFlagColorByName here defines the inverse string→enum map independently. Adding or renaming a flag in one place without updating the other will silently break color lookups.

Consider a single shared mapping (e.g., a constexpr array of {flag, displayName} tuples) that both functions consume, so the two directions can't drift apart.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[davo0411]

bad use theme colours

[davo0411]

should probably be dynamic but meh idc