chore(llf): remove LLF settings loading

[brucenguyen]

Re-attempt #1834.

Going to be tackling some simpler issues to sort of onboard and make use of the dev title.

These changes were originally reverted to solve issues for 1.4.11 release but the changes seem safe, unrelated to the issues caused in the 1.4.10 release.

The original issue was to remove the contact shadows setting, but it seems completely redundant to be saving any of these debug settings at all. Aims to resolve #1836.

Tested in game, restarted several times and toggled the settings. They persist during the session and are reset in the next session, as expected. The JSON entry is null as expected.

Summary by CodeRabbit

Refactor

• Light Limit Fix settings persistence (save/load functionality) has been removed
• Removed the "Enable Contact Shadows" configuration option from Light Limit Fix settings

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes remove JSON serialization support and settings persistence methods from the LightLimitFix feature, eliminating the virtual LoadSettings/SaveSettings interface and the EnableContactShadows configuration flag while keeping RestoreDefaultSettings functionality intact.

Changes

Cohort / File(s)	Summary
LightLimitFix Settings Serialization Removal src/Features/LightLimitFix.h, src/Features/LightLimitFix.cpp	Removed JSON (de)serialization support via NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT, virtual LoadSettings/SaveSettings methods, and EnableContactShadows configuration field from Settings struct. RestoreDefaultSettings method retained.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: replace original shaders off and not saveable #1835: Directly inverse operation — adds JSON serialization and EnableContactShadows field that this PR removes.
• chore(llf): remove LightsVisualisationMode settings loading #1834: Modifies LightLimitFix settings and serialization in the same files with overlapping scope.
• feat(llf): remove particle lights #1495: Alters LightLimitFix settings API and public method signatures.

Suggested reviewers

• davo0411
• alandtse
• doodlum

Poem

🐰 A feature trimmed with careful paws,
JSON ties now severed without pause,
Settings fold, serialization gone,
RestoreDefaults hops on alone! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore(llf): remove LLF settings loading' directly and accurately describes the main change—removing the LoadSettings and SaveSettings methods from LightLimitFix, which were responsible for loading and saving LLF settings.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: ae827b8
Using base ref: ae827b8
Base commit date: 2026-02-12T11:15:29+10:00 (Thursday, February 12, 2026 11:15 AM)
No actionable suggestions for changed features.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Features/LightLimitFix.h (1)

23-28: ⚠️ Potential issue | 🟡 Minor

Duplicate entry in feature summary.

Line 27 duplicates "Enhanced visual realism" from line 26. Likely a copy-paste oversight (pre-existing).

Suggested fix

 		return {
 			"Light Limit Fix removes the vanilla game's 4-light limit, allowing unlimited dynamic lights in scenes.\n"
 			"This dramatically improves lighting quality and enables more realistic illumination scenarios.",
 			{ "Removes 4-light limit",
 				"Unlimited dynamic lights",
 				"Improved lighting quality",
-				"Enhanced visual realism",
 				"Enhanced visual realism" }
 		};

[github-actions]

✅ A pre-release build is available for this PR:
Download