fix(weather-picker): lock weathers enforcement

[SkrubbySkrubInAShrub]

This PR allows the user to swap to a different weather using the weather picker, while a lock is active.
Previously the lock would prevent this. The lock is there purely to prevent the game from transitioning to a different weather.

Summary by CodeRabbit

• Bug Fixes
  • Fixed weather selection behavior when the weather lock feature is active. The editor now properly updates the locked weather to match the newly selected option, preventing it from reverting to the previous locked weather.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0cf53e9c-528e-4891-9e3b-a07e94860343

📥 Commits

Reviewing files that changed from the base of the PR and between a847bd9 and e5dae03.

📒 Files selected for processing (1)

• src/Features/WeatherEditor.cpp

---

📝 Walkthrough

Walkthrough

The PR updates the weather selection logic in the editor to synchronize the locked weather reference when a new weather is chosen while the lock is active. When a user selects weather via the combo box, the editorWindow->lockedWeather is immediately updated to match the newly selected weather after calling ForceWeather/SetWeather.

Changes

Cohort / File(s)	Summary
Weather Lock Synchronization src/Features/WeatherEditor.cpp	Added logic to update editorWindow->lockedWeather when a new weather is selected and the lock is active, ensuring the lock enforces the newly chosen weather in subsequent Prepass() calls.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• feat(weather editor): improve weather picker UI and functionality #1863: Modifies the weather lock/Prepass flow and ForceWeather behavior with direct relation to this PR's locked-weather reference synchronization.

Suggested reviewers

• davo0411

Poem

🐰 A weather lock, now fixed with care,
When you select, the lock stays fair,
No reverting to the past,
Your chosen climate holds fast! 🌦️

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(weather-picker): lock weathers enforcement' directly relates to the main change: fixing weather lock enforcement in the weather picker to allow user-initiated weather changes while respecting the lock mechanism.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download