Skip to content

chore(llf): remove LLF settings loading #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davo0411 merged 1 commit into from
Feb 13, 2026
Merged

chore(llf): remove LLF settings loading #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/Features/LightLimitFix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@
static constexpr uint CLUSTER_MAX_LIGHTS = 128;
static constexpr uint MAX_LIGHTS = 1024;

NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT(
LightLimitFix::Settings,
Comment thread
alandtse marked this conversation as resolved.
EnableContactShadows,
LightsVisualisationMode)

void LightLimitFix::DrawSettings()
{
auto shaderCache = globals::shaderCache;
Expand Down Expand Up @@ -170,16 +165,6 @@ void LightLimitFix::SetupResources()
}
}

void LightLimitFix::LoadSettings(json& o_json)
{
settings = o_json;
}

void LightLimitFix::SaveSettings(json& o_json)
{
o_json = settings;
}

void LightLimitFix::RestoreDefaultSettings()
{
settings = {};
Expand Down
6 changes: 1 addition & 5 deletions src/Features/LightLimitFix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@ struct LightLimitFix : OverlayFeature

virtual void SetupResources() override;

virtual void LoadSettings(json& o_json) override;
virtual void SaveSettings(json& o_json) override;

virtual void RestoreDefaultSettings() override;

virtual void DrawSettings() override;
Expand All @@ -176,7 +173,6 @@ struct LightLimitFix : OverlayFeature

struct Settings
{
bool EnableContactShadows = false;
bool EnableLightsVisualisation = false;
uint LightsVisualisationMode = 0;
};
Expand Down Expand Up @@ -277,4 +273,4 @@ struct fmt::formatter<LightLimitFix::LightData>
l.radius,
(Vector3)l.positionWS[0].data, (Vector3)l.positionWS[1].data);
}
};
};