refactor(ui): add settings for shader block hotkeys

[midona-rhel]

This change is intended to stop users from accidentally trying to hit shader block hotkeys. Instead this feature will only work when it is enabled under Advanced -> Shader Debugging, where there you need to enable it. You also have the option of rebinding the buttons for how to navigate the blocked shader.

Should resolve #1617

Summary by CodeRabbit

Release Notes

• New Features
  • Added customizable shader blocking feature with dedicated hotkeys for navigating shader blocks
  • New "Shader Debug" section in Advanced Settings provides:
    • Toggle to enable/disable shader blocking functionality
    • Configurable hotkeys for navigating to previous and next shader blocks
  • Shader block navigation transitioned from developer-only mode to standard user-accessible settings with full customization

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR refactors shader-blocking hotkey handling by replacing hardcoded VK_PRIOR/VK_NEXT keys with configurable hotkeys through the Settings system. Three new settings fields are added (ShaderBlockPrevKey, ShaderBlockNextKey, EnableShaderBlocking), paired with UI controls in Advanced Settings and input handling wired through the existing SettingsState pipeline.

Changes

Cohort / File(s)	Summary
Settings Structure Extensions src/Menu.h, src/Menu.cpp	Added three new Settings fields (ShaderBlockPrevKey, ShaderBlockNextKey, EnableShaderBlocking) and replaced direct shader-block key storage (priorShaderKey, nextShaderKey) with boolean capture flags (settingShaderBlockPrevKey, settingShaderBlockNextKey) for hotkey binding UI.
Input Handling & Hotkey Wiring src/Menu.cpp	Replaced dev-mode-driven shader block iteration with conditional logic gated by EnableShaderBlocking. Added hotkey entries for ShaderBlockPrevKey/ShaderBlockNextKey in the hotkeyActions list; updated lambdas to reference new settings fields instead of old key references.
UI Controls & Settings Integration src/Menu/AdvancedSettingsRenderer.cpp, src/Menu/SettingsTabRenderer.h	Added new "Shader Debug" section to Advanced Settings with checkbox for EnableShaderBlocking and hotkey display/change controls for Block Previous and Block Next. Updated Active Shaders tooltip and wired boolean state references through SettingsState.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Input handling logic changes: Review the hotkey registration and lambda capture flow in Menu.cpp to verify correct state mapping and removal of dev-mode dependency.
• Settings serialization: Confirm the three new Settings fields are correctly integrated into the NLOHMANN macro and properly default/persist.
• UI control state binding: Verify the new SettingsTabRenderer references correctly link to the Advanced Settings renderer controls and that hotkey capture flags are properly cleared after use.

Possibly related PRs

• feat(ui): add tabs to advanced settings & PBR search #1599: Modifies the Shader Debug / shader-blocking UI surface in AdvancedSettingsRenderer with overlapping control additions.
• feat(UI): enhance shader blocking #1564: Related shader-blocking UI and hotkey/settings implementation in AdvancedSettingsRenderer.
• refactor: break apart menu #1330: Introduced the Menu/SettingsTabRenderer/AdvancedSettingsRenderer architecture that this PR extends.

Suggested reviewers

• alandtse
• doodlum

Poem

🐰 A rabbit hops through shader blocks with glee,
No more hardcoded keys—now bindable and free!
With toggles and hotkeys, the config shines bright,
Settings reborn from the input-mapped light. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding configurable settings for shader block hotkeys through the UI, including enablement toggle and key rebinding options.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 520945a
Using base ref: 520945a
Base commit date: 2025-12-03T01:43:28-08:00 (Wednesday, December 03, 2025 01:43 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[davo0411]

looks good, happy if you have tested all hotkey code as working