refactor(ui): colored text helpers#2292
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR introduces a new ChangesText Rendering Helper Refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
No actionable suggestions for changed features. |
|
✅ A pre-release build is available for this PR: |
SkrubbySkrubInAShrub
changed the title
alandtse
approved these changes
May 8, 2026
alandtse
added a commit
to YtzyFvra/skyrim-community-shaders
that referenced
this pull request
May 10, 2026
Address style/convention feedback from community-shaders#2092 review: - Use globals::game::isVR instead of REL::Module::IsVR() for runtime checks; move IsInMenu() out-of-line so it can use the global. - Replace raw ImGui::TextColored gray text with Util::Text::Disabled (helpers added in community-shaders#2292). - Replace try/catch on std::filesystem::create_directories with Util::FileHelpers::EnsureDirectoryExists. - Wrap the magic kTOTAL render-target index in a named constant (kVRSideBySideTarget) with a comment explaining it's the post- composite SBS target only valid in VR — kTOTAL on its own reads as "count of standard targets" and is misleading at the call site. No behavior change.
SkrubbySkrubInAShrub
added a commit
that referenced
this pull request
May 14, 2026
alandtse
added a commit
to YtzyFvra/skyrim-community-shaders
that referenced
this pull request
May 15, 2026
Address style/convention feedback from community-shaders#2092 review: - Use globals::game::isVR instead of REL::Module::IsVR() for runtime checks; move IsInMenu() out-of-line so it can use the global. - Replace raw ImGui::TextColored gray text with Util::Text::Disabled (helpers added in community-shaders#2292). - Replace try/catch on std::filesystem::create_directories with Util::FileHelpers::EnsureDirectoryExists. - Wrap the magic kTOTAL render-target index in a named constant (kVRSideBySideTarget) with a comment explaining it's the post- composite SBS target only valid in VR — kTOTAL on its own reads as "count of standard targets" and is misleading at the call site. No behavior change.
ParticleTroned
pushed a commit
to ParticleTroned/skyrim-community-shaders
that referenced
this pull request
May 15, 2026
Branch-preserving adaptation: add shared theme-colored text helpers and apply them to current Upscaling and shader-blocking UI sites while skipping HDRDisplay.
ParticleTroned
pushed a commit
to ParticleTroned/skyrim-community-shaders
that referenced
this pull request
May 16, 2026
Branch-preserving adaptation: add shared theme-colored text helpers and apply them to current Upscaling and shader-blocking UI sites while skipping HDRDisplay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added new namespace: Util::Text for colored text and replaced all usages of this text.
Summary by CodeRabbit
Refactor
Style