Merge master branch by joseivanlopez · Pull Request #1898 · agama-project/agama

joseivanlopez · 2025-01-15T11:40:59Z

Merge master branch in order to sync the feature branch for the new storage UI.

* Only for testing purposes.

Actually, at this moment the flag is only used for including a link to the route in the main navigation or not depending on the Product#registration value. But the idea is to limite the navigation too in future iterations.

An initial version that basically consists on - Main menu entry for registration - Global alert visible on all pages except the registration page and those mounted at "supportive paths" (temporary name) - Section with form for entering registration code and email - Section to display registration information when available Only basic workflow has been manually tested; unit tests will be added in upcoming commits.

Certain elements must not be rendered on paths that do not use the "FullLayout". Other paths, considered "accessory" paths, have been temporarily grouped under the "SUPPORTIVE_PATHS" constant to reduce code duplication when excluding elements from them. Although the approach needs improvement, starting with the naming, let's use it where needed meanwhile.

not tested!

Otherwise, it will trigger the useProduct hook which might not be available yet like in the case of the login path, in which the QueryClient has not been initialized yet.

…ct_registrion_poc_fix

Work-around issue with suse-connect cannot read credentials file.

But not rendering the link to the registration section when the user is already there. This commit also add the missing unit tests, covering all scenarios implemented until now.

To use the proper value according to the recently updated type. Basically using "no" instead of "No".

To make them work again now that it is making use of useLocation ReactRouterDom hook and to ensure it does not try to mount ProductRegistrationAlert component at certain paths.

Updating the service translation files from the agama-weblate repository

Update to release version 11. * #1495 * #1564 * #1617 * #1618 * #1625 * #1626 * #1627 * #1628 * #1630 * #1631 * #1632 * #1633 * #1634 * #1635 * #1636 * #1639 * #1640 * #1641 * #1642 * #1643 * #1644 * #1645 * #1646 * #1647 * #1648 * #1649 * #1650 * #1651 * #1652 * #1654 * #1655 * #1656 * #1657 * #1660 * #1663 * #1666 * #1667 * #1668 * #1670 * #1671 * #1673 * #1674 * #1675 * #1676 * #1677 * #1681 * #1682 * #1683 * #1684 * #1687 * #1688 * #1689 * #1690 * #1691 * #1692 * #1693 * #1694 * #1695 * #1696 * #1698 * #1699 * #1702 * #1703 * #1704 * #1705 * #1707 * #1708 * #1709 * #1710 * #1711 * #1712 * #1713 * #1714 * #1715 * #1716 * #1717 * #1718 * #1720 * #1721 * #1722 * #1723 * #1727 * #1728 * #1729 * #1731 * #1732 * #1733 * #1734 * #1735 * #1736 * #1737 * #1740 * #1741 * #1743 * #1744 * #1745 * #1746 * #1751 * #1753 * #1754 * #1755 * #1757 * #1762 * #1763 * #1764 * #1765 * #1766 * #1767 * #1769 * #1771 * #1772 * #1773 * #1774 * #1777 * #1778 * #1785 * #1786 * #1787 * #1788 * #1789 * #1790 * #1791 * #1792 * #1793 * #1794 * #1795 * #1796 * #1797 * #1798 * #1799 * #1800 * #1802 * #1803 * #1804 * #1805 * #1807 * #1808 * #1809 * #1810 * #1811 * #1812 * #1814 * #1815 * #1821 * #1822 * #1823 * #1824 * #1825 * #1826 * #1827 * #1828 * #1830 * #1831 * #1832 * #1833 * #1834 * #1835 * #1836 * #1837 * #1838 * #1839 * #1840 * #1841 * #1842 * #1843 * #1844 * #1845 * #1847 * #1848 * #1849 * #1850 * #1851 * #1854 * #1855 * #1856 * #1857 * #1860 * #1861 * #1863 * #1864 * #1865 * #1866 * #1867 * #1871 * #1872 * #1873 * #1875 * #1876 * #1877 * #1878 * #1880 * #1881 * #1882 * #1883 * #1884 * #1885 * #1886 * #1888 * #1889 * #1890

By limiting the render of the change product button and redirecting product selection path.

@jreidinger

## Problem Although it is not possible to change a product after registering one, web interface still rendering the _Change product_ action and does not redirect to the root path when users try to navigates to the product selection. ## Solution Check if there is a registration code set for both, * Do not render the change product action * Navigates to root path in case the user reach the selection product path. ## Testing - Added a new unit test - Manually tested by @jreidinger --- Related to * #1891 * #1882

joseivanlopez · 2025-01-15T11:44:05Z

Note for review: commits before 0f83668 were already reviewed in the master branch.

coveralls · 2025-01-15T11:53:58Z

Pull Request Test Coverage Report for Build 12790734815

Details

24 of 38 (63.16%) changed or added relevant lines in 12 files are covered.
349 unchanged lines in 34 files lost coverage.
Overall coverage increased (+0.8%) to 72.479%

Changes Missing Coverage	Changed/Added Lines	%
rust/agama-lib/src/product/http_client.rs	1	0.0%
rust/agama-lib/src/product/store.rs	1	0.0%
rust/agama-server/src/software/web.rs	1	0.0%
service/lib/agama/manager.rb	1	0.0%
rust/agama-lib/src/product/client.rs	2	0.0%
rust/agama-lib/src/software/model.rs	4	0.0%
service/lib/agama/dbus/storage/manager.rb	4	0.0%

Files with Coverage Reduction	New Missed Lines	%
service/lib/agama/autoyast/connections_reader.rb	1	93.75%
service/lib/agama/dbus/storage/devices_tree.rb	1	91.67%
service/lib/agama/security.rb	1	80.0%
service/service/lib/agama/autoyast/connections_reader.rb	1	93.75%
service/service/lib/agama/dbus/storage/devices_tree.rb	1	91.67%
service/service/lib/agama/security.rb	1	80.0%
service/service/lib/agama/software/product.rb	1	97.5%
service/lib/agama/autoyast/report_patching.rb	2	37.84%
service/lib/agama/dbus/y2dir/modules/Autologin.rb	2	55.7%
service/service/lib/agama/autoyast/report_patching.rb	2	37.84%

Totals
Change from base Build 12513628316:	0.8%
Covered Lines:	18930
Relevant Lines:	26118

💛 - Coveralls

with `python -m json.tool`

## Problem When changing answers format from yaml to json example file was not converted. ## Solution Convert it and also use example which provides password.

By addressing several issues, namely * use installerRender instead of plainRender, since the component now uses hooks that requires the former. * mock the ProductRegistrationAlert, to avoid the test failing because an empty render due to a suspense derived for that component. A better solution is needed, but out of the scope of this commit. * use getByRole over queryByRole Commit also drop a comment about the use of FormData API over internal component state. The question still valid, but not needed to have a FIXME there.

## Problem *csv* does not belong to the ruby standard library since ruby 3.4. The gem is still installed as part of the ruby 3.4 package, but the CI task for running unit tests fails because the code is executed via bundle. ## Solution Add the required gems to the gemspec file.

imobachgs

Given that all those changes were already reviewed, I am approving this PR.

imobachgs

Now I am approving it 😅

Prepare for releasing Agama 12: * #1858 * #1887 * #1890 * #1892 * #1893 * #1894 * #1896 * #1898 * #1899 * #1900 * #1901 * #1906 * #1908 * #1909 * #1910 * #1911 * #1912 * #1914 * #1915 * #1917 * #1919 * #1920 * #1921 * #1922 * #1923 * #1924 * #1926 * #1927 * #1928 * #1929 * #1930 * #1931 * #1932 * #1933 * #1934 * #1935 * #1936 * #1937 * #1938 * #1939 * #1942 * #1943 * #1945 * #1948 * #1949 * #1952 * #1953 * #1954 * #1955 * #1957 * #1958 * #1959 * #1961 * #1963 * #1964 * #1967 * #1969 * #1970 * #1971 * #1972 * #1973 * #1974 * #1975 * #1976 * #1977 * #1979 * #1980 * #1981 * #1982 * #1984 * #1986 * #1987 * #1988 * #1990 * #1991 * #1992 * #1993 * #1995 * #1996 * #1997 * #1999 * #2000 * #2001 * #2002 * #2003 * #2004 * #2005 * #2006 * #2007 * #2008 * #2009 * #2010 * #2011 * #2012 * #2013 * #2014 * #2015 * #2016 * #2017 * #2019 * #2021 * #2022 * #2025 * #2027 * #2029 * #2030 * #2031 * #2033 * #2034 * #2035 * #2036 * #2037 * #2038 * #2039 * #2040 * #2045 * #2046 * #2050 * #2053 * #2054 * #2055 * #2056 * #2058 * #2060 * #2061 * #2062 * #2063 * #2064 * #2066 * #2067 * #2068 * #2069 * #2070 * #2071 * #2072 * #2073 * #2075 * #2076 * #2080 * #2082 * #2083

imobachgs and others added 30 commits December 3, 2024 22:21

feat(products): add a SLES 15.6 definition

6abef5d

* Only for testing purposes.

fix(service): fix wrong method name

c593d0f

feat(service): include registration requirement in the product

fc4da53

feat(rust): include registration requirement in the product

68dad4c

feat(products): add registration requirement to SLE 15 SP6

fbbb7a7

feat(service): move the "version" field to the top-level

d0beb0b

refactor(rust): change registration "not_required" to "no"

bf7d346

chore(products): temporarily move SLE 15 definition to openSUSE package

9aac426

chore(products): swap SLE 15 and SLE 16 definitions

9906fc0

quick POC to fix registration:

22b734d

make rubocop happy and fix tests

b9c0155

fix(web): add registration to Product type

3e3708c

fix creating credentials

56fa368

feat(web): allow setting a route only for registrable products

916d41e

Actually, at this moment the flag is only used for including a link to the route in the main navigation or not depending on the Product#registration value. But the idea is to limite the navigation too in future iterations.

quick POC to fix registration: (#1807)

5aec29f

not tested!

fix(service): do not initialize the target in add_service

64d27a3

fix(web): temporarily disable a TS problem

656091e

fix reading global credentials file

945b00f

fix(web): mount registration alert only in valid paths

35f303f

Otherwise, it will trigger the useProduct hook which might not be available yet like in the case of the login path, in which the QueryClient has not been initialized yet.

Merge remote-tracking branch 'origin/product-registration' into produ…

8a886df

…ct_registrion_poc_fix

adapt tests for workaround

f385dda

fix reading global credentials file (#1810)

7997a40

Work-around issue with suse-connect cannot read credentials file.

fix: use registration requirement capitalization

f532b37

fix(web): adapt the registration alert condition

1d6c5a9

fix(web): show registration alert in all sections

0bb69a7

But not rendering the link to the registration section when the user is already there. This commit also add the missing unit tests, covering all scenarios implemented until now.

fix(web): adapt broken registration conditions

42ad4a2

To use the proper value according to the recently updated type. Basically using "no" instead of "No".

fix(web): update tests for core/Page.Content

a923a26

To make them work again now that it is making use of useLocation ReactRouterDom hook and to ensure it does not try to mount ProductRegistrationAlert component at certain paths.

fix(web): add basic tests for registration page

564d7cf

imobachgs and others added 12 commits January 12, 2025 10:18

Update service PO files (#1889)

e206964

Updating the service translation files from the agama-weblate repository

feat(products): update the SLES4SAP ID

edb54f0

doc(products): update changes file

570d9c4

feat(products): update SLES4SAP ID (#1890)

f143791

fix(web): allow changing product only if not registered

3b8cac1

By limiting the render of the change product button and redirecting product selection path.

doc(web): update changes file

3b7f3a7

Merge branch 'master' into storage-config-ui-merge-master

0f83668

fix(web): remove old useEffect

8d41d39

fix(storage): recalculate proposal only if there is a config

4e44a9e

fix(web): add missing method

f69d0df

joseivanlopez changed the base branch from master to storage-config-ui January 15, 2025 11:41

mvidner and others added 4 commits January 15, 2025 14:46

migrate answers example from yaml to prettified json

842500e

with `python -m json.tool`

migrate answers example from yaml to json (#1858)

e3944ce

## Problem When changing answers format from yaml to json example file was not converted. ## Solution Convert it and also use example which provides password.

fix(service): add missing gems

83c9ccb

This comment was marked as outdated.

Sign in to view

joseivanlopez added 3 commits January 15, 2025 14:27

service: changelog

9a4a8ec

Merge branch 'master' into storage-config-ui-merge-master

6543982

joseivanlopez marked this pull request as ready for review January 15, 2025 14:46

imobachgs reviewed Jan 15, 2025

View reviewed changes

imobachgs approved these changes Jan 15, 2025

View reviewed changes

joseivanlopez merged commit a6b50da into storage-config-ui Jan 15, 2025
7 checks passed

joseivanlopez deleted the storage-config-ui-merge-master branch January 15, 2025 15:34

imobachgs mentioned this pull request Feb 26, 2025

Update to release 12 #2084

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Merge master branch#1898

Merge master branch#1898
joseivanlopez merged 192 commits intostorage-config-uifrom
storage-config-ui-merge-master

joseivanlopez commented Jan 15, 2025 •

edited

Loading

Uh oh!

joseivanlopez commented Jan 15, 2025 •

edited

Loading

Uh oh!

coveralls commented Jan 15, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

imobachgs left a comment

Uh oh!

imobachgs left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Comments

Conversation

joseivanlopez commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joseivanlopez commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 12790734815

Details

💛 - Coveralls

Uh oh!

This comment was marked as outdated.

imobachgs left a comment

Choose a reason for hiding this comment

Uh oh!

imobachgs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

joseivanlopez commented Jan 15, 2025 •

edited

Loading

joseivanlopez commented Jan 15, 2025 •

edited

Loading

coveralls commented Jan 15, 2025 •

edited

Loading