Skip to content

fix(rust): set VC and X11 keymap#1997

Merged
imobachgs merged 5 commits intomasterfrom
fix-set-keymap
Feb 14, 2025
Merged

fix(rust): set VC and X11 keymap#1997
imobachgs merged 5 commits intomasterfrom
fix-set-keymap

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Feb 14, 2025

Bug bsc#1236174

Solution

  • Use set-keymap instead of set-x11-keymap.
  • Use the dashed form to set the language with systemd-firstboot.

Screenshot

output of `localectl` after changing the keymap

finish-classic

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13334547359

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-17.6%) to 70.81%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-server/src/l10n/model.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 13325829745: -17.6%
Covered Lines: 17711
Relevant Lines: 25012

💛 - Coveralls

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit a355b5a into master Feb 14, 2025
6 checks passed
@imobachgs imobachgs deleted the fix-set-keymap branch February 14, 2025 22:42
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
imobachgs added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments