feat(storage): allow selecting space policy#1791
Merged
joseivanlopez merged 21 commits intoagama-project:storage-config-uifrom Dec 19, 2024
Merged
feat(storage): allow selecting space policy#1791joseivanlopez merged 21 commits intoagama-project:storage-config-uifrom
joseivanlopez merged 21 commits intoagama-project:storage-config-uifrom
Conversation
joseivanlopez
force-pushed
the
storage-set-config-model
branch
3 times, most recently
from
a616f6d to
2a37ace
Compare
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
f64507c to
481f198
Compare
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
481f198 to
7bc3c88
Compare
joseivanlopez
force-pushed
the
storage-set-config-model
branch
4 times, most recently
from
49e5f85 to
466f75e
Compare
- Hook for changing drive. - Hook to set a space policy. - Hook to configure a custom space policy.
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
c4461a9 to
8c075f8
Compare
teclator
force-pushed
the
storage-set-config-model
branch
from
526d7ef to
3b5f39e
Compare
teclator
force-pushed
the
storage-set-config-model
branch
from
3b5f39e to
4c0e887
Compare
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
47f8436 to
e7730a5
Compare
joseivanlopez
changed the title
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
e7730a5 to
97dc174
Compare
ancorgs
reviewed
Dec 18, 2024
ancorgs
reviewed
Dec 18, 2024
| setIsOpen(false); | ||
| const onSpacePolicyChange = (spacePolicy: "keep" | "delete" | "resize" | "custom") => { | ||
| if (spacePolicy === "custom") { | ||
| return navigate("/storage/space-policy/" + baseName(drive.name)); |
Contributor
There was a problem hiding this comment.
This reminds me we had some conversations about what to use as id (basenames vs aliases vs something else). Is there something documented on that regard?
Contributor
Author
There was a problem hiding this comment.
It is still undecided. But I guess name/basename cannot be used for devices that are going to be created.
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
1df74e8 to
14d5921
Compare
ancorgs
reviewed
Dec 18, 2024
ancorgs
reviewed
Dec 18, 2024
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
14d5921 to
ceed757
Compare
joseivanlopez
force-pushed
the
storage-set-config-model
branch
from
cc21286 to
767cc3f
Compare
ancorgs
approved these changes
Dec 19, 2024
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
I could not review every single change because the PR is huge. But I looked at it overall and I tested it myself.
So far, LGTM.
Merged
imobachgs
added a commit
that referenced
this pull request
Jan 13, 2025
Update to release version 11. * #1495 * #1564 * #1617 * #1618 * #1625 * #1626 * #1627 * #1628 * #1630 * #1631 * #1632 * #1633 * #1634 * #1635 * #1636 * #1639 * #1640 * #1641 * #1642 * #1643 * #1644 * #1645 * #1646 * #1647 * #1648 * #1649 * #1650 * #1651 * #1652 * #1654 * #1655 * #1656 * #1657 * #1660 * #1663 * #1666 * #1667 * #1668 * #1670 * #1671 * #1673 * #1674 * #1675 * #1676 * #1677 * #1681 * #1682 * #1683 * #1684 * #1687 * #1688 * #1689 * #1690 * #1691 * #1692 * #1693 * #1694 * #1695 * #1696 * #1698 * #1699 * #1702 * #1703 * #1704 * #1705 * #1707 * #1708 * #1709 * #1710 * #1711 * #1712 * #1713 * #1714 * #1715 * #1716 * #1717 * #1718 * #1720 * #1721 * #1722 * #1723 * #1727 * #1728 * #1729 * #1731 * #1732 * #1733 * #1734 * #1735 * #1736 * #1737 * #1740 * #1741 * #1743 * #1744 * #1745 * #1746 * #1751 * #1753 * #1754 * #1755 * #1757 * #1762 * #1763 * #1764 * #1765 * #1766 * #1767 * #1769 * #1771 * #1772 * #1773 * #1774 * #1777 * #1778 * #1785 * #1786 * #1787 * #1788 * #1789 * #1790 * #1791 * #1792 * #1793 * #1794 * #1795 * #1796 * #1797 * #1798 * #1799 * #1800 * #1802 * #1803 * #1804 * #1805 * #1807 * #1808 * #1809 * #1810 * #1811 * #1812 * #1814 * #1815 * #1821 * #1822 * #1823 * #1824 * #1825 * #1826 * #1827 * #1828 * #1830 * #1831 * #1832 * #1833 * #1834 * #1835 * #1836 * #1837 * #1838 * #1839 * #1840 * #1841 * #1842 * #1843 * #1844 * #1845 * #1847 * #1848 * #1849 * #1850 * #1851 * #1854 * #1855 * #1856 * #1857 * #1860 * #1861 * #1863 * #1864 * #1865 * #1866 * #1867 * #1871 * #1872 * #1873 * #1875 * #1876 * #1877 * #1878 * #1880 * #1881 * #1882 * #1883 * #1884 * #1885 * #1886 * #1888 * #1889 * #1890
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.