Skip to content

Unattended installation reboots automatically after finish the installation (#1940)#1970

Merged
teclator merged 27 commits intomasterfrom
reboot
Feb 19, 2025
Merged

Unattended installation reboots automatically after finish the installation (#1940)#1970
teclator merged 27 commits intomasterfrom
reboot

Conversation

@teclator
Copy link
Contributor

@teclator teclator commented Feb 4, 2025 •
edited
Loading

Problem

After an unattended installation the user needs to reboot manually which is not very unattended... it should do it automatically unless the user wanted to stop in the congrats screen explicitly

Solution - Part1

  • Agama reboot command added. Only does something if Agama is in a final state
suse@vikingo-laptop:~$ sudo agama reboot
Cannot reboot the system
Anyhow(The installation has not finished correctly)
  • Unattended installation try to reboot the system when finished installing.
## AGAMA AUTO calls
  /usr/bin/agama profile import "$url"
  /usr/bin/agama install
  /usr/bin/agama reboot

Solution - Part2

Added the agama.finish kernel cmdline argument allowing to stop in the congrats screen only honored by the unattended installation

By default it will reboot the system unless the stop value is given, maybe would be nice to modify the agama reboot call by agama finish method where method could be reboot|stop|halt|poweroff, what do you think?

Testing

  • Tested manually

@teclator teclator force-pushed the reboot branch 3 times, most recently from 389ef8a to bc95a17 Compare February 5, 2025 13:12
@teclator teclator marked this pull request as ready for review February 5, 2025 13:13
imobachgs
imobachgs requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good. Just some minor things.

@coveralls
Copy link

coveralls commented Feb 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13411386950

Details

  • 6 of 36 (16.67%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 70.736%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/lib/agama/dbus/manager.rb 2 3 66.67%
rust/agama-server/src/manager/web.rs 0 5 0.0%
rust/agama-lib/src/manager.rs 0 6 0.0%
service/lib/agama/manager.rb 4 10 40.0%
rust/agama-cli/src/lib.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-cli/src/lib.rs 1 0.0%
service/lib/agama/dbus/manager.rb 5 91.25%
service/lib/agama/manager.rb 5 81.89%
Totals Coverage Status
Change from base Build 13409612956: -0.05%
Covered Lines: 17723
Relevant Lines: 25055
💛 - Coveralls

@teclator teclator mentioned this pull request Feb 13, 2025
Closed
@teclator teclator changed the title Reboot Unattended installation reboots automatically after finish the installation (#1940) Feb 13, 2025
@mchf mchf mentioned this pull request Feb 17, 2025
Merged
@teclator teclator force-pushed the reboot branch 3 times, most recently from 67bdf19 to e333e1c Compare February 17, 2025 16:31
imobachgs
imobachgs reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks but I would avoid using optional arguments unless required.

imobachgs
imobachgs requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. However, there is a conflict in the changes file and the generation of the OpenAPI docs is not working. Please, check.

@teclator teclator force-pushed the reboot branch 2 times, most recently from 0515f47 to ecd3c03 Compare February 18, 2025 18:18
@teclator teclator requested a review from imobachgs February 18, 2025 18:29
imobachgs
imobachgs approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small documentation issues. Nothing critical.

Thanks!

service/lib/agama/manager.rb Outdated
# Whatever has to be done at the end of installation
def finish_installation
#
# @param method [String, nil]
Copy link
Contributor

@imobachgs imobachgs Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to document the possible values.

@teclator teclator force-pushed the reboot branch 2 times, most recently from 051733e to a90da68 Compare February 19, 2025 08:53
jreidinger
jreidinger reviewed Feb 19, 2025
View reviewed changes
@teclator teclator merged commit 0deb38d into master Feb 19, 2025
9 checks passed
@teclator teclator deleted the reboot branch February 19, 2025 11:37
This was referenced Feb 19, 2025
Merged
Closed
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
Merged
imobachgs added a commit that referenced this pull request Feb 26, 2025
@imobachgs
Update to release 12 (#2084)
52d9ff6 
Prepare for releasing Agama 12:

* #1858
* #1887
* #1890
* #1892
* #1893
* #1894
* #1896
* #1898
* #1899
* #1900
* #1901
* #1906
* #1908
* #1909
* #1910
* #1911
* #1912
* #1914
* #1915
* #1917
* #1919
* #1920
* #1921
* #1922
* #1923
* #1924
* #1926
* #1927
* #1928
* #1929
* #1930
* #1931
* #1932
* #1933
* #1934
* #1935
* #1936
* #1937
* #1938
* #1939
* #1942
* #1943
* #1945
* #1948
* #1949
* #1952
* #1953
* #1954
* #1955
* #1957
* #1958
* #1959
* #1961
* #1963
* #1964
* #1967
* #1969
* #1970
* #1971
* #1972
* #1973
* #1974
* #1975
* #1976
* #1977
* #1979
* #1980
* #1981
* #1982
* #1984
* #1986
* #1987
* #1988
* #1990
* #1991
* #1992
* #1993
* #1995
* #1996
* #1997
* #1999
* #2000
* #2001
* #2002
* #2003
* #2004
* #2005
* #2006
* #2007
* #2008
* #2009
* #2010
* #2011
* #2012
* #2013
* #2014
* #2015
* #2016
* #2017
* #2019
* #2021
* #2022
* #2025
* #2027
* #2029
* #2030
* #2031
* #2033
* #2034
* #2035
* #2036
* #2037
* #2038
* #2039
* #2040
* #2045
* #2046
* #2050
* #2053
* #2054
* #2055
* #2056
* #2058
* #2060
* #2061
* #2062
* #2063
* #2064
* #2066
* #2067
* #2068
* #2069
* #2070
* #2071
* #2072
* #2073
* #2075
* #2076
* #2080
* #2082
* #2083
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 26, 2025
@bmwiedemann
Update agama to version 0 / rev 15 via SR 1248595
9721891 
https://build.opensuse.org/request/show/1248595
by user IGonzalezSosa + dimstar_suse
- Version 12

- Add the missing shebang line to the agama-scripts.sh shell script
  (gh#agama-project/agama#2077).
- Save logs after running post installation scripts
  (gh#agama-project/agama#2078).

- Keep the encoding when storing the locale (gh#agama-project/agama#2062).

- Extend storage model schema to support global encryption
  (gh#agama-project/agama#2031).

- Introduce the storage model to support the new storage user
  interface (gh#agama-project/agama#2033)

- Expose root and first user passwords (gh#agama-project/agama#2005).
- Remove support for auto-login.

- Added reboot command to the CLI (gh#agama-project/agama#1970)

- Set console and X11 keymaps when changing the installer keymap
  (bsc#1236174).
- Use the "dashed" form of the keymap identifier when calling
  systemd-firstboo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imobachgs imobachgs imobachgs approved these changes

@jreidinger jreidinger jreidinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teclator @coveralls @imobachgs @jreidinger