fix: properly handle installer language changes

[imobachgs]

Problem

Problems:

• It is not possible to change the language. See bsc#1233160.
• Changing to Portuguese does not work (it might be related to the code, pt-BR).
• The message while reloading the software translations is in the old language.
• Translations broken in the 3rd November 2024 iso #1724
• Switching display language via the URL parameter to es_AR does not fallback to es_ES, it uses English instead #860

Solution

Fix the D-Bus path of the LocaleProxy to the Manager's org.opensuse.Agama1.Locale interface.

Testing

• Tested manually

[dgdavid]

@imobachgs,

According to the PR's description, looks to me you're working on https://trello.com/c/isE3194l/620-agama-translations-not-working-consitently too. Please, have a look.

Thanks for addressing these translation issues.

[mvidner]

Good catch... except it does not work: 🤣 😢

When I run this code and change the UI langue in the browser, journalctl has:

Nov 12 13:10:23 c75fbede8655 agama-web-server[28278]: Sending message: Msg { type: MethodCall, serial: 157, sender: UniqueName(":1.7"), path: ObjectPath("/org/freedesktop/Locale"), iface: InterfaceName("org.freedesktop.DBus.Properties"), member: MemberName("Set"), body: Structure(Dynamic { fields: [Str, Str, Variant] }), fds: [] }
...
Nov 12 13:10:23 c75fbede8655 agama-web-server[28278]: 5:185m5:185mCould not synchronize settings in the localization D-Bus service: D-Bus service error: org.freedesktop.DBus.Error.UnknownObject: Unknown object '/org/freedesktop/Locale'

Looking up "Could not synchronize settings" in the source, I arrive at a update_dbus fn, which uses a set_locales fn, defined in...

agama/rust/agama-lib/src/localization/proxies.rs

Line 62 in 65939ce

fn set_locales(&self, value: &[&str]) -> zbus::Result<()>;

Which is a similar, yet different file from this diff
🤷

[imobachgs]

Well, it works for me (TM) 😉 Actually, I would not expect the set_locales method to be involved because that's responsible for changing the locales to install, not the installer's language. Are you changing the language through the "Installer Options" menu? Did you restart the agama-dbus-server process too (restarting the agama.service should be enough)?

Having two interfaces with the same name (org.opensuse.Agama1.Locale) is unfortunate, I know, but they are different things:

• localization/proxies refers to the Locale API (implemented in agama-dbus-server). We kept a D-Bus interface because it was needed for internal communication. But the idea is to get rid of it and rely only on HTTP.
• proxies/locale refers to an interface that is implemented by all Ruby-based services which allows to change the language.

I wonder if we should add default_path = "/org/opensuse/Agama1/Locale", to the 1st proxy, but in my testing system it seems to work (unless I am missing something).

In any case, I will build an image that includes all the changes so we can perform more tests.

[imobachgs]

I have fixed both proxies and now I see no error in the logs.

[mvidner]

Having two interfaces with the same name (org.opensuse.Agama1.Locale) is unfortunate, I know, but they are different things:

It's not unfortunate, it is wrong 😄 but it happens to work now. I hope I can add a simple fix, otherwise postpone it for another PR

[imobachgs]

Yes, it is wrong 😅 The point is that we plan to drop one of them, so it won't be duplicated anymore.

[coveralls]

Pull Request Test Coverage Report for Build 11825620593

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage remained the same at 71.326%

---

Files with Coverage Reduction	New Missed Lines	%
service/lib/agama/storage/manager.rb	1	97.08%

Totals
Change from base Build 11818318839:	0.0%
Covered Lines:	16895
Relevant Lines:	23687

---

💛 - Coveralls

[mvidner]

My manual language switching test works now
(after installing missing packages to my container, will fix that in another PR)

I can't really review the JS/TS code... it looks well formed to me 👍