chore: merge master into storage-config-ui#1926
Merged
dgdavid merged 55 commits intostorage-config-uifrom Jan 21, 2025
Merged
Conversation
yast packages should be installed per package and not as a whole pattern. Signed-off-by: Eugenio Paolantonio <eugenio.paolantonio@suse.com>
## Problem - https://bugzilla.suse.com/show_bug.cgi?id=1235827 This help output has a typo "te" next to a grammar mistake: > qa2-141-81:~ # agama profile import --help > ... > Arguments: > <URL> > Profile's URL. Supports the same schemas than te "download" command plus AutoYaST specific > ones. Supported files are json, jsonnet, sh for Agama profiles and ERB, XML, and > rules/classes directories for AutoYaST support > ## Solution Fix typo. Note that it looks like code comment, but the CLI library shows it to the user. ## Testing Rare case where I dare admit no testing ## Screenshots No
## Problem patterns-yast is not available in SLFO/SLE16. ## Solution ~~Added a requirement for the pattern only when using the openSUSE, openSUSE-PXE, Leap and Leap-PXE profiles.~~ As suggested by Josef below, dropped it entirely on openSUSE as well as the whole pattern shouldn't be installed at all.
## Problem If something goes wrong during packages installation, Agama web UI does not show any message. We found out that there are some problems: - When the connection goes down, TanStack Query will not perform any request (until the network is up). - The UI might loose the `QuestionsChanged` event if it is reconnecting the WebSocket at that point. ## Solution To overcome those problems, we have introduced the following changes: - Set TanStack Query [network mode](https://tanstack.com/query/v5/docs/framework/react/guides/network-mode) to "always" when running on localhost. - Invalidate `questions` query when the WebSocket is reconnected to make sure we do not miss any message. > [!NOTE] > We could play with the `refetchOnReconnect` setting at global level. But let's be conservative at > this point. ## Additional changes `agama-web-server`: - Exit the WebSocket handler when the client is disconnected - Log the events `web UI`: - **refactor(web): expose onerror and onclose at WSClient level** ## Testing - _Tested manually_ ## Screenshots 
## Problem When selecting SLES4SAP product it won't find base product. ## Solution After rename also base product is changed from SLES-SAP to SLES_SAP, so update base product entry. ## Testing - *Tested manually* Please note that for testing manually SCC still after registration returns old Alpha repo which missing system_installation fix and also old SLES-SAP product. For this reason I used for testing agama.install_url pointing to the latest internal products repo and skip registration ( so scc repos is not used ).
## Problem - A different product is installed in the target system than selected initially - https://bugzilla.suse.com/show_bug.cgi?id=1235931 ## Details - The product was selected but later a reset was called so the selection was lost - Then the solver selected a random product to satisfy the dependencies ## Solution - Just select the product later, after resetting the selection ## Testing - Tested manually, it fixes t he problem
Made adjustments to support an acceptable layout for actions on the product selection page. This change is expected to be temporary until the migration to PatternFly 6 is completed, at which point the entire page will be revamped.
Still pending retrieving the license to display it in the dialog open when user clicks on the license link.
Apart from displaying only available languages, still pending interface improvements and unit tests.
Agama-weblate commit: 118c829f082da156f1a45847bad46911fff13cdd
Agama-weblate commit: 118c829f082da156f1a45847bad46911fff13cdd
…the SLES product to give the admin the chance to get a minimal preparation of the operating system to run SAP workloads on plain SLES.
Add pattern sles_minimal_sap to the user selectable patterns list of the SLES product to give the admin the chance to get a minimal preparation of the operating system to run SAP workloads on plain SLES. ## Problem Today the customer can not prepare the SLES operating system during installation for running SAP workloads, so he will run into installation and performance issues later during the SAP workload installation and runtime. ## Solution Add a pattern to the user pattern list, which the user can select for SAP Server preparation during the installation.
Updating the service translation files from the agama-weblate repository
Updating the web translation files from the agama-weblate repository
They were there just for testing purposes.
## Problem Agama does not show the license of any product and does not ask the user to accept it. This is a requirement for beta 1, and it needs to be implemented as soon as possible. ## Solution Extend Agama to allow the specification of a license per product. The license should be accepted on the product selection page. The solution does not cover all cases (e.g., openSUSE licenses are not there yet) and the technical details might change soon. But it is expected to be good enough for beta 1. The licenses are included in `/usr/share/agama/eula` with one directory per license. The directory name is used as the license ID (`license.beta` and `license.final`) and it contains the translations. ## Licenses The licenses come from the https://build.suse.de/package/show/SUSE:SLE-15-SP7:GA/skelcd package. ## Testing - Added a new unit test - Tested manually ## Screenshots <details> <summary>Click to show/hide some screenshots</summary> --- **Be aware below screenshots were taken using mock data for emulating a license in a product and illustrating the new interface controls and behavior.** | Product without license | Product with license | |-|-| | | | | License accepted for a product not selected yet | License accepted for a product previously selected | |-|-| |  |  |License dialog | |-| | | </details>
## Problem  - When repository refresh fails there is no way how to retry the operation - The only workaround is to select a different product and then select back the original product - This obviously won't work if the installer contains only one product ## Solution - Detect that a repository failed and offer a reload action ## Recording <!-- [SLES4SAP-screen0.webm](https://github.com/user-attachments/assets/cd530256-c553-400a-b794-f628b06b3980) --> [SLES4SAP-screen0.webm](https://github.com/user-attachments/assets/ad9a5798-5f42-4333-8a4a-9419953a85ee) - There is a new error section with "retry" link - Unfortunately the VirtualBox does not record the mouse pointer so it not obvious that the "Try again" link was clicked by mouse - For easier testing I used a local copy of the SLE repository to easily simulate unreachable repository and make it working for the retry attempt. That's why you see a different (local) repository in the recording. ## Details - It turned out that it is not simple to detect a repository failure in the software page. - It reports an issue but it might contain a translated text or there might be a different issue like missing product or pattern. That means we cannot use the issues texts. - We will very likely need a repository management later anyway it makes sense to add API for fetching the current repository setup with the load status (succeeded or failed). ## Tasks - [x] DBus interface for listing the current repository setup (added the `ListRepositories` DBus method) - [x] Add the HTTP API endpoint `/api/software/repositories` using the DBus backend above (@jreidinger thanks!) - [x] Adapt the frontend code to show a failure - [x] Adapt the frontend to retry after clicking a button --------- Co-authored-by: Josef Reidinger <jreidinger@suse.cz>
To adapt them to PF6 after mergin master into the feature branch.
By looking for a hidden element and adding a FIXME to see what is making the component to be hidden for the a11y API.
joseivanlopez
approved these changes
Jan 21, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
Feb 26, 2025
Prepare for releasing Agama 12: * #1858 * #1887 * #1890 * #1892 * #1893 * #1894 * #1896 * #1898 * #1899 * #1900 * #1901 * #1906 * #1908 * #1909 * #1910 * #1911 * #1912 * #1914 * #1915 * #1917 * #1919 * #1920 * #1921 * #1922 * #1923 * #1924 * #1926 * #1927 * #1928 * #1929 * #1930 * #1931 * #1932 * #1933 * #1934 * #1935 * #1936 * #1937 * #1938 * #1939 * #1942 * #1943 * #1945 * #1948 * #1949 * #1952 * #1953 * #1954 * #1955 * #1957 * #1958 * #1959 * #1961 * #1963 * #1964 * #1967 * #1969 * #1970 * #1971 * #1972 * #1973 * #1974 * #1975 * #1976 * #1977 * #1979 * #1980 * #1981 * #1982 * #1984 * #1986 * #1987 * #1988 * #1990 * #1991 * #1992 * #1993 * #1995 * #1996 * #1997 * #1999 * #2000 * #2001 * #2002 * #2003 * #2004 * #2005 * #2006 * #2007 * #2008 * #2009 * #2010 * #2011 * #2012 * #2013 * #2014 * #2015 * #2016 * #2017 * #2019 * #2021 * #2022 * #2025 * #2027 * #2029 * #2030 * #2031 * #2033 * #2034 * #2035 * #2036 * #2037 * #2038 * #2039 * #2040 * #2045 * #2046 * #2050 * #2053 * #2054 * #2055 * #2056 * #2058 * #2060 * #2061 * #2062 * #2063 * #2064 * #2066 * #2067 * #2068 * #2069 * #2070 * #2071 * #2072 * #2073 * #2075 * #2076 * #2080 * #2082 * #2083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the feature branch in sync with master.